mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-08-21 14:47:17 +00:00
* test(server): add API surface snapshot guardrail
Boot startServer on port 0 and snapshot the documented v1 route table derived from /openapi.json paths, plus the reachability of doc/meta endpoints (/healthz, /openapi.json, /asyncapi.json, /). Gives later auth/--host phases an intentional diff when routes change. M0 makes no production behavior change.
* test(server): add e2e server harness with token support
Add test/helpers/serverHarness.ts: boot() wraps startServer with an isolated lock + home dir and returns a handle (server, address, baseUrl, wsUrl, token, close) plus authedFetch/authedWs that carry Authorization: Bearer <token> (and the kimi-code.bearer.<token> WS subprotocol). serviceOverrides is the generic DI seam later phases use to inject a fixed-token auth service; IAuthTokenService is not referenced yet. closeAll() tears down every booted server and socket. M0 makes no production behavior change; typecheck-only gate.
* feat(server): add privateFiles 0600 atomic write/read utility
* feat(server): add per-start tokenStore
* feat(server): add env-based bcrypt password hash utility
* feat(server): add IAuthTokenService DI seam
* feat(server): add global onRequest auth hook with bypass + redaction
* fix(server): stop reflecting Host header in /asyncapi.json
* feat(server): add WS bearer subprotocol constant and parser
* feat(server): enforce bearer token auth on WS upgrade
* feat(server): add Host header allowlist middleware
* feat(server): add Origin/CORS middleware
* feat(server): wire Host/Origin checks into HTTP and WS
* feat(server): wire token auth, Host/Origin, and WS auth into start.ts
* fix(server): create lock file with 0600 permissions
* fix(server): suppress debug routes on non-loopback binds
* feat(kimi-code): read server token and send Authorization on CLI calls
* feat(kimi-code): inject server token into /web URL fragment
* feat(server): add bindClassify for loopback/lan/public classification
* feat(kimi-code): register --host flag and pass it through the daemon
* feat(server): require password and TLS opt-out on non-loopback binds
* feat(server): rate-limit repeated auth failures on non-loopback binds
* feat(server): disable shutdown and terminals on public binds by default
* feat(server): add security response headers on non-loopback binds
* test(server): cover LAN/public host-exposure hardening end to end
* docs(server): add deployment security and threat-model guide
* changeset: minor kimi-code for server auth and host exposure
* feat(kimi-web): add server bearer-token auth support
* fix: repair CI for server auth and host exposure
- Replace native @node-rs/bcrypt with pure-JS bcryptjs so the ESM CLI
bundle and the SEA native bundle both build without native-addon
require issues (node-rs/bcrypt broke the ESM smoke and the SEA
check-bundle allowlist).
- Remove dead cleanup references (stopSpinner, authLogoBlinkTimer) in
apps/kimi-web App.vue that failed vue-tsc.
- Fix lint: drop empty spread fallbacks in the e2e auth-header merge,
void the intentionally-async WS upgrade listener, add missing
assertions to satisfy jest/expect-expect, and convert a ternary
statement to if/else.
- Send the bearer token in the snapshot perf/smoke tests so they pass
under the new global auth hook.
- Refresh the pnpmDeps hash in flake.nix for the updated lockfile.
* feat(server): persist bearer token and add rotate-token command
- persist the server bearer token in <home>/server.token (0600) and reuse it across restarts instead of per-start server-<pid>.token
- add `kimi server rotate-token` to regenerate the token; the token store reloads on mtime/inode change so rotation applies without restart
- print the token and Vite-style Local/Network URLs in the startup banner
- allow non-loopback binds with bearer-token-only auth (password now optional) and update SECURITY.md
- surface daemon boot failures immediately with the exit reason and log tail instead of waiting for the spawn timeout
* feat(server): print full token URLs and re-print links after rotate
- Drop the ready-panel border so token URLs print in full for copying; keep the Kimi sprite beside the title.
- Re-print Local/Network access links after `server rotate-token` (host/port from the lock).
- Extract shared access-URL helpers into access-urls.ts.
- Unify link and token colors between the banner and rotate-token.
* feat(server): dim URL #token= fragment and de-highlight token
- Render the `#token=…` fragment in a dim gray so the host/port stands out in the banner and rotate-token links.
- De-highlight the standalone token; set it off with surrounding whitespace instead of color.
- Add splitTokenFragment helper.
* refactor(cli): polish server ready banner and rotate-token output
- move version onto the ready banner title line; drop the separate
Ready:/Version: rows and the startup-time metric
- reorder rotate-token output so the new token sits between the
invalidation note and the access links
- update server CLI tests for the new layout
* feat(server): warn on reuse and refine ready banner
- Warn when `server run` reuses an already-running daemon (its options are not applied) and show the running server's actual URLs.
- Show a `Network: off use --host 0.0.0.0 to enable` hint on loopback binds.
- Move the version onto the title line and drop the startup-time metric.
* fix(web): relabel auth dialog to token and cover full page
- Relabel the server auth dialog from "password" to "token"; the server accepts the bearer token, with the password only as a fallback.
- Make the auth dialog overlay fully opaque so it covers the whole page instead of revealing the login page underneath.
* fix: resolve CI failures on web auth PR
- Replace chalk.yellow named color with chalk.hex(darkColors.warning)
in the server reuse notice to satisfy the chalk named color guard.
- Update pnpmDeps hash in flake.nix to match the regenerated
pnpm-lock.yaml so the Nix build succeeds.
- Retry rmSync in ws-broadcast e2e teardown to ride out EBUSY /
ENOTEMPTY races while the server flushes files after close().
* test(server): update API surface snapshot for warnings route
The feat/web-auth branch adds GET /api/v1/sessions/{session_id}/warnings
(packages/server/src/routes/sessions.ts), so the API surface guardrail
snapshot needs to record the new documented v1 route.
252 lines
7.6 KiB
TypeScript
252 lines
7.6 KiB
TypeScript
/**
|
|
* WS upgrade auth (ROADMAP M3).
|
|
*
|
|
* M3.1 adds the `kimi-code.bearer.<token>` subprotocol parser; M3.2 wires it
|
|
* into the upgrade path. The parser is exercised as pure unit cases first; the
|
|
* upgrade-path cases boot `startServer` with a fixed-token
|
|
* `IAuthTokenService` injected through `wsGatewayOptions.authTokenService`.
|
|
*/
|
|
|
|
import { mkdtempSync, rmSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
|
|
import { pino } from 'pino';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { WebSocket } from 'ws';
|
|
|
|
import { startServer, type RunningServer } from '../src';
|
|
import { IAuthTokenService } from '../src/services/auth/authTokenService';
|
|
import { extractWsBearerToken } from '../src/services/gateway/wsGateway';
|
|
import { rawDataToString } from '../src/ws/rawData';
|
|
|
|
describe('extractWsBearerToken', () => {
|
|
it('returns undefined for a missing header', () => {
|
|
expect(extractWsBearerToken(undefined)).toBeUndefined();
|
|
});
|
|
|
|
it('returns undefined for an empty header', () => {
|
|
expect(extractWsBearerToken('')).toBeUndefined();
|
|
});
|
|
|
|
it('extracts the token from a single bearer subprotocol', () => {
|
|
expect(extractWsBearerToken('kimi-code.bearer.TOKEN')).toBe('TOKEN');
|
|
});
|
|
|
|
it('finds the bearer subprotocol among a comma-separated list', () => {
|
|
expect(extractWsBearerToken('other, kimi-code.bearer.TOKEN2')).toBe('TOKEN2');
|
|
});
|
|
|
|
it('returns undefined for an empty token', () => {
|
|
expect(extractWsBearerToken('kimi-code.bearer.')).toBeUndefined();
|
|
});
|
|
|
|
it('returns undefined when no subprotocol matches', () => {
|
|
expect(extractWsBearerToken('unrelated')).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
interface WsFrame {
|
|
type: string;
|
|
payload?: unknown;
|
|
[k: string]: unknown;
|
|
}
|
|
|
|
interface Conn {
|
|
ws: WebSocket;
|
|
queue: WsFrame[];
|
|
waiters: Array<(frame: WsFrame) => void>;
|
|
closed: Promise<{ code: number; reason: string }>;
|
|
}
|
|
|
|
interface ConnectOptions {
|
|
protocols?: string[];
|
|
headers?: Record<string, string>;
|
|
}
|
|
|
|
let tmpDir: string;
|
|
let lockPath: string;
|
|
let bridgeHome: string;
|
|
const running: RunningServer[] = [];
|
|
|
|
beforeEach(() => {
|
|
tmpDir = mkdtempSync(join(tmpdir(), 'kimi-server-ws-auth-'));
|
|
lockPath = join(tmpDir, 'lock');
|
|
bridgeHome = mkdtempSync(join(tmpdir(), 'kimi-server-ws-auth-home-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
for (const r of running.splice(0)) {
|
|
try {
|
|
await r.close();
|
|
} catch {
|
|
// ignore
|
|
}
|
|
}
|
|
rmSync(tmpDir, { recursive: true, force: true });
|
|
rmSync(bridgeHome, { recursive: true, force: true });
|
|
});
|
|
|
|
/** Accepts exactly `'test-token'`; mirrors the fixed-token seam used in M2. */
|
|
const fixedTokenAuth: IAuthTokenService = {
|
|
_serviceBrand: undefined,
|
|
getToken: () => 'test-token',
|
|
isValid: async (candidate) => candidate === 'test-token',
|
|
};
|
|
|
|
async function spawn(): Promise<RunningServer> {
|
|
const r = await startServer({
|
|
host: '127.0.0.1',
|
|
port: 0,
|
|
lockPath,
|
|
logger: pino({ level: 'silent' }),
|
|
coreProcessOptions: { homeDir: bridgeHome },
|
|
wsGatewayOptions: {
|
|
pingIntervalMs: 60,
|
|
pongTimeoutMs: 200,
|
|
},
|
|
// Inject the fixed token via the DI seam (M5.1 reads it through the WS
|
|
// gateway's `setAuthTokenService`, no longer via `wsGatewayOptions`).
|
|
serviceOverrides: [[IAuthTokenService, fixedTokenAuth]],
|
|
});
|
|
running.push(r);
|
|
return r;
|
|
}
|
|
|
|
function wsUrl(http: string): string {
|
|
return http.replace(/^http:\/\//, 'ws://') + '/api/v1/ws';
|
|
}
|
|
|
|
function openConn(url: string, opts?: ConnectOptions): Promise<Conn> {
|
|
return new Promise((resolve, reject) => {
|
|
const ws = new WebSocket(url, opts?.protocols, { headers: opts?.headers });
|
|
const queue: WsFrame[] = [];
|
|
const waiters: Array<(frame: WsFrame) => void> = [];
|
|
let closedResolve: (v: { code: number; reason: string }) => void;
|
|
const closed = new Promise<{ code: number; reason: string }>((res) => {
|
|
closedResolve = res;
|
|
});
|
|
ws.on('message', (data) => {
|
|
let parsed: WsFrame;
|
|
try {
|
|
parsed = JSON.parse(rawDataToString(data)) as WsFrame;
|
|
} catch {
|
|
return;
|
|
}
|
|
if (waiters.length > 0) {
|
|
waiters.shift()?.(parsed);
|
|
} else {
|
|
queue.push(parsed);
|
|
}
|
|
});
|
|
ws.on('close', (code, reason) => {
|
|
closedResolve({ code, reason: String(reason) });
|
|
});
|
|
ws.once('open', () => resolve({ ws, queue, waiters, closed }));
|
|
ws.once('error', (err) => reject(err));
|
|
});
|
|
}
|
|
|
|
function receive(conn: Conn, timeoutMs: number): Promise<WsFrame> {
|
|
return new Promise((resolve, reject) => {
|
|
if (conn.queue.length > 0) {
|
|
resolve(conn.queue.shift()!);
|
|
return;
|
|
}
|
|
const t = setTimeout(() => {
|
|
const idx = conn.waiters.indexOf(waiter);
|
|
if (idx >= 0) conn.waiters.splice(idx, 1);
|
|
reject(new Error(`no message in ${timeoutMs}ms`));
|
|
}, timeoutMs);
|
|
const waiter = (frame: WsFrame): void => {
|
|
clearTimeout(t);
|
|
resolve(frame);
|
|
};
|
|
conn.waiters.push(waiter);
|
|
});
|
|
}
|
|
|
|
async function receiveType(conn: Conn, type: string, timeoutMs: number): Promise<WsFrame> {
|
|
const deadline = Date.now() + timeoutMs;
|
|
for (;;) {
|
|
const remaining = deadline - Date.now();
|
|
if (remaining <= 0) throw new Error(`no message of type ${type} within ${timeoutMs}ms`);
|
|
const frame = await receive(conn, remaining);
|
|
if (frame.type === type) return frame;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Asserts the upgrade is rejected (the socket errors/closes without ever
|
|
* opening, so no `server_hello` is received). Resolves on the first `error` or
|
|
* `close`; rejects if the socket opens or nothing happens within the timeout.
|
|
*/
|
|
function expectRejected(url: string, opts?: ConnectOptions): Promise<void> {
|
|
return new Promise((resolve, reject) => {
|
|
const ws = new WebSocket(url, opts?.protocols, { headers: opts?.headers });
|
|
const done = (err?: Error): void => {
|
|
clearTimeout(t);
|
|
ws.removeAllListeners();
|
|
try {
|
|
ws.terminate();
|
|
} catch {
|
|
// ignore
|
|
}
|
|
if (err !== undefined) reject(err);
|
|
else resolve();
|
|
};
|
|
const t = setTimeout(
|
|
() => done(new Error('connection was not rejected within timeout')),
|
|
1500,
|
|
);
|
|
ws.once('open', () => done(new Error('connection unexpectedly opened')));
|
|
ws.once('error', () => done());
|
|
ws.once('close', () => done());
|
|
});
|
|
}
|
|
|
|
describe('ws upgrade auth', () => {
|
|
it('accepts a valid bearer subprotocol and echoes it', async () => {
|
|
const r = await spawn();
|
|
const conn = await openConn(wsUrl(r.address), {
|
|
protocols: ['kimi-code.bearer.test-token'],
|
|
});
|
|
|
|
await receiveType(conn, 'server_hello', 1000);
|
|
expect(conn.ws.protocol).toBe('kimi-code.bearer.test-token');
|
|
|
|
conn.ws.close();
|
|
await conn.closed;
|
|
});
|
|
|
|
it('accepts a valid Authorization bearer header', async () => {
|
|
const r = await spawn();
|
|
const conn = await openConn(wsUrl(r.address), {
|
|
headers: { Authorization: 'Bearer test-token' },
|
|
});
|
|
|
|
const hello = await receiveType(conn, 'server_hello', 1000);
|
|
expect(hello.type).toBe('server_hello');
|
|
|
|
conn.ws.close();
|
|
await conn.closed;
|
|
});
|
|
|
|
it('rejects a wrong bearer token without server_hello', async () => {
|
|
const r = await spawn();
|
|
await expectRejected(wsUrl(r.address), {
|
|
protocols: ['kimi-code.bearer.wrong'],
|
|
});
|
|
});
|
|
|
|
it('rejects a connection with no token', async () => {
|
|
const r = await spawn();
|
|
await expectRejected(wsUrl(r.address));
|
|
});
|
|
|
|
it('rejects upgrades to a non-/api/v1/ws path', async () => {
|
|
const r = await spawn();
|
|
const badUrl = r.address.replace(/^http:\/\//, 'ws://') + '/api/v1/other';
|
|
await expectRejected(badUrl, { protocols: ['kimi-code.bearer.test-token'] });
|
|
});
|
|
});
|