mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-08-21 06:35:50 +00:00
* test(server): add API surface snapshot guardrail
Boot startServer on port 0 and snapshot the documented v1 route table derived from /openapi.json paths, plus the reachability of doc/meta endpoints (/healthz, /openapi.json, /asyncapi.json, /). Gives later auth/--host phases an intentional diff when routes change. M0 makes no production behavior change.
* test(server): add e2e server harness with token support
Add test/helpers/serverHarness.ts: boot() wraps startServer with an isolated lock + home dir and returns a handle (server, address, baseUrl, wsUrl, token, close) plus authedFetch/authedWs that carry Authorization: Bearer <token> (and the kimi-code.bearer.<token> WS subprotocol). serviceOverrides is the generic DI seam later phases use to inject a fixed-token auth service; IAuthTokenService is not referenced yet. closeAll() tears down every booted server and socket. M0 makes no production behavior change; typecheck-only gate.
* feat(server): add privateFiles 0600 atomic write/read utility
* feat(server): add per-start tokenStore
* feat(server): add env-based bcrypt password hash utility
* feat(server): add IAuthTokenService DI seam
* feat(server): add global onRequest auth hook with bypass + redaction
* fix(server): stop reflecting Host header in /asyncapi.json
* feat(server): add WS bearer subprotocol constant and parser
* feat(server): enforce bearer token auth on WS upgrade
* feat(server): add Host header allowlist middleware
* feat(server): add Origin/CORS middleware
* feat(server): wire Host/Origin checks into HTTP and WS
* feat(server): wire token auth, Host/Origin, and WS auth into start.ts
* fix(server): create lock file with 0600 permissions
* fix(server): suppress debug routes on non-loopback binds
* feat(kimi-code): read server token and send Authorization on CLI calls
* feat(kimi-code): inject server token into /web URL fragment
* feat(server): add bindClassify for loopback/lan/public classification
* feat(kimi-code): register --host flag and pass it through the daemon
* feat(server): require password and TLS opt-out on non-loopback binds
* feat(server): rate-limit repeated auth failures on non-loopback binds
* feat(server): disable shutdown and terminals on public binds by default
* feat(server): add security response headers on non-loopback binds
* test(server): cover LAN/public host-exposure hardening end to end
* docs(server): add deployment security and threat-model guide
* changeset: minor kimi-code for server auth and host exposure
* feat(kimi-web): add server bearer-token auth support
* fix: repair CI for server auth and host exposure
- Replace native @node-rs/bcrypt with pure-JS bcryptjs so the ESM CLI
bundle and the SEA native bundle both build without native-addon
require issues (node-rs/bcrypt broke the ESM smoke and the SEA
check-bundle allowlist).
- Remove dead cleanup references (stopSpinner, authLogoBlinkTimer) in
apps/kimi-web App.vue that failed vue-tsc.
- Fix lint: drop empty spread fallbacks in the e2e auth-header merge,
void the intentionally-async WS upgrade listener, add missing
assertions to satisfy jest/expect-expect, and convert a ternary
statement to if/else.
- Send the bearer token in the snapshot perf/smoke tests so they pass
under the new global auth hook.
- Refresh the pnpmDeps hash in flake.nix for the updated lockfile.
* feat(server): persist bearer token and add rotate-token command
- persist the server bearer token in <home>/server.token (0600) and reuse it across restarts instead of per-start server-<pid>.token
- add `kimi server rotate-token` to regenerate the token; the token store reloads on mtime/inode change so rotation applies without restart
- print the token and Vite-style Local/Network URLs in the startup banner
- allow non-loopback binds with bearer-token-only auth (password now optional) and update SECURITY.md
- surface daemon boot failures immediately with the exit reason and log tail instead of waiting for the spawn timeout
* feat(server): print full token URLs and re-print links after rotate
- Drop the ready-panel border so token URLs print in full for copying; keep the Kimi sprite beside the title.
- Re-print Local/Network access links after `server rotate-token` (host/port from the lock).
- Extract shared access-URL helpers into access-urls.ts.
- Unify link and token colors between the banner and rotate-token.
* feat(server): dim URL #token= fragment and de-highlight token
- Render the `#token=…` fragment in a dim gray so the host/port stands out in the banner and rotate-token links.
- De-highlight the standalone token; set it off with surrounding whitespace instead of color.
- Add splitTokenFragment helper.
* refactor(cli): polish server ready banner and rotate-token output
- move version onto the ready banner title line; drop the separate
Ready:/Version: rows and the startup-time metric
- reorder rotate-token output so the new token sits between the
invalidation note and the access links
- update server CLI tests for the new layout
* feat(server): warn on reuse and refine ready banner
- Warn when `server run` reuses an already-running daemon (its options are not applied) and show the running server's actual URLs.
- Show a `Network: off use --host 0.0.0.0 to enable` hint on loopback binds.
- Move the version onto the title line and drop the startup-time metric.
* fix(web): relabel auth dialog to token and cover full page
- Relabel the server auth dialog from "password" to "token"; the server accepts the bearer token, with the password only as a fallback.
- Make the auth dialog overlay fully opaque so it covers the whole page instead of revealing the login page underneath.
* fix: resolve CI failures on web auth PR
- Replace chalk.yellow named color with chalk.hex(darkColors.warning)
in the server reuse notice to satisfy the chalk named color guard.
- Update pnpmDeps hash in flake.nix to match the regenerated
pnpm-lock.yaml so the Nix build succeeds.
- Retry rmSync in ws-broadcast e2e teardown to ride out EBUSY /
ENOTEMPTY races while the server flushes files after close().
* test(server): update API surface snapshot for warnings route
The feat/web-auth branch adds GET /api/v1/sessions/{session_id}/warnings
(packages/server/src/routes/sessions.ts), so the API surface guardrail
snapshot needs to record the new documented v1 route.
345 lines
12 KiB
TypeScript
345 lines
12 KiB
TypeScript
/**
|
||
* Host-exposure hardening (ROADMAP M6.3–M6.7).
|
||
*
|
||
* End-to-end coverage of the §3.5 public-bind hardening stack on a
|
||
* `host: '0.0.0.0'` + `KIMI_CODE_PASSWORD` + `insecureNoTls: true` server:
|
||
* - M6.3 public-bind gate (no `--insecure-no-tls` → refuse; token-only
|
||
* (no password) + `insecureNoTls` → boot + token-only warning logged;
|
||
* password + `insecureNoTls` → boot + warn logged).
|
||
* - Real password auth path (`Authorization: Bearer <password>` → 200 via
|
||
* `verifyPassword`; wrong/missing credentials → 401).
|
||
* - M6.4 auth-failure rate limit (N bad tokens → 429 on the (N+1)th).
|
||
* - M6.5 dangerous-endpoint downgrade (shutdown/terminals 404 by default;
|
||
* 200 with the allow flags; loopback mounts shutdown by default).
|
||
* - Host allowlist (spoofed Host → 403; bound host → 200).
|
||
* - M6.6 security response headers present on a non-loopback response.
|
||
*/
|
||
|
||
import { mkdtempSync, rmSync } from 'node:fs';
|
||
import { request as httpRequest } from 'node:http';
|
||
import { tmpdir } from 'node:os';
|
||
import { join } from 'node:path';
|
||
import { Writable } from 'node:stream';
|
||
|
||
import { pino, type Logger } from 'pino';
|
||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
||
|
||
import { IServerShutdownService, startServer, type RunningServer, type ServerStartOptions } from '../src';
|
||
import { authHeaders, fixedTokenAuth } from './helpers/serverHarness';
|
||
|
||
const createdDirs: string[] = [];
|
||
const running: RunningServer[] = [];
|
||
let prevPassword: string | undefined;
|
||
|
||
function tmpPaths(): { lockPath: string; homeDir: string } {
|
||
const dir = mkdtempSync(join(tmpdir(), 'kimi-host-exposure-'));
|
||
const home = mkdtempSync(join(tmpdir(), 'kimi-host-exposure-home-'));
|
||
createdDirs.push(dir, home);
|
||
return { lockPath: join(dir, 'lock'), homeDir: home };
|
||
}
|
||
|
||
function capturingLogger(): { logger: Logger; lines: string[] } {
|
||
const lines: string[] = [];
|
||
const dest = new Writable({
|
||
write(chunk, _enc, cb) {
|
||
lines.push(String(chunk));
|
||
cb();
|
||
},
|
||
});
|
||
return { logger: pino({ level: 'info' }, dest), lines };
|
||
}
|
||
|
||
beforeEach(() => {
|
||
prevPassword = process.env['KIMI_CODE_PASSWORD'];
|
||
});
|
||
|
||
afterEach(async () => {
|
||
for (const r of running.splice(0)) {
|
||
try {
|
||
await r.close();
|
||
} catch {
|
||
// ignore — best-effort teardown
|
||
}
|
||
}
|
||
for (const dir of createdDirs.splice(0)) {
|
||
rmSync(dir, { recursive: true, force: true });
|
||
}
|
||
if (prevPassword === undefined) {
|
||
delete process.env['KIMI_CODE_PASSWORD'];
|
||
} else {
|
||
process.env['KIMI_CODE_PASSWORD'] = prevPassword;
|
||
}
|
||
});
|
||
|
||
describe('non-loopback bind gate (M6.3)', () => {
|
||
it('boots 0.0.0.0 without a password (token-only) and logs the token-only warning', async () => {
|
||
delete process.env['KIMI_CODE_PASSWORD'];
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
const { logger, lines } = capturingLogger();
|
||
|
||
const server = await startServer({
|
||
serviceOverrides: [fixedTokenAuth()],
|
||
host: '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
insecureNoTls: true,
|
||
logger,
|
||
coreProcessOptions: { homeDir },
|
||
});
|
||
running.push(server);
|
||
|
||
// The server is up with token-only auth: a gated route answers 200.
|
||
const res = await fetch(`${server.address}/api/v1/healthz`, { headers: authHeaders() });
|
||
expect(res.status).toBe(200);
|
||
|
||
// The token-only warning was logged so the operator knows the bearer token
|
||
// is the only credential protecting the exposed server.
|
||
expect(lines.join('')).toContain('token-only auth');
|
||
});
|
||
|
||
it('refuses to bind 0.0.0.0 with a password but without --insecure-no-tls', async () => {
|
||
process.env['KIMI_CODE_PASSWORD'] = 'test-pw';
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
|
||
await expect(
|
||
startServer({
|
||
serviceOverrides: [fixedTokenAuth()],
|
||
host: '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
logger: pino({ level: 'silent' }),
|
||
coreProcessOptions: { homeDir },
|
||
}),
|
||
).rejects.toThrow(/without TLS/);
|
||
});
|
||
|
||
it('boots 0.0.0.0 with a password + insecureNoTls and logs the public warning', async () => {
|
||
process.env['KIMI_CODE_PASSWORD'] = 'test-pw';
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
const { logger, lines } = capturingLogger();
|
||
|
||
const server = await startServer({
|
||
serviceOverrides: [fixedTokenAuth()],
|
||
host: '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
insecureNoTls: true,
|
||
logger,
|
||
coreProcessOptions: { homeDir },
|
||
});
|
||
running.push(server);
|
||
|
||
// The server is up: a gated route answers 200 with a valid token.
|
||
const res = await fetch(`${server.address}/api/v1/healthz`, { headers: authHeaders() });
|
||
expect(res.status).toBe(200);
|
||
|
||
// The public-bind warning was logged so the operator knows TLS is off.
|
||
const combined = lines.join('');
|
||
expect(combined).toContain('binding non-loopback host without TLS');
|
||
});
|
||
});
|
||
|
||
describe('dangerous-endpoint downgrade on a public bind (M6.5)', () => {
|
||
interface BootExposureOpts {
|
||
host?: string;
|
||
allowRemoteShutdown?: boolean;
|
||
allowRemoteTerminals?: boolean;
|
||
}
|
||
|
||
async function bootExposure(opts: BootExposureOpts = {}): Promise<{
|
||
server: RunningServer;
|
||
shutdownCalls: string[];
|
||
}> {
|
||
process.env['KIMI_CODE_PASSWORD'] = 'test-pw';
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
const shutdownCalls: string[] = [];
|
||
// Capture shutdown requests instead of exiting the process.
|
||
const noopShutdown = [
|
||
IServerShutdownService,
|
||
{
|
||
_serviceBrand: undefined,
|
||
requestShutdown: async (reason: string) => {
|
||
shutdownCalls.push(reason);
|
||
},
|
||
},
|
||
] as const;
|
||
const serviceOverrides: ServerStartOptions['serviceOverrides'] = [
|
||
fixedTokenAuth(),
|
||
noopShutdown,
|
||
];
|
||
const server = await startServer({
|
||
serviceOverrides,
|
||
host: opts.host ?? '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
insecureNoTls: true,
|
||
allowRemoteShutdown: opts.allowRemoteShutdown,
|
||
allowRemoteTerminals: opts.allowRemoteTerminals,
|
||
logger: pino({ level: 'silent' }),
|
||
coreProcessOptions: { homeDir },
|
||
});
|
||
running.push(server);
|
||
return { server, shutdownCalls };
|
||
}
|
||
|
||
const terminalsUrl = (server: RunningServer): string =>
|
||
`${server.address}/api/v1/sessions/some-session/terminals`;
|
||
|
||
it('returns 404 for shutdown and terminals on a public bind without the allow flags', async () => {
|
||
const { server } = await bootExposure();
|
||
|
||
const shutdown = await fetch(`${server.address}/api/v1/shutdown`, {
|
||
method: 'POST',
|
||
headers: authHeaders(),
|
||
});
|
||
expect(shutdown.status).toBe(404);
|
||
|
||
const terminals = await fetch(terminalsUrl(server), { headers: authHeaders() });
|
||
expect(terminals.status).toBe(404);
|
||
});
|
||
|
||
it('returns 200 for shutdown on a public bind when allowRemoteShutdown is set', async () => {
|
||
const { server, shutdownCalls } = await bootExposure({ allowRemoteShutdown: true });
|
||
|
||
const shutdown = await fetch(`${server.address}/api/v1/shutdown`, {
|
||
method: 'POST',
|
||
headers: authHeaders(),
|
||
});
|
||
expect(shutdown.status).toBe(200);
|
||
// The handler replies before triggering shutdown (setImmediate); the noop
|
||
// override captures it so the process does not exit.
|
||
await vi.waitFor(() => expect(shutdownCalls).toContain('api'));
|
||
});
|
||
|
||
it('mounts shutdown on a loopback bind by default', async () => {
|
||
const { server, shutdownCalls } = await bootExposure({ host: '127.0.0.1' });
|
||
|
||
const shutdown = await fetch(`${server.address}/api/v1/shutdown`, {
|
||
method: 'POST',
|
||
headers: authHeaders(),
|
||
});
|
||
expect(shutdown.status).toBe(200);
|
||
await vi.waitFor(() => expect(shutdownCalls).toContain('api'));
|
||
});
|
||
});
|
||
|
||
/**
|
||
* Raw HTTP GET that lets us set an arbitrary `Host` header. Node's `fetch`
|
||
* (undici) treats `Host` as a forbidden header and silently replaces it with
|
||
* the URL host, so the Host-allowlist test drives `node:http` directly.
|
||
*/
|
||
function rawHttpGet(
|
||
url: string,
|
||
headers: Record<string, string>,
|
||
): Promise<{ status: number; body: string }> {
|
||
return new Promise((resolve, reject) => {
|
||
const u = new URL(url);
|
||
const req = httpRequest(
|
||
{
|
||
hostname: u.hostname,
|
||
port: u.port,
|
||
path: `${u.pathname}${u.search}`,
|
||
method: 'GET',
|
||
headers,
|
||
},
|
||
(res) => {
|
||
let body = '';
|
||
res.on('data', (chunk: Buffer) => {
|
||
body += chunk.toString();
|
||
});
|
||
res.on('end', () => resolve({ status: res.statusCode ?? 0, body }));
|
||
},
|
||
);
|
||
req.on('error', reject);
|
||
req.end();
|
||
});
|
||
}
|
||
|
||
describe('public-bind §3.5 end-to-end (M6.7)', () => {
|
||
/**
|
||
* Boot a 0.0.0.0 server using the REAL auth impl (no fixed-token override) so
|
||
* the password `verifyPassword` path is exercised. `KIMI_CODE_PASSWORD` is set
|
||
* so the M6.3 gate passes and the password is itself a valid bearer.
|
||
*/
|
||
async function bootPublicReal(): Promise<RunningServer> {
|
||
process.env['KIMI_CODE_PASSWORD'] = 'test-pw';
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
const server = await startServer({
|
||
host: '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
insecureNoTls: true,
|
||
logger: pino({ level: 'silent' }),
|
||
coreProcessOptions: { homeDir },
|
||
});
|
||
running.push(server);
|
||
return server;
|
||
}
|
||
|
||
/** Boot a 0.0.0.0 server with a deterministic fixed token. */
|
||
async function bootPublicFixed(token = 'real-token'): Promise<RunningServer> {
|
||
process.env['KIMI_CODE_PASSWORD'] = 'test-pw';
|
||
const { lockPath, homeDir } = tmpPaths();
|
||
const server = await startServer({
|
||
serviceOverrides: [fixedTokenAuth(token)],
|
||
host: '0.0.0.0',
|
||
port: 0,
|
||
lockPath,
|
||
insecureNoTls: true,
|
||
logger: pino({ level: 'silent' }),
|
||
coreProcessOptions: { homeDir },
|
||
});
|
||
running.push(server);
|
||
return server;
|
||
}
|
||
|
||
it('accepts the user password as a bearer token (verifyPassword path)', async () => {
|
||
const server = await bootPublicReal();
|
||
const ok = await fetch(`${server.address}/api/v1/sessions`, {
|
||
headers: { Authorization: 'Bearer test-pw' },
|
||
});
|
||
expect(ok.status).toBe(200);
|
||
// Security headers ride on every non-loopback response (M6.6).
|
||
expect(ok.headers.get('x-content-type-options')).toBe('nosniff');
|
||
expect(ok.headers.get('content-security-policy')).toBe("default-src 'self'");
|
||
});
|
||
|
||
it('rejects wrong and missing credentials with 401', async () => {
|
||
const server = await bootPublicReal();
|
||
const wrong = await fetch(`${server.address}/api/v1/sessions`, {
|
||
headers: { Authorization: 'Bearer wrong-password' },
|
||
});
|
||
expect(wrong.status).toBe(401);
|
||
const missing = await fetch(`${server.address}/api/v1/sessions`);
|
||
expect(missing.status).toBe(401);
|
||
});
|
||
|
||
it('rate-limits repeated auth failures to 429 on a real bind (M6.4)', async () => {
|
||
const server = await bootPublicFixed('real-token');
|
||
const url = `${server.address}/api/v1/sessions`;
|
||
let lastStatus = 0;
|
||
// Default threshold is 10 failures; the 11th must be 429.
|
||
for (let i = 0; i < 11; i += 1) {
|
||
const res = await fetch(url, { headers: { Authorization: 'Bearer wrong' } });
|
||
lastStatus = res.status;
|
||
if (i < 10) {
|
||
expect(res.status).toBe(401);
|
||
}
|
||
}
|
||
expect(lastStatus).toBe(429);
|
||
});
|
||
|
||
it('rejects a spoofed Host with 403 and accepts the bound host', async () => {
|
||
const server = await bootPublicFixed();
|
||
// Bound host (0.0.0.0) is a literal IP → allowed by the Host allowlist.
|
||
const bound = await rawHttpGet(`${server.address}/api/v1/healthz`, {
|
||
Host: `0.0.0.0:${new URL(server.address).port}`,
|
||
});
|
||
expect(bound.status).toBe(200);
|
||
// A spoofed Host is rejected before auth (Host check runs first).
|
||
const spoofed = await rawHttpGet(`${server.address}/api/v1/healthz`, {
|
||
Host: 'evil.example.com',
|
||
});
|
||
expect(spoofed.status).toBe(403);
|
||
});
|
||
});
|