mirror of
https://github.com/block/goose.git
synced 2026-07-10 00:20:17 +00:00
6a27b69756
Some checks are pending
Unused Dependencies / machete (push) Waiting to run
Address review feedback: - Cap chunked classification at MAX_WINDOWS (12) windows. A very long command no longer waits on unbounded windows; the remainder is counted as unscanned so the existing incomplete->pattern-fallback policy applies (no clean pass for input we could not fully vet). Emits an oversized-command metric. - Name the concurrency constant (COMMAND_SCAN_CONCURRENCY) instead of a bare 3. - Document the load-bearing bytes-as-token-proxy assumption on MAX_WINDOW_CHARS. - Replace the misleading progress guard with a correct stride>0 debug_assert plus an explicit per-iteration advance assertion. - Rewrite full_text_is_covered to check coverage of the real chunk output (unique-token input) instead of reimplementing the stride loop. - Rename window_never_exceeds_token_budget -> _char_budget and assert on bytes, which is what it actually checks. Note: the 0.0-overlap debug_assert flagged in review does not fire; (0.0..1.0) includes 0.0, and the zero-overlap test passes in debug builds. 49 security tests pass; clippy --all-targets -D warnings clean. |
||
|---|---|---|
| .. | ||
| goose | ||
| goose-acp-macros | ||
| goose-cli | ||
| goose-download-manager | ||
| goose-local-inference | ||
| goose-mcp | ||
| goose-provider-types | ||
| goose-providers | ||
| goose-sdk | ||
| goose-sdk-types | ||
| goose-server | ||
| goose-test | ||
| goose-test-support | ||