From f671fbf200c047e51477ad38f1dcfb6f99e45095 Mon Sep 17 00:00:00 2001
From: Douwe Osinga <douwe@block.xyz>
Date: Wed, 7 Oct 2026 01:49:27 +0000
Subject: [PATCH] test: prevent Muse OAuth tests from opening browser (#12731)

---
 crates/goose/src/providers/muse_code_def.rs | 85 +++------------------
 1 file changed, 10 insertions(+), 75 deletions(-)

diff --git a/crates/goose/src/providers/muse_code_def.rs b/crates/goose/src/providers/muse_code_def.rs
index 6961c60e55..84c8b03b59 100644
--- a/crates/goose/src/providers/muse_code_def.rs
+++ b/crates/goose/src/providers/muse_code_def.rs
@@ -650,6 +650,7 @@ impl Provider for MuseCodeProvider {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::providers::oauth_device_flow::with_device_code_announce;
     use serde_json::json;
     use wiremock::matchers::{method, path};
     use wiremock::{Mock, MockServer, ResponseTemplate};
@@ -840,7 +841,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn configure_oauth_stores_device_flow_token() {
+    async fn configure_oauth_replaces_cached_token() {
         let server = MockServer::start().await;
         Mock::given(method("POST"))
             .and(path("/oidc/device/authorization/"))
@@ -891,12 +892,14 @@ mod tests {
                 .to_string_lossy()
                 .as_ref(),
         );
+        TokenCache::new()
+            .save(&fresh_token("old-access"))
+            .expect("existing token should save");
 
         let provider = MuseCodeProviderDef::from_env(Vec::new(), None)
             .await
             .expect("provider should build");
-        provider
-            .configure_oauth()
+        with_device_code_announce(Box::new(|_, _, _| {}), provider.configure_oauth())
             .await
             .expect("device flow should complete");
 
@@ -913,76 +916,6 @@ mod tests {
         );
     }
 
-    #[tokio::test]
-    async fn configure_oauth_reauths_even_when_a_cached_token_exists() {
-        let server = MockServer::start().await;
-        Mock::given(method("POST"))
-            .and(path("/oidc/device/authorization/"))
-            .respond_with(ResponseTemplate::new(200).set_body_json(json!({
-                "device_code": "dc-2",
-                "user_code": "ABCD-EFGH",
-                "verification_uri": format!("{}/oauth/device/", server.uri()),
-                "verification_uri_complete": format!("{}/oauth/device/?code=ABCD-EFGH", server.uri()),
-                "expires_in": 600,
-                "interval": 1
-            })))
-            .mount(&server)
-            .await;
-        Mock::given(method("POST"))
-            .and(path("/oidc/device/token/"))
-            .respond_with(ResponseTemplate::new(200).set_body_json(json!({
-                "access_token": "new-access",
-                "refresh_token": "new-refresh",
-                "expires_in": 3600
-            })))
-            .mount(&server)
-            .await;
-        Mock::given(method("POST"))
-            .and(path("/muse-code/key"))
-            .respond_with(ResponseTemplate::new(200).set_body_json(json!({
-                "api_key": "LLM-new-key"
-            })))
-            .mount(&server)
-            .await;
-
-        let _guard = env_lock::lock_env([
-            ("GOOSE_PATH_ROOT", None::<&str>),
-            ("MUSE_CODE_HOST", None::<&str>),
-            ("MUSE_CODE_AUTH_HOST", None::<&str>),
-            ("MUSE_CODE_CLIENT_ID", None::<&str>),
-            ("MUSE_AUTH_PATH", None::<&str>),
-            ("XDG_CONFIG_HOME", None::<&str>),
-        ]);
-        let temp_dir = tempfile::tempdir().expect("tempdir should be created");
-        std::env::set_var("GOOSE_PATH_ROOT", temp_dir.path());
-        std::env::set_var("MUSE_CODE_HOST", server.uri());
-        std::env::set_var("MUSE_CODE_AUTH_HOST", server.uri());
-        std::env::set_var(
-            "MUSE_AUTH_PATH",
-            temp_dir
-                .path()
-                .join("missing-auth.json")
-                .to_string_lossy()
-                .as_ref(),
-        );
-        TokenCache::new()
-            .save(&fresh_token("old-access"))
-            .expect("existing token should save");
-
-        let provider = MuseCodeProviderDef::from_env(Vec::new(), None)
-            .await
-            .expect("provider should build");
-        provider
-            .configure_oauth()
-            .await
-            .expect("device flow should re-run");
-
-        let stored = TokenCache::new().load().expect("token should be cached");
-        assert_eq!(stored.access_token, "new-access");
-        assert!(stored.refresh_token.is_empty());
-        assert_eq!(stored.api_key, "LLM-new-key");
-    }
-
     #[tokio::test]
     async fn configure_oauth_restores_previous_token_when_sign_in_fails() {
         let server = MockServer::start().await;
@@ -1206,7 +1139,7 @@ mod tests {
             .respond_with(ResponseTemplate::new(200).set_body_json(json!({
                 "device_code": "device",
                 "user_code": "ABCD-EFGH",
-                "verification_uri": "https://auth.meta.com/activate",
+                "verification_uri": format!("{}/oauth/device/", server.uri()),
                 "expires_in": 600,
                 "interval": 1
             })))
@@ -1260,7 +1193,9 @@ mod tests {
         let provider = MuseCodeProviderDef::from_env(Vec::new(), None)
             .await
             .expect("provider should build");
-        let sign_in = tokio::spawn(async move { provider.configure_oauth().await });
+        let sign_in = tokio::spawn(async move {
+            with_device_code_announce(Box::new(|_, _, _| {}), provider.configure_oauth()).await
+        });
         tokio::time::sleep(std::time::Duration::from_millis(80)).await;
         MuseCodeProvider::cleanup()
             .await