vrr/goose
2
0
Fork 0
mirror of https://github.com/block/goose.git synced 2026-04-28 03:29:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 32

Log 500 errors and also show error for direct download (#7936)

Browse source 
Co-authored-by: Douwe Osinga <douwe@squareup.com>
This commit is contained in:
Douwe Osinga 2026-03-16 14:49:59 -04:00 • committed by GitHub
parent b3510bad25
commit 8652055458
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/goose-server/src/routes/errors.rs
View file

@ -48,6 +48,12 @@ impl ErrorResponse {
impl IntoResponse for ErrorResponse {
fn into_response(self) -> Response {
if self.status.is_server_error() {
tracing::error!(status = %self.status, message = %self.message, "server error response");
} else if self.status.is_client_error() {
tracing::warn!(status = %self.status, message = %self.message, "client error response");
}
let body = Json(serde_json::json!({
"message": self.message,
}));

10
ui/desktop/src/components/settings/localInference/HuggingFaceModelSearch.tsx
View file

@ -8,6 +8,8 @@ import {
type HfModelInfo,
type HfQuantVariant,
} from '../../../api';
import { toastError } from '../../../toasts';
import { errorMessage } from '../../../utils/conversionUtils';
const formatBytes = (bytes: number): string => {
if (bytes === 0) return 'unknown';
@ -178,14 +180,18 @@ export const HuggingFaceModelSearch = ({ onDownloadStarted }: Props) => {
setDownloading((prev) => new Set(prev).add(key));
try {
const response = await downloadHfModel({
body: { spec },
body: { spec }, throwOnError: true
});
if (response.data) {
onDownloadStarted(response.data);
setDirectSpec('');
}
} catch (e) {
console.error('Direct download failed:', e);
toastError({
title: 'Direct download failed',
msg: 'Failed to start the download. Check the spec: ' + errorMessage(e),
});
} finally {
setDownloading((prev) => {
const next = new Set(prev);