vrr/goose
2
0
Fork 0
mirror of https://github.com/block/goose.git synced 2026-07-09 16:09:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 22

fix: increased mcp-app-guest request body limit (#10180)

Browse source
This commit is contained in:
Lifei Zhou 2026-07-02 14:30:53 +10:00 • committed by GitHub
parent 27958c4c29
commit 185b185fb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 37 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

39
crates/goose/src/acp/mcp_app_proxy.rs
View file

@ -1,5 +1,5 @@
use axum::{
extract::{ConnectInfo, Query, State},
extract::{ConnectInfo, DefaultBodyLimit, Query, State},
http::{header, HeaderValue, StatusCode},
response::{Html, IntoResponse, Response},
routing::{get, post},
@ -16,6 +16,7 @@ use uuid::Uuid;
const GUEST_HTML_TTL_SECS: u64 = 300;
const GUEST_HTML_MAX_ENTRIES: usize = 64;
const GUEST_HTML_MAX_BYTES: usize = 8 * 1024 * 1024;
const MCP_APP_PROXY_HTML: &str = include_str!("templates/mcp_app_proxy.html");
type GuestHtmlStore = Arc<RwLock<HashMap<String, GuestHtmlEntry>>>;
@ -382,14 +383,23 @@ pub(crate) fn routes(secret_key: String) -> Router {
Router::new()
.route("/mcp-app-proxy", get(mcp_app_proxy))
.route("/mcp-app-guest", post(store_guest_html))
.route(
"/mcp-app-guest",
post(store_guest_html).layer(DefaultBodyLimit::max(GUEST_HTML_MAX_BYTES)),
)
.with_state(state)
}
#[cfg(test)]
mod tests {
use super::{normalize_csp_source, parse_domains, peer_addr_is_loopback};
use axum::{
body::Body,
extract::ConnectInfo,
http::{header, Request, StatusCode},
};
use std::net::SocketAddr;
use tower::ServiceExt;
#[test]
fn normalizes_url_sources_to_origins() {
@ -456,4 +466,29 @@ mod tests {
&"192.168.1.10:12345".parse::<SocketAddr>().unwrap()
));
}
#[tokio::test]
async fn stores_guest_html_larger_than_default_body_limit() {
let app = super::routes("test-secret".to_string());
let large_html = "x".repeat(3 * 1024 * 1024);
let body = serde_json::json!({
"secret": "test-secret",
"html": large_html,
})
.to_string();
let mut request = Request::builder()
.method("POST")
.uri("/mcp-app-guest")
.header(header::CONTENT_TYPE, "application/json")
.body(Body::from(body))
.unwrap();
request.extensions_mut().insert(ConnectInfo(
"127.0.0.1:12345".parse::<SocketAddr>().unwrap(),
));
let response = app.oneshot(request).await.unwrap();
assert_eq!(response.status(), StatusCode::OK);
}
}