mirror of
https://github.com/Alishahryar1/free-claude-code.git
synced 2026-07-10 00:14:16 +00:00
## Problem
Python 3.14 provides native lazy annotations, but the codebase still
relied on legacy future annotation imports. Those imports also made
type-only import cycles easier to hide instead of fixing ownership
boundaries.
## Changes
| Before | After |
| --- | --- |
| Python files used `from __future__ import annotations`. | Python files
rely on Python 3.14 native lazy annotations. |
| Some runtime modules used `TYPE_CHECKING` or local imports for
required dependencies. | Runtime modules use top-level owner-module
imports with explicit boundaries. |
| Local and GitHub guardrails only rejected type ignore suppressions. |
Local and GitHub guardrails reject type ignore suppressions and legacy
future annotation imports. |
| Agent docs only documented the no-type-ignore rule. | Agent docs
document the Python 3.14 annotation and import-boundary rules. |
<!-- greptile_comment -->
<details open><summary><h3>Greptile Summary</h3></summary>
This PR moves the codebase to Python 3.14 native lazy annotations. The
main changes are:
- Removed legacy `from __future__ import annotations` imports across
Python modules.
- Promoted selected runtime dependencies from `TYPE_CHECKING` or local
imports to explicit owner-module imports.
- Added local, GitHub, and contract-test guardrails to reject legacy
future annotation imports.
- Updated agent docs with the annotation and import-boundary rules.
- Bumped the package patch version for production-file changes.
</details>
<h3>Confidence Score: 5/5</h3>
Safe to merge with low risk.
The changes are mostly mechanical annotation cleanup with matching CI
and contract-test guardrails. Reviewed import-boundary updates did not
show a confirmed runtime cycle or dependency break.
No files require special attention.
<details><summary><h3><a href="https://www.greptile.com/trex"><img
alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="20" align="absmiddle"></a> T-Rex Logs</h3></summary>
**What T-Rex did**
- Performed an end-to-end validation of the guardrail contract suite: an
environment check confirmed uv availability, a guardrail pytest run used
CPython 3.14.0 with 5 passing contract tests, 3 focused CI-script tests
passed, and the direct CI suppressions guardrail command (including the
legacy future-annotations grep) also passed.
<a
href="https://app.greptile.com/trex/runs/13303335/artifacts"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifactsDark.svg?v=4"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"><img
alt="View all artifacts"
src="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"></picture></a>
<sub><a href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="14" align="absmiddle"></a> Ran code and verified through
T-Rex</sub>
</details>
<details open><summary><h3>Important Files Changed</h3></summary>
| Filename | Overview |
|----------|----------|
| api/runtime.py | Moves messaging, CLI manager, session, limiter, and
tree dependencies from local/type-checking imports to explicit top-level
owner-module imports. |
| messaging/platforms/telegram.py | Removes future annotations and
promotes Telegram SDK type imports into the existing availability guard.
|
| messaging/platforms/telegram_inbound.py | Removes future annotations
and imports Telegram SDK types at module scope for inbound
normalization. |
| tests/contracts/test_import_boundaries.py | Adds an AST contract that
rejects legacy future annotation imports across Python files. |
| scripts/ci.sh | Extends the local suppression check to reject legacy
future annotation imports alongside type-ignore suppressions. |
| scripts/ci.ps1 | Mirrors the local PowerShell CI suppression check for
legacy future annotations. |
| .github/workflows/tests.yml | Renames and broadens the GitHub
guardrail job to reject both type suppressions and legacy future
annotations. |
| pyproject.toml | Bumps the patch version for production-file changes.
|
</details>
<details open><summary><h3>Sequence Diagram</h3></summary>
<a href="#gh-light-mode-only">
```mermaid
%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Dev as Developer/CI
participant Guard as Suppression guard
participant AST as Import-boundary contract test
participant Py as Python modules
Dev->>Guard: Run local/GitHub suppression check
Guard->>Py: "Scan *.py for type ignores and future annotations"
Guard-->>Dev: Fail if legacy annotation import remains
Dev->>AST: Run pytest contract tests
AST->>Py: Parse imports with ast
AST-->>Dev: Assert no future annotations/import-boundary violations
Py-->>Dev: Use Python 3.14 native lazy annotations
```
</a>
<a href="#gh-dark-mode-only">
```mermaid
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Dev as Developer/CI
participant Guard as Suppression guard
participant AST as Import-boundary contract test
participant Py as Python modules
Dev->>Guard: Run local/GitHub suppression check
Guard->>Py: "Scan *.py for type ignores and future annotations"
Guard-->>Dev: Fail if legacy annotation import remains
Dev->>AST: Run pytest contract tests
AST->>Py: Parse imports with ast
AST-->>Dev: Assert no future annotations/import-boundary violations
Py-->>Dev: Use Python 3.14 native lazy annotations
```
</a>
</details>
<sub>Reviews (2): Last reviewed commit: ["Remove legacy future
annotations
import"](6e6cda69da)
| [Re-trigger
Greptile](https://app.greptile.com/api/retrigger?id=41875785)</sub>
<!-- /greptile_comment -->
85 lines
3.2 KiB
Python
85 lines
3.2 KiB
Python
"""Detect forced Anthropic web server tool requests."""
|
|
|
|
from api.models.anthropic import MessagesRequest, Tool
|
|
|
|
|
|
def request_text(request: MessagesRequest) -> str:
|
|
"""Join all user/assistant message content into one string for tool input parsing."""
|
|
from .parsers import content_text
|
|
|
|
return "\n".join(content_text(message.content) for message in request.messages)
|
|
|
|
|
|
def forced_tool_turn_text(request: MessagesRequest) -> str:
|
|
"""Text for parsing forced server-tool inputs: latest user turn only (avoids stale history)."""
|
|
if not request.messages:
|
|
return ""
|
|
|
|
from .parsers import content_text
|
|
|
|
for message in reversed(request.messages):
|
|
if message.role == "user":
|
|
return content_text(message.content)
|
|
return ""
|
|
|
|
|
|
def forced_server_tool_name(request: MessagesRequest) -> str | None:
|
|
"""Return web_search or web_fetch only when tool_choice forces that server tool."""
|
|
tc = request.tool_choice
|
|
if not isinstance(tc, dict):
|
|
return None
|
|
if tc.get("type") != "tool":
|
|
return None
|
|
name = tc.get("name")
|
|
if name in {"web_search", "web_fetch"}:
|
|
return str(name)
|
|
return None
|
|
|
|
|
|
def has_tool_named(request: MessagesRequest, name: str) -> bool:
|
|
return any(tool.name == name for tool in request.tools or [])
|
|
|
|
|
|
def is_web_server_tool_request(request: MessagesRequest) -> bool:
|
|
"""True when the client forces a web server tool via tool_choice (not merely listed)."""
|
|
forced = forced_server_tool_name(request)
|
|
if forced is None:
|
|
return False
|
|
return has_tool_named(request, forced)
|
|
|
|
|
|
def is_anthropic_server_tool_definition(tool: Tool) -> bool:
|
|
"""Whether ``tool`` refers to an Anthropic server tool (web_search / web_fetch family)."""
|
|
name = (tool.name or "").strip()
|
|
if name in ("web_search", "web_fetch"):
|
|
return True
|
|
typ = tool.type
|
|
if isinstance(typ, str):
|
|
return typ.startswith("web_search") or typ.startswith("web_fetch")
|
|
return False
|
|
|
|
|
|
def has_listed_anthropic_server_tools(request: MessagesRequest) -> bool:
|
|
"""True when tools include web_search / web_fetch-style entries (listed, forced or not)."""
|
|
return any(is_anthropic_server_tool_definition(t) for t in (request.tools or []))
|
|
|
|
|
|
def openai_chat_upstream_server_tool_error(
|
|
request: MessagesRequest, *, web_tools_enabled: bool
|
|
) -> str | None:
|
|
"""Return a user-facing error when OpenAI Chat upstream cannot satisfy server-tool semantics."""
|
|
forced = forced_server_tool_name(request)
|
|
if forced and not web_tools_enabled:
|
|
return (
|
|
f"tool_choice forces Anthropic server tool {forced!r}, but local web server tools are "
|
|
"disabled (ENABLE_WEB_SERVER_TOOLS=false). Enable them or use a native Anthropic "
|
|
"Messages transport (e.g. open_router, ollama, lmstudio)."
|
|
)
|
|
if not forced and has_listed_anthropic_server_tools(request):
|
|
return (
|
|
"OpenAI Chat upstreams cannot use listed Anthropic server tools "
|
|
"(web_search / web_fetch) without the local web server tool handler. Use a native "
|
|
"Anthropic transport, set ENABLE_WEB_SERVER_TOOLS=true and force the tool with "
|
|
"tool_choice, or remove these tools from the request."
|
|
)
|
|
return None
|