free-claude-code/core/openai_responses/streaming/completion.py
Ali Khokhar 85b601884d
Some checks are pending
CI / Ban suppressions and legacy annotations (push) Waiting to run
CI / pytest (push) Waiting to run
CI / ruff-check (push) Waiting to run
CI / ruff-format (push) Waiting to run
CI / ty (push) Waiting to run
Remove legacy future annotation imports (#982)
## Problem

Python 3.14 provides native lazy annotations, but the codebase still
relied on legacy future annotation imports. Those imports also made
type-only import cycles easier to hide instead of fixing ownership
boundaries.

## Changes

| Before | After |
| --- | --- |
| Python files used `from __future__ import annotations`. | Python files
rely on Python 3.14 native lazy annotations. |
| Some runtime modules used `TYPE_CHECKING` or local imports for
required dependencies. | Runtime modules use top-level owner-module
imports with explicit boundaries. |
| Local and GitHub guardrails only rejected type ignore suppressions. |
Local and GitHub guardrails reject type ignore suppressions and legacy
future annotation imports. |
| Agent docs only documented the no-type-ignore rule. | Agent docs
document the Python 3.14 annotation and import-boundary rules. |

<!-- greptile_comment -->

<details open><summary><h3>Greptile Summary</h3></summary>

This PR moves the codebase to Python 3.14 native lazy annotations. The
main changes are:

- Removed legacy `from __future__ import annotations` imports across
Python modules.
- Promoted selected runtime dependencies from `TYPE_CHECKING` or local
imports to explicit owner-module imports.
- Added local, GitHub, and contract-test guardrails to reject legacy
future annotation imports.
- Updated agent docs with the annotation and import-boundary rules.
- Bumped the package patch version for production-file changes.
</details>

<h3>Confidence Score: 5/5</h3>

Safe to merge with low risk.

The changes are mostly mechanical annotation cleanup with matching CI
and contract-test guardrails. Reviewed import-boundary updates did not
show a confirmed runtime cycle or dependency break.

No files require special attention.

<details><summary><h3><a href="https://www.greptile.com/trex"><img
alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="20" align="absmiddle"></a> T-Rex Logs</h3></summary>

**What T-Rex did**
- Performed an end-to-end validation of the guardrail contract suite: an
environment check confirmed uv availability, a guardrail pytest run used
CPython 3.14.0 with 5 passing contract tests, 3 focused CI-script tests
passed, and the direct CI suppressions guardrail command (including the
legacy future-annotations grep) also passed.

<a
href="https://app.greptile.com/trex/runs/13303335/artifacts"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifactsDark.svg?v=4"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"><img
alt="View all artifacts"
src="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"></picture></a>

<sub><a href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="14" align="absmiddle"></a> Ran code and verified through
T-Rex</sub>
</details>

<details open><summary><h3>Important Files Changed</h3></summary>

| Filename | Overview |
|----------|----------|
| api/runtime.py | Moves messaging, CLI manager, session, limiter, and
tree dependencies from local/type-checking imports to explicit top-level
owner-module imports. |
| messaging/platforms/telegram.py | Removes future annotations and
promotes Telegram SDK type imports into the existing availability guard.
|
| messaging/platforms/telegram_inbound.py | Removes future annotations
and imports Telegram SDK types at module scope for inbound
normalization. |
| tests/contracts/test_import_boundaries.py | Adds an AST contract that
rejects legacy future annotation imports across Python files. |
| scripts/ci.sh | Extends the local suppression check to reject legacy
future annotation imports alongside type-ignore suppressions. |
| scripts/ci.ps1 | Mirrors the local PowerShell CI suppression check for
legacy future annotations. |
| .github/workflows/tests.yml | Renames and broadens the GitHub
guardrail job to reject both type suppressions and legacy future
annotations. |
| pyproject.toml | Bumps the patch version for production-file changes.
|

</details>

<details open><summary><h3>Sequence Diagram</h3></summary>

<a href="#gh-light-mode-only">

```mermaid
%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Dev as Developer/CI
participant Guard as Suppression guard
participant AST as Import-boundary contract test
participant Py as Python modules

Dev->>Guard: Run local/GitHub suppression check
Guard->>Py: "Scan *.py for type ignores and future annotations"
Guard-->>Dev: Fail if legacy annotation import remains
Dev->>AST: Run pytest contract tests
AST->>Py: Parse imports with ast
AST-->>Dev: Assert no future annotations/import-boundary violations
Py-->>Dev: Use Python 3.14 native lazy annotations
```

</a>
<a href="#gh-dark-mode-only">

```mermaid
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Dev as Developer/CI
participant Guard as Suppression guard
participant AST as Import-boundary contract test
participant Py as Python modules

Dev->>Guard: Run local/GitHub suppression check
Guard->>Py: "Scan *.py for type ignores and future annotations"
Guard-->>Dev: Fail if legacy annotation import remains
Dev->>AST: Run pytest contract tests
AST->>Py: Parse imports with ast
AST-->>Dev: Assert no future annotations/import-boundary violations
Py-->>Dev: Use Python 3.14 native lazy annotations
```

</a>
</details>

<sub>Reviews (2): Last reviewed commit: ["Remove legacy future
annotations
import"](6e6cda69da)
| [Re-trigger
Greptile](https://app.greptile.com/api/retrigger?id=41875785)</sub>

<!-- /greptile_comment -->
2026-07-04 21:41:51 -07:00

154 lines
5.3 KiB
Python

"""Block finalization for OpenAI Responses streams."""
from collections.abc import Callable
from ..errors import ResponsesConversionError
from ..items import encrypted_reasoning_item, message_item, reasoning_item
from ..tools import (
custom_tool_input_text_from_arguments,
normalized_function_call_arguments,
)
from . import event_builders as events
from .blocks import BlockState, ReasoningBlockState, TextBlockState, ToolBlockState
from .ledger import ResponsesOutputLedger
InvalidFunctionCallHandler = Callable[
[ToolBlockState, ResponsesConversionError], list[str]
]
class ResponseBlockCompleter:
"""Finalize active Responses output blocks."""
def __init__(
self,
ledger: ResponsesOutputLedger,
*,
on_invalid_function_call: InvalidFunctionCallHandler,
) -> None:
self._ledger = ledger
self._on_invalid_function_call = on_invalid_function_call
def complete_block(self, state: BlockState) -> list[str]:
if isinstance(state, TextBlockState):
return self._complete_text_block(state)
if isinstance(state, ReasoningBlockState):
return self._complete_reasoning_block(state)
return self._complete_tool_block(state)
def _complete_text_block(self, state: TextBlockState) -> list[str]:
text = "".join(state.text_parts)
item = message_item(state.item_id, text, "completed")
self._ledger.commit_output(state.output_index, item)
return [
events.output_text_done(state.item_id, state.output_index, text),
events.content_part_done(state.item_id, state.output_index, text),
events.output_item_done(state.output_index, item),
]
def _complete_reasoning_block(self, state: ReasoningBlockState) -> list[str]:
item = _reasoning_output_item(state, status="completed")
self._ledger.commit_output(state.output_index, item)
chunks: list[str] = []
text = "".join(state.text_parts)
if text:
self._ledger.add_reasoning_text(text)
chunks.append(
events.reasoning_text_done(state.item_id, state.output_index, text)
)
chunks.append(events.output_item_done(state.output_index, item))
return chunks
def _complete_tool_block(self, state: ToolBlockState) -> list[str]:
if state.kind == "custom":
return self._complete_custom_tool_block(state)
raw_arguments = "".join(state.argument_parts) or "{}"
try:
arguments = normalized_function_call_arguments(raw_arguments)
except ResponsesConversionError as exc:
return self._on_invalid_function_call(state, exc)
item = tool_item(state, status="completed", arguments=arguments)
self._ledger.commit_output(state.output_index, item)
chunks: list[str] = []
if arguments:
chunks.append(
events.function_call_arguments_delta(
state.item_id, state.output_index, arguments
)
)
chunks.extend(
[
events.function_call_arguments_done(
state.item_id, state.output_index, arguments
),
events.output_item_done(state.output_index, item),
]
)
return chunks
def _complete_custom_tool_block(self, state: ToolBlockState) -> list[str]:
input_text = custom_tool_input_text_from_arguments(
"".join(state.argument_parts)
)
item = tool_item(state, status="completed", input_text=input_text)
self._ledger.commit_output(state.output_index, item)
chunks: list[str] = []
if input_text:
chunks.append(
events.custom_tool_call_input_delta(
state.item_id, state.output_index, input_text
)
)
chunks.extend(
[
events.custom_tool_call_input_done(
state.item_id, state.output_index, input_text
),
events.output_item_done(state.output_index, item),
]
)
return chunks
def tool_item(
state: ToolBlockState,
*,
status: str,
arguments: str = "",
input_text: str = "",
) -> dict[str, object]:
if state.kind == "custom":
item: dict[str, object] = {
"id": state.item_id,
"type": "custom_tool_call",
"status": status,
"call_id": state.call_id,
"name": state.name,
"input": input_text,
}
else:
item = {
"id": state.item_id,
"type": "function_call",
"status": status,
"call_id": state.call_id,
"name": state.name,
"arguments": arguments,
}
if state.namespace:
item["namespace"] = state.namespace
return item
def reasoning_output_item(
state: ReasoningBlockState, *, status: str
) -> dict[str, object]:
if state.encrypted_content is not None:
return encrypted_reasoning_item(state.item_id, state.encrypted_content, status)
return reasoning_item(state.item_id, "".join(state.text_parts), status)
def _reasoning_output_item(
state: ReasoningBlockState, *, status: str
) -> dict[str, object]:
return reasoning_output_item(state, status=status)