mirror of
https://github.com/Alishahryar1/free-claude-code.git
synced 2026-08-29 10:11:45 +00:00
8895691450
## Problem
Admin settings exposed separate Validate and Apply actions even though
Apply independently validates the prospective configuration. The extra
step added ceremony and an unused preview request.
## Changes
- Make Apply the sole configuration action while preserving
validate-before-write behavior and existing footer errors.
- Remove the unused validation route, client request, and persistence
wrapper.
- Move validation coverage onto the real Apply path and add a rendered
Playwright regression for invalid edits.
- Update user and architecture documentation and bump the patch version
to 5.15.6.
<!-- greptile_comment -->
<details open><summary><h3>Greptile Summary</h3></summary>
The Admin configuration screen now uses Apply as its single action while
retaining validation before configuration is saved. The rendered
workflow confirms that invalid edits remain visible for correction and
do not overwrite the managed configuration.
</details>
<h3>Confidence Score: 5/5</h3>
Safe to merge based on the exercised Admin Apply workflow.
No blocking failure remains. A rendered browser check confirmed that an
invalid timeout is rejected, preserves the entered value and unsaved
state, and leaves the managed configuration unchanged.
<details><summary><h3><a href="https://www.greptile.com/trex"><img
alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="20" align="absmiddle"></a> T-Rex Logs</h3></summary>
**What T-Rex did**
- Ran a focused rendered Chromium test against the Admin page with
PROVIDER\_PROGRESS\_TIMEOUT set to 0 and clicked Apply, which produced a
field validation error, retained the entered value with one unsaved
change, kept Apply enabled, and sent a rejected POST to
/admin/api/config/apply, leaving the managed configuration unchanged.
- Reviewed the focused Playwright test source and the passing test
output to validate the test setup and outcome; the artifacts show the
exact test path rendering Admin, submitting zero, and the unchanged
managed configuration after the run.
<a
href="https://app.greptile.com/trex/runs/21186816/artifacts"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifactsDark.svg?v=4"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"><img
alt="View all artifacts"
src="https://greptile-static-assets.s3.amazonaws.com/badges/ViewAllArtifacts.svg?v=4"></picture></a>
<sub><a href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="14" align="absmiddle"></a> Ran code and verified through
T-Rex</sub>
</details>
<sub>Reviews (2): Last reviewed commit: ["Refresh Admin UI
screenshot"](
|
||
|---|---|---|
| .. | ||
| conftest.py | ||
| test_admin_apply.py | ||
| test_admin_models.py | ||
| test_admin_providers.py | ||
