Remove over-engineering: drop tree_queue setter, _set_connected(), fi… (#63)

…x cancel_all() TOCTOU

- Remove tree_queue property setter (backward-compat hack; all callers
already migrated to replace_tree_queue()); keep property getter only
- Update 2 remaining tests that still used direct assignment to use
replace_tree_queue()
- Remove _set_connected() 1-line wrapper on DiscordPlatform; assign
_connected directly
- Fix cancel_all() TOCTOU: hold self._lock for the full loop so newly
created trees cannot slip through between the snapshot and cancellation

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Ali Khokhar 2026-03-01 12:34:00 -08:00 committed by GitHub
parent 25b329a3fc
commit fae8a2a044
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 19 deletions

View file

@ -157,11 +157,6 @@ class ClaudeMessageHandler:
"""Accessor for the current tree queue manager."""
return self._tree_queue
@tree_queue.setter
def tree_queue(self, tree_queue: TreeQueueManager) -> None:
"""Backward-compatible setter routed through explicit replacement API."""
self.replace_tree_queue(tree_queue)
def replace_tree_queue(self, tree_queue: TreeQueueManager) -> None:
"""Replace tree queue manager via explicit API."""
self._tree_queue = tree_queue