mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-09 16:08:31 +00:00
857fb96269
* fix(sandbox): stop setup-sandbox from pre-pulling the stale :latest image scripts/setup-sandbox.sh's fallback (used whenever config.yaml has no uncommented sandbox.image) pulled the volces mirror's :latest tag. We confirmed in #3921/#3922 that this tag is frozen on the pre-1.9.3 all-in-one-sandbox digest (1.0.0.156), which lacks the /v1/bash/* routes required-secrets skills need — so the one script whose entire job is 'pre-pull a working sandbox image' was pre-pulling a known-broken one. Pin the fallback to :1.11.0 instead. Also update config.example.yaml's commented image: example and 'Recommended' line to the same version, so uncommenting the example doesn't reproduce the same trap. Out of scope on purpose: aio_sandbox_provider.py's DEFAULT_IMAGE constant (the harness-level default for AioSandboxProvider itself) is a separate, broader default-image decision already flagged to maintainers in #3921 — this PR only fixes the pre-pull helper script. Reported in #3914 (a real user deleted their stale local image, reran make setup-sandbox, and got the same broken :latest image back). * fix(sandbox): make setup-sandbox warn when the pull won't affect the runtime image Self-review caught a real gap in the previous commit: AioSandboxProvider resolves its image as `sandbox_config.image or DEFAULT_IMAGE` (aio_sandbox_provider.py:214), and DEFAULT_IMAGE is deliberately left untouched (still the frozen :latest, per #3921 — that's a maintainer decision, not this PR's scope). So when config.yaml has no uncommented sandbox.image, pre-pulling :1.11.0 alone creates a NEW inconsistency: the script reports success pulling a modern image, but the sandbox that actually starts still falls back to the broken :latest — silently leaving the user's underlying required-secrets/bash.exec problem unfixed, which is worse than the previous consistent-but-broken behavior (pre-pull :latest, run :latest). Make the unconfigured path loud about this instead of silent: print the exact config.yaml snippet needed to make the pulled image actually take effect. |
||
|---|---|---|
| .. | ||
| wizard | ||
| _detector_cli.py | ||
| check.py | ||
| check.sh | ||
| cleanup-containers.sh | ||
| config-upgrade.sh | ||
| configure.py | ||
| deploy.sh | ||
| detect_blocking_io_static.py | ||
| detect_thread_boundaries.py | ||
| detect_uv_extras.py | ||
| docker.sh | ||
| doctor.py | ||
| export_claude_code_oauth.py | ||
| load_memory_sample.py | ||
| nginx.sh | ||
| run-with-git-bash.cmd | ||
| sandbox_memory_profile.py | ||
| scan_changed_blocking_io.py | ||
| serve.sh | ||
| setup-sandbox.sh | ||
| setup_wizard.py | ||
| start-daemon.sh | ||
| support_bundle.py | ||
| sync_labels.py | ||
| tool-error-degradation-detection.sh | ||
| wait-for-port.sh | ||