deer-flow/frontend/tests/unit/core/scheduled-tasks/hooks.test.ts
Xinmin Zeng 4fc08b4f15
feat: add scheduled tasks MVP (#3898)
* feat: add scheduled tasks MVP

* fix: harden scheduled task execution semantics

* feat(scheduled-tasks): preset-driven schedule form with timezone and live preview

Replace the raw cron input with a preset Select (hourly/daily/weekly/monthly/custom)
plus structured inputs (time picker, weekday toggles, day-of-month), datetime-local
for one-time tasks, a timezone selector defaulting to the browser timezone, and a
live human-readable preview. Reuses one ScheduledTaskScheduleInput for create and
edit; backend contract unchanged; zero new deps (pure Intl + DST-safe offset helpers).

* feat(scheduled-tasks): full-page i18n + recipe templates + E2E locale pin

Localize the rest of the scheduled-tasks page (filters, detail pane, actions,
edit form, run list, enum values) via t.scheduledTasks.* in en/zh. Add four
built-in recipe templates (GitHub Trending, news digest, issue triage, weekly
report) exposed as a chip row that pre-fills title + prompt + schedule. Pin
Playwright locale to en-US so E2E selectors stay stable against i18n. No backend
change, no new deps.

* fix(scheduled-tasks): idempotent 0003 migration, update head constants, future-date once test

Merge with main surfaced three CI failures:
- 0003_scheduled_tasks create_table collided with legacy test seeds that
  build from full metadata; guard with inspector.has_table so the revision
  no-ops when the table already exists (0004/0005 are already idempotent via
  _helpers.py).
- persistence bootstrap concurrency/regression tests pinned HEAD to main's
  0002_runs_token_usage; bump to the new head 0005_scheduled_task_thread_nullable.
- once-task router test used a fixed past run_at and tripped the
  must-be-in-the-future validation; use a future date.

* address review: ok-check, 502 for trigger failure, mock fields, migration filename, doc fences

- fetchThreadScheduledTasks now checks response.ok like the other fetchers.
- trigger endpoint returns 502 (not 409) when dispatch fails outright, so
  clients can distinguish a real conflict from a server-side failure.
- E2E mock normalizes scheduled-task objects with context_mode/last_thread_id
  and nullable thread_id, matching the backend contract the UI renders against.
- Rename 0002_scheduled_tasks.py -> 0003_scheduled_tasks.py to match its
  revision id (file was renamed in spirit already; filename now follows).
- CONFIGURATION.md: close the Tool Groups yaml fence and drop the stray fence
  after the Scheduler notes so the sections render correctly.

* fix(scheduled-tasks): harden lease, poller, config, and frontend UX after review

* fix(scheduled-tasks): harden run lifecycle, overlap skip, non_interactive gating, and DST conversion after review

- defer a once task's terminal status to the run-completion hook; the task
  stays running until the real outcome, and a startup sweep cancels once
  tasks orphaned by a crash (launch-time 'completed' could stick forever)
- record interrupted runs as a distinct 'interrupted' run status with a
  readable message; an interrupted once task ends 'cancelled', not 'failed'
- enforce overlap_policy=skip for fresh_thread_per_run via an active-run
  pre-check (same-thread ConflictError can never fire across fresh threads)
- protect terminal run statuses from the late launch-path 'running' write
- honor context.non_interactive only for internally-authenticated callers;
  arbitrary clients can no longer strip ask_clarification
- fix DST-stale timezone offset in zonedLocalToUtcIso by re-deriving the
  offset at the resolved instant (once tasks fired an hour late around
  spring-forward and the create->edit round-trip diverged)
- drop dead ScheduledTaskRunRepository.update_by_run_id; share one Gateway
  API error helper between channels and scheduled-tasks frontends

* fix(scheduled-tasks): close review round-3 gaps in guards, concurrency, and API ergonomics

- scrub internal-only context keys (non_interactive) from the assembled run
  config for non-internal callers: gating body.context alone left the same
  key smuggle-able through the free-form body.config copied verbatim by
  build_run_config
- guard update_after_launch with protect_terminal so the launch bookkeeping
  write cannot clobber a once task already finalized by a fast-failing run's
  completion hook (parent-row sibling of the run-row guard)
- reject a manual trigger while the task has an active run (409) instead of
  launching a duplicate concurrent run on fresh_thread_per_run
- re-arm a terminal once task to enabled when PATCH pushes run_at into the
  future; previously the endpoint returned 200 with a next_run_at that could
  never be claimed
- make max_concurrent_runs a real global cap: each poll claims only into the
  remaining budget of active (queued/running) scheduled runs
- paginate GET /scheduled-tasks/{id}/runs (limit<=200, offset) and push the
  thread filter of /threads/{id}/scheduled-tasks into SQL
- stamp context.user_id on scheduler-launched runs, matching IM channels, so
  user-scoped guardrail providers see the owning user

---------

Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
2026-07-04 21:51:57 +08:00

125 lines
3.4 KiB
TypeScript

import { beforeEach, describe, expect, it, rs } from "@rstest/core";
rs.mock("@/core/api/fetcher", () => ({
fetch: rs.fn(),
}));
import { fetch } from "@/core/api/fetcher";
import {
createScheduledTask,
fetchScheduledTasks,
type ScheduledTaskPayload,
} from "@/core/scheduled-tasks/api";
const mockedFetch = rs.mocked(fetch);
const SAMPLE_TASK = {
id: "task-1",
thread_id: null as string | null,
context_mode: "fresh_thread_per_run" as const,
last_thread_id: null as string | null,
title: "Daily summary",
prompt: "Summarize thread",
schedule_type: "cron" as const,
schedule_spec: { cron: "0 9 * * *" },
timezone: "UTC",
status: "enabled" as const,
next_run_at: "2026-07-02T01:00:00+00:00",
last_run_at: null,
last_run_id: null,
last_error: null,
run_count: 0,
created_at: "2026-07-01T00:00:00+00:00",
updated_at: "2026-07-01T00:00:00+00:00",
};
function jsonResponse(body: unknown, ok = true): Response {
return {
ok,
status: 200,
statusText: "OK",
json: async () => body,
} as Response;
}
function errorResponse(
detail: string,
status = 400,
statusText = "Bad Request",
): Response {
return {
ok: false,
status,
statusText,
json: async () => ({ detail }),
} as Response;
}
describe("scheduled tasks api", () => {
beforeEach(() => {
mockedFetch.mockReset();
});
it("fetchScheduledTasks hits GET /api/scheduled-tasks", async () => {
mockedFetch.mockResolvedValue(jsonResponse([SAMPLE_TASK]));
const result = await fetchScheduledTasks();
expect(mockedFetch).toHaveBeenCalledTimes(1);
const call = mockedFetch.mock.calls[0];
expect(call).toBeDefined();
const url = String(call?.[0] as string);
expect(url).toContain("/api/scheduled-tasks");
expect(call?.[1]?.method).toBeUndefined();
expect(result).toEqual([SAMPLE_TASK]);
});
it("createScheduledTask hits POST /api/scheduled-tasks with payload", async () => {
mockedFetch.mockResolvedValue(jsonResponse(SAMPLE_TASK));
const payload: ScheduledTaskPayload = {
context_mode: "fresh_thread_per_run",
thread_id: null,
title: "Daily summary",
prompt: "Summarize thread",
schedule_type: "cron",
schedule_spec: { cron: "0 9 * * *" },
timezone: "UTC",
};
const result = await createScheduledTask(payload);
expect(mockedFetch).toHaveBeenCalledTimes(1);
const call = mockedFetch.mock.calls[0];
expect(call).toBeDefined();
const url = String(call?.[0] as string);
expect(url).toContain("/api/scheduled-tasks");
expect(call?.[1]?.method).toBe("POST");
const body = call?.[1]?.body as string;
expect(JSON.parse(body)).toEqual(payload);
expect(result).toEqual(SAMPLE_TASK);
});
it("throws an Error carrying backend detail on failure", async () => {
mockedFetch.mockResolvedValue(
errorResponse("Cron expression is invalid", 422, "Unprocessable Entity"),
);
await expect(fetchScheduledTasks()).rejects.toThrow(
"Cron expression is invalid",
);
});
it("falls back to a generic message when detail is missing", async () => {
mockedFetch.mockResolvedValue({
ok: false,
status: 502,
statusText: "Bad Gateway",
// body is not valid JSON → body.detail is undefined → fallback used
json: async () => {
throw new SyntaxError("Unexpected token");
},
} as unknown as Response);
await expect(fetchScheduledTasks()).rejects.toThrow(/Failed to load/);
});
});