mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-10 00:18:36 +00:00
dcb2e687d5
* feat(channels): add GitHub event-driven agents (#3754) Add a webhook-driven GitHub channel with fail-closed webhook routing, deterministic per-agent PR/issue threads, mention-gated trigger fan-out, GitHub App token injection for sandboxed gh/git commands, and backend/AGENTS.md documentation. * fix(llm-middleware): classify bare IndexError as transient Upstream chat providers occasionally return 200 OK with an empty generations list (observed against Volces "coding" on ark.cn-beijing.volces.com). When that happens, langchain_core.language_models.chat_models.ainvoke raises ``IndexError: list index out of range`` at ``llm_result.generations[0][0].message`` and kills the run. Treat a bare IndexError reaching the middleware as a transient upstream-payload glitch and route it through the existing retry/backoff path instead of failing the whole agent run. The retry budget and backoff schedule are unchanged. Adds three regression tests covering the classifier and both the recover-on-retry and exhausted-retries paths. * fix(runtime): ignore stale LLM fallback markers from prior runs When a run on a thread ends with the LLM-error-handling middleware emitting a `deerflow_error_fallback`-marked AIMessage (e.g. after the IndexError empty-generations classification fix lands), that message is persisted to the thread's checkpoint as part of the messages channel. LangGraph replays the full message history in `stream_mode="values"` chunks, so every subsequent run on the same thread re-streams the stale fallback marker — and the worker's chunk scanner faithfully picks it up, flipping `RunStatus.success` to `RunStatus.error` for runs that themselves had no LLM failure at all. Snapshot the set of pre-existing message ids from the pre-run checkpoint and thread it through `_extract_llm_error_fallback_message` / `_try_extract_from_message` as a filter. Markers on history messages are ignored; markers on fresh messages produced during this run still trip the error path. Falls back to an empty set when the checkpointer is absent or the snapshot can't be captured, preserving the prior behavior on first-run / no-state paths. Adds unit tests for the new filter (helper-level and `_collect_pre_existing_message_ids`) plus an integration test exercising the full `run_agent` path with a stale history checkpointer. * fix(channels): make github channel fire-and-forget to avoid httpx.ReadTimeout on long runs GitHub agent runs (clone -> edit -> test -> push -> PR) routinely exceed the langgraph_sdk default 300s read deadline. The manager's runs.wait call kept an HTTP stream open for the entire run lifetime, so the long run blew up with httpx.ReadTimeout and the outer except branch then released the dedupe key and emitted a false 'internal error' outbound. The GitHub channel's outbound send is log-only by design: agents post to the issue/PR via the gh CLI in the sandbox when they choose to comment or create a PR. There is nothing for the manager to ferry back, so the long-poll was pure overhead. This change adds ChannelRunPolicy.fire_and_forget (default False) and sets it True for the github channel. When fire_and_forget is True, _handle_chat dispatches via client.runs.create (short POST, returns once the run is pending) instead of client.runs.wait, and skips the response-extraction + outbound-publish block. ConflictError on a busy thread still trips the standard THREAD_BUSY_MESSAGE path so behavior on the busy case is preserved for any future non-github fire-and-forget channel. Other (non-github) channels are unchanged: their policy defaults fire_and_forget=False and they continue to dispatch via runs.wait. Adds 6 regression tests in tests/test_channels.py::TestGithubFireAndForget: - Default ChannelRunPolicy.fire_and_forget is False. - The github policy registers fire_and_forget=True. - github inbound calls runs.create, not runs.wait, with the right kwargs. - github inbound publishes no outbound on success. - ConflictError from runs.create still emits THREAD_BUSY_MESSAGE. - Non-github channels (slack) still dispatch via runs.wait. * test(lead-agent): accept user_id kwarg in skill-policy test stubs The two GitHub-channel tests added in #3754 stubbed _load_enabled_skills_for_tool_policy with a lambda that only accepted `available_skills` and `app_config`, but the real function (and its call site in agent.py) also passes `user_id`. This raised TypeError on every run, failing backend-unit-tests. Add `user_id=None` to match the three sibling stubs in the same file. * refactor(gateway): disambiguate context-key set names The two frozensets _INTERNAL_ONLY_CONTEXT_KEYS and _CONTEXT_ONLY_KEYS shared a confusable "CONTEXT_ONLY" token in different orders, and the first broke the _CONTEXT_<X>_KEYS pattern of its sibling _CONTEXT_CONFIGURABLE_KEYS. Rename to make the distinct axes explicit: _CONTEXT_INTERNAL_CALLER_KEYS - WHO: internal callers (scheduler) only _CONTEXT_RUNTIME_ONLY_KEYS - WHERE: runtime context only, never configurable Pure rename, no behavior change.
124 lines
4.1 KiB
Python
124 lines
4.1 KiB
Python
"""Tests for the GitHub dispatcher's identity helpers."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
|
|
import pytest
|
|
|
|
from app.gateway.github.identity import (
|
|
GITHUB_THREAD_NAMESPACE,
|
|
extract_target,
|
|
resolve_thread_id,
|
|
)
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# resolve_thread_id
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_thread_id_is_deterministic() -> None:
|
|
a = resolve_thread_id("zhfeng/llm-gateway", 11, "coder")
|
|
b = resolve_thread_id("zhfeng/llm-gateway", 11, "coder")
|
|
assert a == b
|
|
|
|
|
|
def test_thread_id_differs_per_pr() -> None:
|
|
assert resolve_thread_id("zhfeng/llm-gateway", 11, "coder") != resolve_thread_id("zhfeng/llm-gateway", 12, "coder")
|
|
|
|
|
|
def test_thread_id_differs_per_repo() -> None:
|
|
assert resolve_thread_id("a/b", 1, "coder") != resolve_thread_id("c/d", 1, "coder")
|
|
|
|
|
|
def test_thread_id_differs_per_agent() -> None:
|
|
"""Different agents on the same PR must land on different threads.
|
|
|
|
This is the headline guarantee of the per-agent thread design: coder and
|
|
reviewer bound to ``owner/repo#7`` never share a LangGraph thread, so
|
|
dual-mentions can never silently drop one run via
|
|
``multitask_strategy="reject"`` and the agents' message histories stay
|
|
independent.
|
|
"""
|
|
assert resolve_thread_id("zhfeng/llm-gateway", 7, "coder") != resolve_thread_id("zhfeng/llm-gateway", 7, "reviewer")
|
|
|
|
|
|
def test_thread_id_is_uuid5_under_namespace() -> None:
|
|
repo, num, agent = "zhfeng/llm-gateway", 11, "coder"
|
|
expected = str(uuid.uuid5(GITHUB_THREAD_NAMESPACE, f"{repo}#{num}:{agent}"))
|
|
assert resolve_thread_id(repo, num, agent) == expected
|
|
# And valid UUID.
|
|
uuid.UUID(resolve_thread_id(repo, num, agent))
|
|
|
|
|
|
def test_thread_id_rejects_bad_repo() -> None:
|
|
with pytest.raises(ValueError):
|
|
resolve_thread_id("no-slash", 1, "coder")
|
|
|
|
|
|
def test_thread_id_rejects_non_int_number() -> None:
|
|
with pytest.raises(ValueError):
|
|
resolve_thread_id("a/b", "11", "coder") # type: ignore[arg-type]
|
|
|
|
|
|
def test_thread_id_rejects_empty_agent_name() -> None:
|
|
with pytest.raises(ValueError):
|
|
resolve_thread_id("a/b", 1, "")
|
|
with pytest.raises(ValueError):
|
|
resolve_thread_id("a/b", 1, " ")
|
|
with pytest.raises(ValueError):
|
|
resolve_thread_id("a/b", 1, None) # type: ignore[arg-type]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# extract_target
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_extract_target_pull_request() -> None:
|
|
payload = {
|
|
"repository": {"full_name": "a/b"},
|
|
"pull_request": {"number": 7},
|
|
}
|
|
assert extract_target("pull_request", payload) == ("a/b", 7)
|
|
|
|
|
|
def test_extract_target_pull_request_falls_back_to_top_level_number() -> None:
|
|
# Some PR payloads put the number at the top level, not on pull_request.
|
|
payload = {"repository": {"full_name": "a/b"}, "pull_request": {}, "number": 4}
|
|
assert extract_target("pull_request", payload) == ("a/b", 4)
|
|
|
|
|
|
def test_extract_target_issue_comment() -> None:
|
|
payload = {
|
|
"repository": {"full_name": "a/b"},
|
|
"issue": {"number": 12},
|
|
"comment": {"body": "hi"},
|
|
}
|
|
assert extract_target("issue_comment", payload) == ("a/b", 12)
|
|
|
|
|
|
def test_extract_target_pull_request_review() -> None:
|
|
payload = {
|
|
"repository": {"full_name": "a/b"},
|
|
"pull_request": {"number": 5},
|
|
"review": {},
|
|
}
|
|
assert extract_target("pull_request_review", payload) == ("a/b", 5)
|
|
|
|
|
|
def test_extract_target_issues() -> None:
|
|
payload = {"repository": {"full_name": "a/b"}, "issue": {"number": 99}}
|
|
assert extract_target("issues", payload) == ("a/b", 99)
|
|
|
|
|
|
def test_extract_target_ping_returns_none() -> None:
|
|
assert extract_target("ping", {"repository": {"full_name": "a/b"}}) is None
|
|
|
|
|
|
def test_extract_target_missing_repo_returns_none() -> None:
|
|
assert extract_target("pull_request", {"pull_request": {"number": 1}}) is None
|
|
|
|
|
|
def test_extract_target_missing_number_returns_none() -> None:
|
|
assert extract_target("pull_request", {"repository": {"full_name": "a/b"}, "pull_request": {}}) is None
|