e978e00c7e
Replace custom DNS-1035 regex with k8s.io/apimachinery IsDNS1035Label. Remove hardcoded maxApplicationNameLength=40 from both validation and OpenAPI — length validation is now handled entirely by validateNameLength which computes dynamic limits based on Helm release prefix and root-host. Fix README to reflect that max length depends on cluster configuration. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
81 lines
2.5 KiB
Go
81 lines
2.5 KiB
Go
/*
|
|
Copyright 2024 The Cozystack Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package validation
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"k8s.io/apimachinery/pkg/util/validation/field"
|
|
)
|
|
|
|
func TestValidateApplicationName(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
appName string
|
|
wantError bool
|
|
}{
|
|
// Valid names
|
|
{"valid simple name", "tenant-one", false},
|
|
{"valid single letter", "a", false},
|
|
{"valid with numbers", "abc-123", false},
|
|
{"valid lowercase", "my-tenant", false},
|
|
{"valid long name", "my-very-long-tenant-name", false},
|
|
{"valid double hyphen", "my--tenant", false},
|
|
{"valid at DNS-1035 max (63 chars)", strings.Repeat("a", 63), false},
|
|
|
|
// Invalid: starts with wrong character
|
|
{"starts with digit", "1john", true},
|
|
{"only digits", "123", true},
|
|
{"starts with hyphen", "-tenant", true},
|
|
|
|
// Invalid: ends with wrong character
|
|
{"ends with hyphen", "tenant-", true},
|
|
|
|
// Invalid: wrong characters
|
|
{"uppercase letters", "Tenant", true},
|
|
{"mixed case", "myTenant", true},
|
|
{"underscore", "my_tenant", true},
|
|
{"dot", "my.tenant", true},
|
|
{"space", "my tenant", true},
|
|
{"unicode cyrillic", "тенант", true},
|
|
{"unicode emoji", "tenant🚀", true},
|
|
{"special chars", "tenant@home", true},
|
|
{"colon", "tenant:one", true},
|
|
{"slash", "tenant/one", true},
|
|
|
|
// Invalid: empty or whitespace
|
|
{"empty string", "", true},
|
|
{"only spaces", " ", true},
|
|
{"leading space", " tenant", true},
|
|
{"trailing space", "tenant ", true},
|
|
|
|
// Invalid: exceeds DNS-1035 max length (63)
|
|
{"too long (64 chars)", strings.Repeat("a", 64), true},
|
|
{"way too long (100 chars)", strings.Repeat("a", 100), true},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
errs := ValidateApplicationName(tt.appName, field.NewPath("metadata").Child("name"))
|
|
if (len(errs) > 0) != tt.wantError {
|
|
t.Errorf("ValidateApplicationName(%q) returned %d errors, wantError = %v, errors = %v",
|
|
tt.appName, len(errs), tt.wantError, errs)
|
|
}
|
|
})
|
|
}
|
|
}
|