adc430e27c
`kubectl wait <kind> <name>` errors immediately with NotFound if the
resource doesn't exist yet — even with --for=condition or --for=jsonpath.
The redis test in CI run 25043350705 failed in 1 second for exactly this
reason: the redis-failover operator hadn't created the PVC by the time
the test waited for it. Previously the 3x retry on `Run E2E tests`
masked this race; with retry dropped, every such call is a flake risk.
Add a small `until kubectl get` existence backstop before each
kubectl wait, matching the pattern already established for HRs in
commit 66888c91.
33 backstops across 12 files:
bucket.bats — bucketclaims, bucketaccesses x2
clickhouse.bats — statefulset 0-0 (0-1 already covered)
harbor.bats — deploy x3, bucketclaims, bucketaccesses
kafka.bats — kafkas
mariadb.bats — statefulset, deployment
mongodb.bats — statefulset
openbao.bats — sts, pvc
postgres.bats — job.batch
qdrant.bats — sts, pvc
redis.bats — pvc, deploy, sts (the trigger)
vminstance.bats — dv, pvc, vm (with 120s for KubeVirt latency)
e2e-install-cozystack.bats — apiservices, sts/etcd, vmalert,
vmalertmanager, vlclusters, vmcluster,
clusters.postgresql.cnpg.io,
deploy/grafana-deployment, namespace
Same pattern, same 60s default timeout for the existence wait (120s for
nested-virt resources). Once the resource exists, the original wait
timeout takes over.
Run-kubernetes.sh has the same race shape on several waits (nfs, kamaji,
machinedeployment, etc.) — out of scope here; flagged for follow-up.
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
81 lines
3.7 KiB
Bash
81 lines
3.7 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
@test "Create Harbor" {
|
|
name='test'
|
|
release="harbor-$name"
|
|
|
|
# Clean up stale resources from previous failed runs
|
|
kubectl -n tenant-test delete harbor.apps.cozystack.io $name 2>/dev/null || true
|
|
kubectl -n tenant-test wait hr $release --timeout=60s --for=delete 2>/dev/null || true
|
|
|
|
kubectl apply -f- <<EOF
|
|
apiVersion: apps.cozystack.io/v1alpha1
|
|
kind: Harbor
|
|
metadata:
|
|
name: $name
|
|
namespace: tenant-test
|
|
spec:
|
|
host: ""
|
|
storageClass: ""
|
|
core:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
registry:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
jobservice:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
trivy:
|
|
enabled: false
|
|
size: 2Gi
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
database:
|
|
size: 2Gi
|
|
replicas: 1
|
|
redis:
|
|
size: 1Gi
|
|
replicas: 1
|
|
EOF
|
|
# Wait for the operator to materialise the HelmRelease before kubectl wait
|
|
# kicks in (kubectl wait errors immediately if the object does not exist yet).
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get hr $release >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait hr $release --timeout=60s --for=condition=ready
|
|
|
|
# Wait for COSI to provision bucket
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get bucketclaims.objectstorage.k8s.io $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait bucketclaims.objectstorage.k8s.io $release-registry \
|
|
--timeout=300s --for=jsonpath='{.status.bucketReady}'=true
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get bucketaccesses.objectstorage.k8s.io $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait bucketaccesses.objectstorage.k8s.io $release-registry \
|
|
--timeout=60s --for=jsonpath='{.status.accessGranted}'=true
|
|
|
|
kubectl -n tenant-test wait hr $release-system --timeout=600s --for=condition=ready || {
|
|
echo "=== HelmRelease status ==="
|
|
kubectl -n tenant-test get hr $release-system -o yaml 2>&1 || true
|
|
echo "=== Pods ==="
|
|
kubectl -n tenant-test get pods 2>&1 || true
|
|
echo "=== Events ==="
|
|
kubectl -n tenant-test get events --sort-by='.lastTimestamp' 2>&1 | tail -30 || true
|
|
echo "=== ExternalArtifact ==="
|
|
kubectl -n cozy-system get externalartifact cozystack-harbor-application-default-harbor-system -o yaml 2>&1 || true
|
|
echo "=== BucketClaim status ==="
|
|
kubectl -n tenant-test get bucketclaims.objectstorage.k8s.io $release-registry -o yaml 2>&1 || true
|
|
echo "=== BucketAccess status ==="
|
|
kubectl -n tenant-test get bucketaccesses.objectstorage.k8s.io $release-registry -o yaml 2>&1 || true
|
|
echo "=== BucketAccess Secret ==="
|
|
kubectl -n tenant-test get secret $release-registry-bucket -o jsonpath='{.data.BucketInfo}' 2>&1 | base64 -d 2>&1 || true
|
|
false
|
|
}
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-core >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-core --timeout=120s --for=condition=available
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-registry --timeout=120s --for=condition=available
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-portal >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-portal --timeout=120s --for=condition=available
|
|
kubectl -n tenant-test get secret $release-credentials -o jsonpath='{.data.admin-password}' | base64 --decode | grep -q '.'
|
|
kubectl -n tenant-test get secret $release-credentials -o jsonpath='{.data.url}' | base64 --decode | grep -q 'https://'
|
|
kubectl -n tenant-test get svc $release -o jsonpath='{.spec.ports[0].port}' | grep -q '80'
|
|
kubectl -n tenant-test delete harbor.apps.cozystack.io $name
|
|
}
|