mirror of
https://github.com/AgentSeal/codeburn.git
synced 2026-08-04 05:41:29 +00:00
Category B (sqlite) variant of the bridge migration: the sqlite driver and every
SQL query stay CLI-side. Each provider's `readRecords` opens the database, runs
the same queries as before, and hands the resulting rows (blob and all) to a
pure core decoder; `toProviderCall` maps the rich, cost-free decode back onto
ParsedProviderCall, where cost re-enters via the parser.ts pricing pass.
Per provider:
- crush: session row + dominant-model query -> one combined record. Crush stores
cost in dollars, so a row with cost > 0 carries `measuredCostUSD` (costBasis
'measured'); a zero-cost row falls back to token estimation, arm order intact.
- zcode: model_usage + tool_usage row sets -> one composite record. Each turn's
tools still attach to the first non-skipped usage row of that turn only.
- zed: threads rows handed over compressed; zstd decompression, JSON parsing and
per-request/cumulative-remainder accounting are pure. The Node >= 22.15 zstd
capability check stays host-side.
- forge: conversation row handed over with `context` still serialized; JSON
parsing and per-message decode are pure. Bash base-name extraction (and its
strip-ansi dependency) stays CLI-side over the decoder's raw command strings.
- goose: session + assistant tool-message + first-user-message rows, BLOB
columns pre-converted to text host-side, bundled into one composite record.
Validator fixes (original behavior is the authority):
- forge: the draft replaced the pre-migration `mapToolName` switch with an
object-literal lookup. Tool names come straight from conversation JSON, so
names colliding with Object.prototype members ("constructor", "toString",
"__proto__", "hasOwnProperty") resolved to inherited Functions / the prototype
object and were pushed into `tools` as non-strings instead of falling through
to the identity default. Restored the switch and pinned the arm in the fixture.
- zed: the draft routed the "skipped N unreadable Zed threads" notice into
record diagnostics, which the bridge discards, silently dropping a warning the
pre-migration decode printed. Re-emitted host-side from the diagnostics count
and pinned with a stderr assertion.
- Fixture coverage extended for the arms that were regression-blind: forge's
prototype-named tool calls, zed's aggregate stderr line, and goose's
single-turn `toolSequence` omission plus the unparseable-timestamp fallback.
Parity was verified independently of the bridge tests with a git-show harness
that runs the same fixtures through the pre-migration provider files and asserts
field-for-field equality, including the extra arms above.
172 lines
6.8 KiB
TypeScript
172 lines
6.8 KiB
TypeScript
import { mkdtemp, rm } from 'fs/promises'
|
|
import { join } from 'path'
|
|
import { tmpdir } from 'os'
|
|
import { createRequire } from 'node:module'
|
|
|
|
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
|
|
|
import { createZcodeProvider } from '../../src/providers/zcode.js'
|
|
import { priceProviderCall } from '../../src/pricing-pass.js'
|
|
import { isSqliteAvailable } from '../../src/sqlite.js'
|
|
import type { ParsedProviderCall } from '../../src/providers/types.js'
|
|
|
|
// Byte-identical parity gate for the zcode bridge migration (phase 8, Category
|
|
// B / sqlite). ZCode is not present in the frozen corpus, so a committed
|
|
// fixture golden is THE parity gate. The GOLDEN below was captured from the
|
|
// legacy provider before the migration.
|
|
|
|
const requireForTest = createRequire(import.meta.url)
|
|
|
|
function createZcodeDb(dir: string): string {
|
|
const dbPath = join(dir, 'db.sqlite')
|
|
const { DatabaseSync: Database } = requireForTest('node:sqlite')
|
|
const db = new Database(dbPath)
|
|
db.exec(`CREATE TABLE session (id TEXT PRIMARY KEY, directory TEXT NOT NULL)`)
|
|
db.exec(`CREATE TABLE model_usage (
|
|
id TEXT PRIMARY KEY, session_id TEXT NOT NULL, turn_id TEXT, model_id TEXT NOT NULL,
|
|
input_tokens INTEGER NOT NULL DEFAULT 0, output_tokens INTEGER NOT NULL DEFAULT 0,
|
|
reasoning_tokens INTEGER NOT NULL DEFAULT 0, cache_creation_input_tokens INTEGER NOT NULL DEFAULT 0,
|
|
cache_read_input_tokens INTEGER NOT NULL DEFAULT 0, started_at INTEGER NOT NULL, completed_at INTEGER)`)
|
|
db.exec(`CREATE TABLE tool_usage (id TEXT PRIMARY KEY, session_id TEXT NOT NULL, turn_id TEXT, tool_name TEXT NOT NULL, started_at INTEGER NOT NULL)`)
|
|
db.close()
|
|
return dbPath
|
|
}
|
|
|
|
function seed(dbPath: string): void {
|
|
const { DatabaseSync: Database } = requireForTest('node:sqlite')
|
|
const db = new Database(dbPath)
|
|
try {
|
|
db.prepare('INSERT INTO session (id, directory) VALUES (?, ?)').run('sess-1', '/Users/me/proj')
|
|
db.prepare(`INSERT INTO model_usage (id, session_id, turn_id, model_id, input_tokens, output_tokens, reasoning_tokens, cache_creation_input_tokens, cache_read_input_tokens, started_at, completed_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`)
|
|
.run('mu-1', 'sess-1', 'turn-1', 'GLM-5.2', 9125, 27, 12, 0, 8064, 1781981181862, 1781981202412)
|
|
db.prepare(`INSERT INTO model_usage (id, session_id, turn_id, model_id, input_tokens, output_tokens, reasoning_tokens, cache_creation_input_tokens, cache_read_input_tokens, started_at, completed_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`)
|
|
.run('mu-2', 'sess-1', 'turn-1', 'GLM-5.2', 200, 40, 0, 0, 0, 1781981210000, 1781981220000)
|
|
// Zero-token row: must be skipped entirely.
|
|
db.prepare(`INSERT INTO model_usage (id, session_id, turn_id, model_id, input_tokens, output_tokens, reasoning_tokens, cache_creation_input_tokens, cache_read_input_tokens, started_at, completed_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`)
|
|
.run('mu-zero', 'sess-1', 'turn-2', 'GLM-5.2', 0, 0, 0, 0, 0, 1781981230000, 1781981231000)
|
|
// No turn_id -> no tools attached.
|
|
db.prepare(`INSERT INTO model_usage (id, session_id, turn_id, model_id, input_tokens, output_tokens, reasoning_tokens, cache_creation_input_tokens, cache_read_input_tokens, started_at, completed_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`)
|
|
.run('mu-3', 'sess-1', null, 'GLM-5.2', 500, 60, 0, 100, 0, 1781981240000, null)
|
|
|
|
db.prepare('INSERT INTO tool_usage (id, session_id, turn_id, tool_name, started_at) VALUES (?, ?, ?, ?, ?)').run('tu-1', 'sess-1', 'turn-1', 'Bash', 1781981185000)
|
|
db.prepare('INSERT INTO tool_usage (id, session_id, turn_id, tool_name, started_at) VALUES (?, ?, ?, ?, ?)').run('tu-2', 'sess-1', 'turn-1', 'Read', 1781981190000)
|
|
} finally {
|
|
db.close()
|
|
}
|
|
}
|
|
|
|
const GOLDEN: ParsedProviderCall[] = [
|
|
{
|
|
provider: 'zcode',
|
|
model: 'GLM-5.2',
|
|
inputTokens: 1061,
|
|
outputTokens: 27,
|
|
cacheCreationInputTokens: 0,
|
|
cacheReadInputTokens: 8064,
|
|
cachedInputTokens: 0,
|
|
reasoningTokens: 12,
|
|
webSearchRequests: 0,
|
|
costBasis: 'estimated',
|
|
tools: ['Bash', 'Read'],
|
|
bashCommands: [],
|
|
timestamp: '2026-06-20T18:46:42.412Z',
|
|
speed: 'standard',
|
|
deduplicationKey: 'zcode:mu-1',
|
|
turnId: 'turn-1',
|
|
userMessage: '',
|
|
sessionId: 'sess-1',
|
|
},
|
|
{
|
|
provider: 'zcode',
|
|
model: 'GLM-5.2',
|
|
inputTokens: 200,
|
|
outputTokens: 40,
|
|
cacheCreationInputTokens: 0,
|
|
cacheReadInputTokens: 0,
|
|
cachedInputTokens: 0,
|
|
reasoningTokens: 0,
|
|
webSearchRequests: 0,
|
|
costBasis: 'estimated',
|
|
tools: [],
|
|
bashCommands: [],
|
|
timestamp: '2026-06-20T18:47:00.000Z',
|
|
speed: 'standard',
|
|
deduplicationKey: 'zcode:mu-2',
|
|
turnId: 'turn-1',
|
|
userMessage: '',
|
|
sessionId: 'sess-1',
|
|
},
|
|
{
|
|
provider: 'zcode',
|
|
model: 'GLM-5.2',
|
|
inputTokens: 400,
|
|
outputTokens: 60,
|
|
cacheCreationInputTokens: 100,
|
|
cacheReadInputTokens: 0,
|
|
cachedInputTokens: 0,
|
|
reasoningTokens: 0,
|
|
webSearchRequests: 0,
|
|
costBasis: 'estimated',
|
|
tools: [],
|
|
bashCommands: [],
|
|
timestamp: '2026-06-20T18:47:20.000Z',
|
|
speed: 'standard',
|
|
deduplicationKey: 'zcode:mu-3',
|
|
userMessage: '',
|
|
sessionId: 'sess-1',
|
|
},
|
|
]
|
|
|
|
let tmpRoot: string
|
|
|
|
beforeEach(async () => {
|
|
tmpRoot = await mkdtemp(join(tmpdir(), 'zcode-bridge-'))
|
|
})
|
|
|
|
afterEach(async () => {
|
|
await rm(tmpRoot, { recursive: true, force: true })
|
|
})
|
|
|
|
async function collect(dbPath: string, seen = new Set<string>()): Promise<ParsedProviderCall[]> {
|
|
const provider = createZcodeProvider(dbPath)
|
|
const sources = await provider.discoverSessions()
|
|
const calls: ParsedProviderCall[] = []
|
|
for (const source of sources) {
|
|
for await (const call of provider.createSessionParser(source, seen).parse()) {
|
|
calls.push(call)
|
|
}
|
|
}
|
|
return calls
|
|
}
|
|
|
|
describe.skipIf(!isSqliteAvailable())('zcode bridge — fixture parity', () => {
|
|
it('the bridged provider reproduces the pre-migration decode byte-for-byte', async () => {
|
|
const dbPath = createZcodeDb(tmpRoot)
|
|
seed(dbPath)
|
|
expect(await collect(dbPath)).toEqual(GOLDEN)
|
|
})
|
|
|
|
it('the priced output survives the pricing pass with only costUSD added', async () => {
|
|
const dbPath = createZcodeDb(tmpRoot)
|
|
seed(dbPath)
|
|
const raw = await collect(dbPath)
|
|
const priced = raw.map(priceProviderCall)
|
|
priced.forEach((call, i) => {
|
|
expect(typeof call.costUSD).toBe('number')
|
|
expect(Number.isFinite(call.costUSD)).toBe(true)
|
|
expect(call.costUSD).toBeGreaterThan(0)
|
|
const { costUSD, ...rest } = call
|
|
expect(rest).toEqual(raw[i])
|
|
})
|
|
})
|
|
|
|
it('discovery, I/O, and dedup stay CLI-side; the shared seenKeys set dedups', async () => {
|
|
const dbPath = createZcodeDb(tmpRoot)
|
|
seed(dbPath)
|
|
const seen = new Set<string>()
|
|
const first = await collect(dbPath, seen)
|
|
const second = await collect(dbPath, seen)
|
|
expect(first.length).toBe(3)
|
|
expect(second).toEqual([])
|
|
})
|
|
})
|