mirror of https://github.com/AgentSeal/codeburn.git synced 2026-08-31 01:56:02 +00:00

History

Resham Joshi 45e93129f2 sessions: attribute PR spend per turn instead of per session (#790 ) * sessions: attribute PR spend per turn instead of per session The by-PR surfaces attributed a session's full cost to every PR it referenced, so one orchestration session that touched many PRs rendered identical full-session rows. Capture per-turn PR references during transcript parsing and attribute each turn's cost to the PR set active at that turn (split evenly across a multi-PR merge-sweep turn), carrying the most recent PR set forward across turns that reference nothing. Turns before the first reference form an unattributed bucket. A session whose transcript expired before per-turn capture keeps its session-level prLinks but has no per-turn refs; it falls back to an even whole-session split, and any row carrying such a portion is flagged approximate. Rows are now summable: the CLI and app footers report the attributed sum plus the unattributed remainder instead of a distinct-session total. Bumps the session cache version so surviving transcripts re-parse and populate the new per-turn field. Daily-cache versioning is untouched. * sessions: harden PR attribution and add models + category breakdown Addresses the review findings on the per-turn PR attribution and adds the model and task-category surfaces. Correctness: - Cache migration: the 5 -> 6 session-cache bump now adopts the prior v5 file's expired-source PR entries instead of abandoning them, and the claude scan preserves and surfaces PR-bearing orphans, so a session whose transcript was deleted still appears as a legacy even-split instead of vanishing. The daily cache is untouched. - Date-range carry: the parser captures the PR set active at the start of the in-range turn slice and seeds the state machine with it, so a PR referenced before the window still owns its later, in-range, ref-less turns instead of the session falling back to a whole-session approx split. - Calls are split across a multi-PR turn by largest-remainder, keeping per-PR counts whole (a 1-call, 2-PR turn no longer renders as 2 calls). - The CLI and app footers reconcile to the rounded row values actually shown. - Distinct sessions are keyed by project + sessionId, not sessionId alone. - The app tolerates an older by-reference payload (no attributedCost): it keeps the old non-summable footer and never renders NaN. Features: - Each PR contribution records the models of its calls and the turn's task category (split by the same share on a multi-PR turn); legacy even-split rows carry the model union but no category breakdown. - Payload rows gain models (short names, cost-desc) and categories (label + cost, cost-desc, omitted when empty); the payload gains otherPrCount/otherPrCost for the PRs beyond the sent top 20. - CLI --by-pr gains a Models column. The desktop table is now full-width with a Models column and click-to-expand rows showing a per-category cost breakdown with proportional bars, keyboard accessible, with an "Other (N more PRs)" row when capped. Tests: state-machine seed/models/categories/largest-remainder/dedup, the prRefs round-trip through the real incremental-append path (continuation + straddle), v5 adoption of an expired PR session, payload round-trip, and the desktop expansion/models/old-payload cases. * sessions: reconcile mixed PR rows, harden v5 adoption, bound models Round-2 review follow-ups. - Mixed legacy/live category breakdown: a PR row that combines an expired legacy contribution (even-split, no turn data) with a live per-turn contribution now emits an explicit "Legacy estimate (no per-turn detail)" category carrying the legacy share, so the expansion reconciles to the row cost instead of silently dropping it. A legacy-only row still shows no breakdown. - v5 adoption is now per cached file: one malformed entry is skipped instead of rejecting the whole v5 cache and dropping every valid expired PR session. - The desktop "Other (N more PRs)" line moved to the table footer as a muted, separated summary rather than a sorted row. - Row expansion resets when the PR set changes (period/provider/data), so a stale expansion cannot linger on a row that is gone. - Payload models per row are capped to the top 4 by attributed cost, with a name-ascending tie-break; categories get the same stable tie-break. Tests: mixed live+legacy reconciliation, legacy-only omission, model cap and tie-break, corrupt-plus-valid v5 adoption, and the desktop expansion-reset. * session-cache: validate optional agentType and failed during v5 adoption; app: reset PR expansion on period switch A v5 entry that was valid except for a malformed optional field (agentType, failed) passed per-file validation and flowed downstream as a non-string. The expansion reset keyed only on the row URL set, so a period switch that returned the same PRs kept a stale expansion open over changed numbers. --------- Co-authored-by: reviewer <review@local>		2026-07-20 20:44:29 -07:00
..
build	brand: restore binary 0101 flame across all surfaces	2026-07-17 14:14:40 -07:00
electron	fix: Lifetime period end to end in the desktop app and menubar labels (#781 )	2026-07-20 12:56:27 -07:00
renderer	sessions: attribute PR spend per turn instead of per session (#790 )	2026-07-20 20:44:29 -07:00
scripts	fix(app): clean build stamp, splash without hash, About checks for updates	2026-07-17 14:30:00 -07:00
.gitignore	feat(app): bundle the CLI inside the packaged app	2026-07-16 09:27:46 -07:00
DISTRIBUTION.md	docs: desktop release flow + widened Linux build targets	2026-07-17 15:00:31 -07:00
package-lock.json	release: 0.9.19 (#774 )	2026-07-20 09:35:32 -07:00
package.json	release: 0.9.19 (#774 )	2026-07-20 09:35:32 -07:00
README.md	feat(app): bundle the CLI inside the packaged app	2026-07-16 09:27:46 -07:00
tsconfig.electron.json	feat(app): scaffold Electron+Vite package and codeburn CLI spawn	2026-07-10 15:16:55 -07:00
tsconfig.json	fix(app): clean build stamp, splash without hash, About checks for updates	2026-07-17 14:30:00 -07:00
vite.config.ts	fix(app): clean build stamp, splash without hash, About checks for updates	2026-07-17 14:30:00 -07:00
vitest.config.ts	fix(app): clean build stamp, splash without hash, About checks for updates	2026-07-17 14:30:00 -07:00

README.md

CodeBurn Desktop

Electron desktop shell for CodeBurn's local-first usage views. M1 runs as a developer app and reads data by spawning the installed codeburn CLI; it does not run a daemon or HTTP server.

Development

npm --prefix app install
npm --prefix app run dev

Validation:

npm --prefix app run test
npm --prefix app run typecheck

CLI Dependency

Packaged builds ship their own version-matched copy of the codeburn CLI and require nothing installed — the app spawns the bundled CLI with Electron's own binary as Node (ELECTRON_RUN_AS_NODE). In development (Vite dev server) the app uses the repo's freshly-built CLI, and either can be overridden with CODEBURN_BIN or a persisted path file. See DISTRIBUTION.md for the bundling and resolution details. Electron resolves and spawns the CLI from the main process, then sends decoded JSON through the secure preload bridge into the renderer.

This follows the menubar pattern:

contextIsolation: true, nodeIntegration: false, and sandbox: true.
Renderer code calls window.codeburn only through app/renderer/lib/ipc.ts.
Main process handlers return JSON envelopes so structured CLI errors survive IPC.
Missing CLI, bad JSON, timeout, and nonzero exits are surfaced as honest UI states.
The renderer never imports CodeBurn engine code from src/; the data contract is spawn CLI, decode JSON, poll.

Data Contract

Current bridge calls:

Overview: codeburn status --format menubar-json --period <period> [--provider <provider>]
Plans: codeburn status --format json --period <period>
Models: codeburn models --format json --period <period> [--provider <provider>] [--by-task]
Optimize: codeburn yield --format json --period <period>
Spend flow: codeburn spend --format flow-json --period <period> [--provider <provider>]
Devices: codeburn devices --format json --period <period>
Device scan: codeburn devices scan --format json
Share status: codeburn share status --format json
Identity: codeburn identity --format json

Supported M1 periods are today, week, 30days, month, and all. Provider filtering is passed through where the CLI command supports it.

Sections

Overview: daily spend, spend stats, waste summary, and expensive sessions from menubar-json.
Spend: project/activity/tool/MCP/subagent lenses plus model-to-project flow.
Optimize: waste findings from menubar-json and reverted/abandoned yield data.
Models: model and task tables from models --format json.
Plans: plan pacing from status --format json.
Settings: device identity, nearby scan results, paired-device usage, and M2 visual affordances.

Packaging

npm run package produces an ad-hoc-signed macOS .dmg/.zip (arm64 and x64) via electron-builder, no paid Apple Developer account required. Packaging rebuilds the root CLI and bundles it into the app (Resources/cli), so installs need nothing on the target machine. See DISTRIBUTION.md for build instructions, the bundled-CLI mechanism, artifact locations, and the Gatekeeper first-open story.

M2 Backlog

Add Electron autoUpdater (the app already bundles its own version-matched CLI, so end-user installs need nothing on the machine; auto-update is the remaining piece).
Keep npm as a separate CLI-user channel at the same version as the desktop app.
Add macOS code signing with a paid Developer ID and notarization (ad-hoc packaging exists today; see DISTRIBUTION.md).
Add a codeburn desktop launcher subcommand.
Implement in-app pairing, approve, pull, and visibility mutations currently shown as M2 affordances.
Build the Models Compare sheet.
Add light theme support.
Expand codeburn optimize --format json with evidence and fix commands so Optimize can show richer actionable fixes.