vrr/codeburn
2
0
Fork 0
mirror of https://github.com/AgentSeal/codeburn.git synced 2026-10-21 05:23:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge pull request #1172 from avs-io/codex/fix-claude-keychain-test-isolation

Browse source 
fix: isolate overridden Claude credential homes
This commit is contained in:
Resham Joshi 2026-08-29 15:24:04 -07:00 • committed by GitHub
commit fcbe978206
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mac/Sources/CodeBurnMenubar/Data/ClaudeCredentialStore.swift
View file

@ -249,6 +249,10 @@ enum ClaudeCredentialStore {
private static func readClaudeSourceSilently() -> CredentialRecord? {
if let fromFile = try? readClaudeFile() { return fromFile }
// An overridden home is an isolation boundary (tests and explicit
// sandboxed probes). Falling through here would read the operator's
// login Keychain when the isolated fixture has no Claude file.
guard homeDirectoryOverride == nil else { return nil }
if let fromKeychain = try? readClaudeKeychain(allowUI: false) { return fromKeychain }
return nil
}
@ -261,6 +265,7 @@ enum ClaudeCredentialStore {
private static func readClaudeSource() throws -> CredentialRecord {
if let silent = readClaudeSourceSilently() { return silent }
guard homeDirectoryOverride == nil else { throw StoreError.bootstrapNoSource }
if let fromKeychain = try readClaudeKeychain(allowUI: true) { return fromKeychain }
throw StoreError.bootstrapNoSource
}