Commit graph

264 commits

Author SHA1 Message Date
Qiaochu Hu
5157b9c445
fix(services): resolve lint issues (#1261)
* fix: resolve lint issues

## Summary

Fix lint issues identified by the linter.

## Changes

- **app.js**: Use `Number.isNaN()` instead of global `isNaN()`
- **app.js**: Prefix unused variable `result` with underscore
- **scheduler.ts**: Remove unused variable `log`

## Details

- `Number.isNaN()` is the preferred way to check for NaN in modern JavaScript
- Unused variables are flagged by the linter and should be removed or prefixed with underscore

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Apply suggestion from @gemini-code-assist[bot]

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: hobostay <hobostay@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Garfield Lee <Garfield550@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-03-11 17:15:56 +08:00
Kunal Bhujbal
57b04d957b
fix(minecraft): add stop method to Ticker to prevent resource leak (#1213) 2026-03-09 20:45:46 +08:00
Rin
7b11d1e0bd
feat(minecraft): disable debug servers by default (#1193) 2026-03-08 18:41:32 +08:00
Rin
561b608c03
fix(minecraft): downgrade to mitigate upstream issue and mcp cleanup (#1192)
* fix(minecraft): downgrade minecraft-data to 3.102.3

Serialization error for play.toServer : Write error for undefined : The value of "value" is out of range. It must be >= -128 and <= 127. Received 218 stack=RangeError [ERR_OUT_OF_RANGE]: Write error for undefined : The value of "value" is out of range. It must be >= -128 and <= 127. Received 218

* fix(minecraft): close existing MCP transports on client reconnect

Handle client refresh scenarios by closing existing streamable and SSE transports before creating new ones, preventing resource leaks and connection conflicts.
2026-03-08 05:54:49 +08:00
sed-i
19822e3c43
refactor(minecraft): migrate reflex runtime to alien-signals, harden zod validation, and unify skill utilities (#1092)
* chore: use utils

* feat: refactor pathfinding stagnation detection and add navigation tests

* refactor(minecraft): simplify ensure.ts with shared ensureMined helper

* refactor(minecraft): centralize collectible block aliases and extraction flow

- move block collection usage onto the dedicated action module
- extract collectible alias expansion for ores, deepslate variants, and dirt
- keep exact block validation strict while widening collection lookups
- preserve original smelting errors when temporary furnace cleanup fails
- add regression coverage for alias handling and furnace cleanup

* chore: sleep() using shared utils

* refactor(minecraft): container helpers; guarantee close in takeFromChest()

* chore: add unsafe type comment

refactor: zod schema for YAML rule DSL

refactor: zod for hardened config validation

refactor: zod schema for ws client command validation

* refactor(minecraft): alien-signals for reflex context/runtime/manager state

* fix(minecraft): prevent reconnect deadlock before spawn; centralize plugin lifecycle

* fix(minecraft): make command chat listener idempotent across spawn/reconnect

* refactor(minecraft): extract reconnect state machine into connection supervisor; further centralize plugin-related logic

* fix(minecraft): temp type fix

* fix(minecraft): add LLM call timeout/cancel boundaries and ignore pause abort errors

* fix(minecraft): enforce deterministic temporal rule semantics and honor accumulator.mode

* fix(minecraft): preserve callback errors during container cleanup

* fix(minecraft): report EventBus subscriber failures via project logger

* refactor(minecraft): migrate perception temporal accumulator to detector with decision tracing

* feat(minecraft): add detector.groupBy and optimize rule engine detector hot path

* fix(minecraft): bound event queue and temp anti-starvation scheduling

* fix(minecraft): normalize debug dashboard tool param typing

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Rin <shinohara-rin@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-03-07 03:01:49 +08:00
Neko Ayaka
3605548973
chore: lint & lock 2026-03-06 16:49:31 +08:00
Rin
a5287c08d2
refactor(minecraft): add ETA-based pathfinding timeout with stuck detection and retry limits
Patches mineflayer-pathfinder to implement estimated-time-of-arrival based navigation timeouts (2× estimated travel time + grace period). Adds stuck detection counter that triggers failure after 3 consecutive resets without progress. Introduces patchedGoto wrapper returning {ok, reason, elapsedMs, estimatedTimeMs, message} for all navigation calls. Updates goToPlayer/goToPosition actions to surface timeout
2026-02-19 00:25:06 +08:00
Rin
91e5158cf3
refactor(minecraft): redesign debug dashboard conversation view with turn-based grouping and context boundary visualization
Replaces flat message list with collapsible turn cards (user+assistant pairs). Parses user messages into tagged sections ([EVENT], [FEEDBACK], [PERCEPTION], etc.) with inline/collapsible rendering based on content type. Adds context status bar showing active context label and archived summaries. Introduces Brain.broadcastConversationState() to emit full context metadata (active
2026-02-19 00:25:06 +08:00
Rin
08afe0f2aa
feat(minecraft): add context boundary system with auto-summarization to prevent unbounded conversation history growth
Introduces task context boundaries via enterContext()/exitContext() REPL functions. Active context messages remain in full; completed contexts are summarized and archived. Adds [CONTEXT_HISTORY] prefix message with archived summaries, auto-trim when active context exceeds 30 messages, and auto-collapse when >10 summaries accumulate. Provides history query runtime (recent/search/playerChats/
2026-02-19 00:25:06 +08:00
Rin
4ce0c427bc
refactor(minecraft): simplify giveUp action to halt until player input instead of timed cooldown
Removes cooldown_seconds parameter and timer-based resumption from giveUp action. Brain now uses boolean givenUp flag instead of giveUpUntil timestamp. Action halts all autonomous processing until next player chat message. Updates error-burst guard to remove suggestedCooldownSeconds field. Adjusts prompts, tests, and MCP server to reflect halt-until-input semantics.
2026-02-19 00:25:06 +08:00
Rin
f3486005ea
refactor(minecraft): simplify EventBus by removing history and trace query features
Strips ring buffer history storage, getHistory(), getEventsByTrace(), and historySize config from EventBus. Removes logger dependency and default config object. EventBus now only handles emit/subscribe/dispatch without persistent event storage. Updates container to use zero-config createEventBus(). Moves event-bus from cognitive/os/ to cognitive/ directory.

Update services/minecraft/codex-skills/minecraft-debug-mcp/references/mcp-surface.md

Update services/minecraft/codex-skills/minecraft-debug-mcp/references/mcp-surface.md

Update services/minecraft/codex-skills/minecraft-debug-mcp/SKILL.md
2026-02-18 11:14:46 +08:00
Rin
aa2d7af17c
refactor(minecraft): further cleanup 2026-02-18 11:14:45 +08:00
Rin
ae297e8b06
refactor(minecraft): dead code cleanup
Strips saliency thresholds, window counters, signal generation, and route filtering from all perception event definitions and EventRegistry. Events now emit raw data directly via onRawEvent callback without conscious/reflex/debug routing or threshold-based filtering. Removes WindowCounter, SaliencySnapshot, and related timer/slot logic.
2026-02-18 11:14:45 +08:00
Rin
46b1a8d438
refactor(minecraft): replace look-at and teabag behaviors with idle-gaze behavior 2026-02-18 11:14:45 +08:00
Rin
2022c733b3
feat(minecraft): add map() query DSL for ASCII spatial awareness and terrain visualization
Adds `query.map(options?)` to Brain's query runtime, returning ASCII top-down or cross-section maps with configurable radius (1-32), entity/elevation overlays, and yLevel slicing. Symbols include ground, stone, water, lava, trees, ores, chests, players, and mobs. Enables spatial navigation, resource finding, and underground exploration.
2026-02-18 11:14:45 +08:00
Rin
a135b07957
fix(minecraft): await reconnect plugin initialization before spawn hooks to prevent race conditions
Plugin loadPlugin calls were fire-and-forget during reconnect, allowing spawn
event handlers to run before plugins finished loading. Now initializeReconnectPlugins
runs sequentially and spawn waits for completion before invoking spawned hooks.
2026-02-18 11:14:45 +08:00
Rin
e668b9b410
fix(minecraft): nullify EventRegistry context on stop() to prevent stale handler execution
When stop() is called before detachFromBot(), mineflayer listeners remain
attached. Nullifying context ensures handleMineflayerEvent's guard clause
silently ignores any events that fire in this window.
2026-02-18 11:14:44 +08:00
Rin
32957e4269
fix(minecraft): make action tool globals updatable so REPL reflects runtime action changes
Action tools were defined with configurable: false, preventing updates after
the first evaluate() call. New defineUpdatableGlobal uses configurable: true
so installActionTools can redefine them when available actions change.
2026-02-18 11:14:44 +08:00
Rin
a140ce5065
fix(minecraft): stop McpReplServer and destroy Brain on cleanup to prevent port conflicts on reconnect 2026-02-18 11:14:44 +08:00
Rin
303c07747d
fix(minecraft): fix Brain resource leaks, race conditions, and unbounded growth
- Store and clean up EventBus subscription and TaskExecutor listeners in destroy()
- Clear stopCancelledControlActionIds Set in destroy() to prevent unbounded growth
- Use setImmediate in enqueueEvent to prevent re-entrant processQueue bypassing isProcessing guard
- Add conversation history trimming (max 40 messages) to prevent exceeding LLM context window
- Remove duplicate pause check block before REPL execution
2026-02-18 11:14:44 +08:00
Rin
2202154b1d
fix(minecraft): remove hardcoded return in isCerebrasBaseURL that prevented reasoning from being sent to all LLM providers 2026-02-18 11:14:44 +08:00
Rin
fdb0d26b4d
feat(minecraft): add patterns runtime to REPL with block alias support for collect actions
Add PatternRuntime to brain sandbox exposing patterns.get/find/ids/list helpers for known-working recipes, update mcp-surface.md to document patterns global, add patterns to brain-prompt.md globals list with usage guidance, expose patterns in js-planner sandbox and introspection, add test coverage for patterns.get/find in REPL, integrate matchesBlockAlias in breakBlockAt action to support variant-aware block verification

[autofix.ci] apply automated fixes

chore(minecraft): cleanup

[autofix.ci] apply automated fixes
2026-02-18 11:14:44 +08:00
Rin
6a50bcf98e
feat(minecraft): remove greeting reflex behavior and associated state tracking
Remove greetingBehavior from reflex system, delete lastGreetingAtBySpeaker tracking from ReflexSocialState and context snapshot, unregister greeting behavior from ReflexManager, clean up stale comments about greeting behavior compatibility
2026-02-18 11:14:43 +08:00
Rin
b170094a99
fix(minecraft): add toJSON/inspect.custom serialization to query chains for cleaner REPL output 2026-02-18 11:14:43 +08:00
Rin
797a00346b
chore(minecraft): document query.gaze + remove stale gaze context 2026-02-18 11:14:43 +08:00
Rin
942d03584a
feat(minecraft): move gaze to perception + query.gaze 2026-02-18 11:14:43 +08:00
Rin
5ea05fb33e
fix(minecraft): remove returnValue from prevRun/lastRun to prevent stringified return mirror exposure
Remove returnValue assignment from sandbox.lastRun after script execution (keep only returnRaw for typed values), add test verifying prevRun does not expose stringified returnValue property, update brain-prompt.md to remove returnValue references and guide users to stringify returnRaw explicitly for text output (JSON.stringify(prevRun.returnRaw)), update value-first rule examples to use prevRun.returnRaw instea
2026-02-18 11:14:43 +08:00
Rin
4a354c357e
feat(minecraft): add live conversation panel with session tracking and processing state
Replace LLM traces panel with live conversation view showing real-time chat messages, add ConversationUpdateEvent/RequestConversationCommand types, implement emitConversationUpdate in Brain to broadcast conversation state changes (on forgetConversation/turn completion/errors), add session boundary tracking to grey out cleared conversations, implement typing indicator during LLM processing, add collapsible system
2026-02-18 11:14:42 +08:00
Rin
165fde7745
fix(minecraft): remove autoCraft action and fix craftRecipe num parameter to mean craft count not output count
Remove autoCraft action (redundant with craftRecipe's auto-handling of intermediate materials), update craftRecipe description to clarify num parameter is craft count not output item count (e.g. crafting planks once yields 4 planks), fix ensurePlanks to pass logsToCraft instead of logsToCraft*PLANKS_PER_LOG to craftRecipe, fix craftRecipe to use replaceAll instead of replace for space norm
2026-02-18 11:14:42 +08:00
Rin
9a35b853a9
feat(minecraft): add error-burst guard to prevent LLM error loops with mandatory giveUp+chat recovery
Add ErrorBurstGuardState interface tracking threshold/windowTurns/errorTurnCount/recentTurnIds/recentErrorSummary/suggestedCooldownSeconds/triggeredAtTurnId, implement error-burst detection with ERROR_BURST_THRESHOLD=3/WINDOW_TURNS=5/COOLDOWN_SECONDS=45 constants, add isErrorLlmLogEntry/describeErrorLlmLogEntry/collectRecentErrorTurns helpers to identify repl_error/repl_result with errorCount/feedback
2026-02-18 11:14:42 +08:00
Rin
604167c93e
fix(minecraft): announce giveUp cooldown to chat with reason when bot gives up
Add try-catch wrapped bot.chat call in executeGiveUpAction to broadcast "[debug] Giving up for {cooldownSeconds}s: {reason}" message, log warning on chat failure
2026-02-18 11:14:42 +08:00
Rin
7d4a0f1224
fix(minecraft): add pause checks during LLM retry loop to prevent execution while paused
Add pause checks at start of each retry attempt, after backoff sleep, and before REPL execution to allow !pause command to interrupt brain processing mid-turn, log interruption events with scheduler tags tracking attempt number and event context
2026-02-18 11:14:42 +08:00
Rin
0f536b9e4b
feat(minecraft): add budgeted no-action follow-up system with stagnation detection and player chat reset
Add NoActionBudgetState interface tracking remaining/default/max budget, implement budget system with DEFAULT=3/MAX=8 limits and STAGNATION_REPEAT_LIMIT=2, add setNoActionFollowupBudget/getNoActionBudgetState/resetNoActionFollowupBudget methods, track stagnation via buildNoActionSignature comparing returnValue+logs across turns, block follow-ups when budget exhausted or stagnated and emit brain
2026-02-18 11:14:42 +08:00
Rin
e700a177ef
fix(minecraft): stop action cancels active control action without emitting failure feedback
Add test confirming executeStopAction cancels active control action (goToPlayer), marks it as cancelled in queue snapshot, calls bot.interrupt, and does not enqueue failure feedback event for the cancelled action
2026-02-18 11:14:42 +08:00
Rin
cbcd23597f
fix(minecraft): semicolon now works in single line
Extract normalizeReplCode/rewriteTrailingExpressionToReturn from Brain to new repl-code-normalizer module, add test verifying single-line statements with trailing expressions return values (const nearestLog = [...]; nearestLog)
2026-02-18 11:14:42 +08:00
Rin
3f059527c3
feat(minecraft): add control action queue to brain for async action management with capacity limits
Add ControlActionQueueEntry/ActionQueueSnapshot types tracking action state (pending/executing/succeeded/failed/cancelled), implement control action queue with MAX_QUEUED_CONTROL_ACTIONS=5 and MAX_PENDING_CONTROL_ACTIONS=4 capacity limits, add enqueueControlAction to queue async control actions (skip chat/skip/stop/readonly tools) instead of blocking turn completion, implement runControlActionWorker processing
2026-02-18 11:14:41 +08:00
Rin
8010c49d94
feat(minecraft): add includeBuiltins option to get_state tool to filter REPL builtins by default
Add includeBuiltins parameter to Brain.getReplState/JavaScriptPlanner.describeGlobals to optionally skip REPL builtins (skip/use/log/forget_conversation), default to excluding builtins in get_state MCP tool to reduce noise (pass includeBuiltins:true to include them), update SKILL.md documenting builtin filtering behavior, add tests verifying get_state calls getReplState with includeBuiltins flag, ad
2026-02-18 11:14:41 +08:00
Rin
42e5e33745
fix(minecraft): persist prevRun returnRaw for typed value reuse 2026-02-18 11:14:41 +08:00
Rin
1f7e9468c4
chore(minecraft): rename planner to repl naming 2026-02-18 11:14:41 +08:00
Rin
ca6f157192
feat(minecraft): prioritize player chat over stale feedback/follow-ups in brain event queue
Add event priority system (player_chat=0, perception=1, feedback=2, no_action_followup=3) with getEventPriority helper, implement coalesceQueue() to stable-sort queue by priority and drop redundant no-action follow-ups when player chat is waiting, call coalesceQueue before each queue shift to ensure player messages are processed first, add tests verifying chat promotion/followup dropping/order preservation
2026-02-18 11:14:41 +08:00
Rin
81381353c8
feat(minecraft): improve error retry logic with exponential backoff and quota detection
Add shouldRetryError helper consolidating retry decision logic, expand rate limit detection to catch token_quota_exceeded errors and quota-related messages (token quota/tokens per minute/too many tokens), implement exponential backoff for rate limits (1s→5s with jitter) vs fixed 150ms for other retries, skip turn gracefully on retry exhaustion instead of throwing non-auth errors, log lastError context when
2026-02-18 11:14:41 +08:00
Rin
cbf85af68b
fix(minecraft): skip reasoning parameter for Cerebras API to avoid unsupported field errors
Add isCerebrasBaseURL helper detecting cerebras.ai/cerebras.com domains, conditionally omit reasoning parameter when using Cerebras baseURL since their API doesn't support reasoning field, preserve reasoning defaults (effort: low) for non-Cerebras providers
2026-02-18 11:14:41 +08:00
Rin
5a72898fd0
chore(minecraft): add callable-only reminder and evaluation-loop escape rules to brain prompt
Add callable-only reminder section enforcing function call syntax (query.inventory().summary() not .summary), add invSummary composable pattern example, extend value-first rule with evaluation-loop escape requirement (after one eval turn must call action/chat tool or giveUp), add tests verifying callable reminder/summary example/loop-escape rules appear in prompt
2026-02-18 11:14:41 +08:00
Rin
ca109ba9b8
feat(minecraft): compact brain prompt tool descriptions to reduce token usage
Replace verbose JSDoc-style tool formatting with pipe-delimited compact format (name|description|sig:positional|obj:object|args:params), abbreviate common words in descriptions (Automatically→Auto, approximately→approx, coordinate→coord, inventory→inv, nearest→near, number of→#, player→plyr, resource→res, position→pos, whether→if), flatten parameter descriptions from multi-line @param blocks to semic
2026-02-18 11:14:40 +08:00
Rin
b124de0f47
feat(minecraft): add pause/resume control for cognitive engine via !pause command and Brain.setPaused/togglePaused/isPaused methods
Add paused state to Brain with setPaused/togglePaused/isPaused methods, suppress all event processing while paused (log suppression to llmLogEntries with scheduler/paused/suppressed tags), add !pause chat command in CognitiveEngine to toggle pause state with confirmation message, expose paused flag in getReplState/getSnapshot for debug visibility, add test verifying ll
2026-02-18 11:14:40 +08:00
Rin
48ad59b1cc
docs(minecraft): document query.self/snapshot helpers and remove degraded environment sentinel references
Update SKILL.md and mcp-surface.md to recommend compact value reads (query.self/snapshot/inventory helpers), document query runtime shortcuts (self/count/has/summary/snapshot) in mcp-surface.md, add query.self/snapshot usage examples to brain-prompt.md composable patterns, remove degraded environment sentinel warnings now that inject_chat refreshes reflex context first
2026-02-18 11:14:40 +08:00
Rin
5642b1e204
feat(minecraft): add query.self/snapshot helpers and inventory count/has/summary methods
Add query.self() returning one-shot self state (pos/health/food/heldItem/gameMode/isRaining/timeOfDay), add query.snapshot(range) returning combined self/inventory/nearby snapshot with counts/summary/emptySlots/totalStacks and blocks/entities/ores within range, add inventory.count(name)/has(name, atLeast)/summary() helpers for item queries, register query.self/snapshot as readonly functions in JavaScriptPlanner sandbox
2026-02-18 11:14:40 +08:00
Rin
a9f95aeb53
fix(minecraft): mcp-initiated chat no longer cause "SOMETHING WENT WRONG" 2026-02-18 11:14:40 +08:00
Rin
447f779393
fix(minecraft): re-equip tool after ensurePickaxe and throw typed error for missing harvest tools
Re-equip block-appropriate tool after ensurePickaxe crafting/ensuring workflow to capture newly crafted pickaxe, add second canHarvest check post-equip to verify harvestability with new tool, replace generic Error with ActionError(RESOURCE_MISSING) for missing tool failures to enable proper error handling
2026-02-18 11:14:40 +08:00
Rin
843b149e3d
fix(minecraft): render nested return objects without [Object] truncation in planner output
Set inspect depth to null (unlimited) in JavaScriptPlanner.evaluate to fully expand nested objects instead of truncating with [Object] placeholder, add maxArrayLength/maxStringLength limits (100/10000) to prevent unbounded output, add test verifying nested pos objects render as `{ x: 10, y: 64, z: -2 }` instead of `[Object]`
2026-02-18 11:14:40 +08:00