Merge 20b4bce3a8 into 6664fc7f38

conf/model_providers.yaml

@@ -83,6 +83,20 @@ chat:
     models_list:
       endpoint_url: "/v1/models"
       default_base: "http://host.docker.internal:1234"
+  minimax:
+    name: MiniMax
+    litellm_provider: openai
+    kwargs:
+      api_base: https://api.minimax.io/v1
+    models_list:
+      endpoint_url: "https://api.minimax.io/v1/models"
+  minimax-cn:
+    name: MiniMax China
+    litellm_provider: openai
+    kwargs:
+      api_base: https://api.minimaxi.com/v1
+    models_list:
+      endpoint_url: "https://api.minimaxi.com/v1/models"
   mistral:
     name: Mistral AI
     litellm_provider: mistral

models.py

@@ -775,6 +775,21 @@ def _adjust_call_args(provider_name: str, model_name: str, kwargs: dict):
     if provider_name == "other":
         provider_name = "openai"
 
+    # MiniMax requires temperature in (0.0, 1.0]; clamp if a caller passes
+    # the LiteLLM/OpenAI-default of 0.7 it works fine, but Agent Zero's
+    # task templates sometimes pass 0 (deterministic) or values above 1
+    # which the MiniMax API rejects with a 400. Detect via provider name
+    # OR api_base to also catch the user-supplied "openai" provider that
+    # was repointed at MiniMax's endpoint via api_base override.
+    if provider_name in ("minimax", "minimax-cn") or "minimax" in (kwargs.get("api_base") or "") or "minimax" in model_name.lower():
+        temp = kwargs.get("temperature")
+        if temp is not None:
+            temp = float(temp)
+            if temp <= 0.0:
+                kwargs["temperature"] = 0.01
+            elif temp > 1.0:
+                kwargs["temperature"] = 1.0
+
     return provider_name, model_name, kwargs
 
 

tests/test_minimax_provider.py

@@ -0,0 +1,79 @@
+"""Tests for MiniMax provider entries and the temperature clamp.
+
+MiniMax's OpenAI-compatible endpoint rejects ``temperature <= 0`` or
+``> 1`` with HTTP 400, so ``_adjust_call_args`` clamps the value when
+talking to the ``minimax`` / ``minimax-cn`` providers (or any custom
+"openai" provider repointed at ``api.minimax.io`` / ``api.minimaxi.com``
+via ``api_base``).
+"""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+import pytest
+import yaml
+
+PROJECT_ROOT = Path(__file__).resolve().parents[1]
+if str(PROJECT_ROOT) not in sys.path:
+    sys.path.insert(0, str(PROJECT_ROOT))
+
+
+def _load_chat_providers() -> dict:
+    yaml_path = PROJECT_ROOT / "conf" / "model_providers.yaml"
+    return yaml.safe_load(yaml_path.read_text())["chat"]
+
+
+def test_minimax_global_provider_registered():
+    providers = _load_chat_providers()
+    assert "minimax" in providers
+    entry = providers["minimax"]
+    assert entry["litellm_provider"] == "openai"
+    assert entry["kwargs"]["api_base"] == "https://api.minimax.io/v1"
+
+
+def test_minimax_cn_provider_registered():
+    providers = _load_chat_providers()
+    assert "minimax-cn" in providers
+    entry = providers["minimax-cn"]
+    assert entry["litellm_provider"] == "openai"
+    assert entry["kwargs"]["api_base"] == "https://api.minimaxi.com/v1"
+
+
+@pytest.mark.parametrize(
+    ("provider_name", "model_name", "api_base", "input_temp", "expected_temp"),
+    [
+        # provider name match
+        ("minimax", "MiniMax-M2.7", None, 0.0, 0.01),
+        ("minimax", "MiniMax-M2.7", None, 1.5, 1.0),
+        ("minimax-cn", "MiniMax-M2.7", None, -0.5, 0.01),
+        # api_base match (custom "openai" provider repointed at MiniMax)
+        ("openai", "gpt-4", "https://api.minimax.io/v1", 0.0, 0.01),
+        # model_name match (caller forgot to set provider correctly)
+        ("openai", "MiniMax-M2.7-highspeed", None, 2.0, 1.0),
+        # in-range values pass through unchanged
+        ("minimax", "MiniMax-M2.7", None, 0.7, 0.7),
+        ("minimax", "MiniMax-M2.7", None, 1.0, 1.0),
+    ],
+)
+def test_minimax_temperature_clamp(provider_name, model_name, api_base, input_temp, expected_temp):
+    from models import _adjust_call_args
+
+    kwargs = {"temperature": input_temp}
+    if api_base is not None:
+        kwargs["api_base"] = api_base
+
+    _, _, adjusted = _adjust_call_args(provider_name, model_name, kwargs)
+    assert adjusted["temperature"] == pytest.approx(expected_temp)
+
+
+def test_non_minimax_provider_temperature_untouched():
+    """Make sure the clamp doesn't fire for other providers."""
+    from models import _adjust_call_args
+
+    _, _, adjusted = _adjust_call_args("openai", "gpt-4", {"temperature": 0.0})
+    assert adjusted["temperature"] == 0.0  # not clamped
+
+    _, _, adjusted = _adjust_call_args("anthropic", "claude-3-opus", {"temperature": 1.5})
+    assert adjusted["temperature"] == 1.5  # not clamped