From 3bdbdaa80c97c8ab225e245902c9fa672b8eaec2 Mon Sep 17 00:00:00 2001
From: Testing <testing@emichi.co>
Date: Thu, 14 May 2026 00:16:01 +0000
Subject: [PATCH] fix: push agent state to all WS connections and sync sidebar
 in background tabs

- agent.py: add finally block to _process_chain that calls mark_dirty_all()
  so non-active tabs see running:false without manual refresh
- message-queue-store.js: deduplicate allItems by id to prevent Alpine
  'Duplicate key' errors during server-poll vs pending-item race
- chats-list.html: add data-chat-id attribute for DOM-based targeting
- index.js: move chatsStore/tasksStore updates before context-equality
  check so background state changes always reach the sidebar
---
 agent.py                                          |  5 +++++
 .../chat/message-queue/message-queue-store.js     |  9 ++++++++-
 webui/components/sidebar/chats/chats-list.html    |  2 +-
 webui/index.js                                    | 15 +++++++--------
 4 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/agent.py b/agent.py
index 267a90807..e875c1269 100644
--- a/agent.py
+++ b/agent.py
@@ -300,6 +300,11 @@ class AgentContext:
             return response
         except Exception as e:
             await self.handle_exception("process_chain", e)
+        finally:
+            # Push updated running state to ALL connections when agent finishes.
+            # Without this, non-active tabs don't see running:false until they click.
+            from helpers.state_monitor_integration import mark_dirty_all
+            mark_dirty_all(reason="agent.AgentContext._process_chain completed")
 
     @extension.extensible
     async def handle_exception(self, location: str, exception: Exception):
diff --git a/webui/components/chat/message-queue/message-queue-store.js b/webui/components/chat/message-queue/message-queue-store.js
index 9c83a50ba..ac556278b 100644
--- a/webui/components/chat/message-queue/message-queue-store.js
+++ b/webui/components/chat/message-queue/message-queue-store.js
@@ -47,8 +47,15 @@ const model = {
   },
 
   // Combined items for display: confirmed first, then pending at the end
+  // Deduplicate by id to prevent Alpine "Duplicate key" errors during
+  // the race between server poll updates and pending item cleanup.
   get allItems() {
-    return [...this.items, ...this.pendingItems];
+    const seen = new Set();
+    return [...this.items, ...this.pendingItems].filter((item) => {
+      if (seen.has(item.id)) return false;
+      seen.add(item.id);
+      return true;
+    });
   },
 
   async addToQueue(text, attachments = []) {
diff --git a/webui/components/sidebar/chats/chats-list.html b/webui/components/sidebar/chats/chats-list.html
index 2c13755fc..e11317c84 100644
--- a/webui/components/sidebar/chats/chats-list.html
+++ b/webui/components/sidebar/chats/chats-list.html
@@ -24,7 +24,7 @@
 
         <ul class="config-list chats-config-list no-scrollbar" x-show="$store.chats.contexts.length > 0">
           <template x-for="context in $store.chats.contexts" :key="context.id">
-            <li>
+            <li :data-chat-id="context.id">
               <div :class="{'chat-container': true, 'chat-selected': context.id === $store.chats.selected}"
                 @click="$store.chats.selectChat(context.id)">
                 <div class="chat-list-button">
diff --git a/webui/index.js b/webui/index.js
index 91bc78f99..9639a8f9f 100644
--- a/webui/index.js
+++ b/webui/index.js
@@ -314,6 +314,13 @@ export async function applySnapshot(snapshot, options = {}) {
     return { updated: false };
   }
 
+  // Update chats/tasks list BEFORE context check so background chat
+  // state changes (running, etc.) are always reflected in the sidebar.
+  let contexts = snapshot.contexts || [];
+  chatsStore.applyContexts(contexts);
+  let tasks = snapshot.tasks || [];
+  tasksStore.applyTasks(tasks);
+
   if (
     snapshot.context != context &&
     context !== null
@@ -370,14 +377,6 @@ export async function applySnapshot(snapshot, options = {}) {
     setConnectionStatus(true);
   }
 
-  // Update chats list using store
-  let contexts = snapshot.contexts || [];
-  chatsStore.applyContexts(contexts);
-
-  // Update tasks list using store
-  let tasks = snapshot.tasks || [];
-  tasksStore.applyTasks(tasks);
-
   // Make sure the active context is properly selected in both lists
   if (context) {
     // Update selection in both stores