vrr/agent-zero
2
0
Fork 0
mirror of https://github.com/agent0ai/agent-zero.git synced 2026-04-28 03:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(api): image_get 500 error for non-ASCII filename uploads

Browse source 
- Fixes 500 error when uploading images with non-ASCII filenames via /api/image_get
- Improves file path handling to support both development and Docker environments
- Adds exception handling to gracefully fall back to Docker path logic if path correction fails
- Ensures robust error handling so path issues do not crash the entire endpoint
This commit is contained in:
keyboardstaff 2026-03-26 01:19:17 -07:00
parent dae37ee0f6
commit 1160195fb5
1 changed files with 27 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

46
api/image_get.py
View file

@ -1,5 +1,6 @@
import base64
import os
from urllib.parse import quote
from helpers.api import ApiHandler, Request, Response, send_file
from helpers import files, runtime
import io
@ -47,24 +48,31 @@ class ImageGet(ApiHandler):
# in development environment, try to serve the image from local file system if exists, otherwise from docker
if runtime.is_development():
if files.exists(path):
response = send_file(path)
elif await runtime.call_development_function(files.exists, path):
b64_content = await runtime.call_development_function(
files.read_file_base64, path
)
file_content = base64.b64decode(b64_content)
mime_type, _ = guess_type(filename)
if not mime_type:
mime_type = "application/octet-stream"
response = send_file(
io.BytesIO(file_content),
mimetype=mime_type,
as_attachment=False,
download_name=filename,
)
# Convert /a0/... Docker paths to local absolute paths
local_path = files.fix_dev_path(path)
if files.exists(local_path):
response = send_file(local_path)
else:
response = _send_fallback_icon("image")
# Try fetching from Docker via RFC as fallback
try:
if await runtime.call_development_function(files.exists, path):
b64_content = await runtime.call_development_function(
files.read_file_base64, path
)
file_content = base64.b64decode(b64_content)
mime_type, _ = guess_type(filename)
if not mime_type:
mime_type = "application/octet-stream"
response = send_file(
io.BytesIO(file_content),
mimetype=mime_type,
as_attachment=False,
download_name=filename,
)
else:
response = _send_fallback_icon("image")
except Exception:
response = _send_fallback_icon("image")
else:
if files.exists(path):
response = send_file(path)
@ -74,7 +82,7 @@ class ImageGet(ApiHandler):
# Add cache headers for better device sync performance
response.headers["Cache-Control"] = "public, max-age=3600"
response.headers["X-File-Type"] = "image"
response.headers["X-File-Name"] = filename
response.headers["X-File-Name"] = quote(filename)
return response
else:
# Handle non-image files with fallback icons
@ -135,7 +143,7 @@ def _send_file_type_icon(file_ext, filename=None):
response.headers["X-File-Type"] = "icon"
response.headers["X-Icon-Type"] = icon_name
if filename:
response.headers["X-File-Name"] = filename
response.headers["X-File-Name"] = quote(filename)
return response