Ruview/firmware/esp32-csi-node/tests/host/test_adaptive_controller.c
rUv 5a7f431b0e
ADR-081: Implement 5-layer adaptive CSI mesh firmware kernel (#404)
* ADR-081: adaptive CSI mesh firmware kernel + scaffolding

Introduces a 5-layer firmware kernel that reframes the existing ESP32
modules as components of a chipset-agnostic architecture and authorizes
adaptive control + a compact feature-state stream as the default upstream.

Layers:
  L1 Radio Abstraction Layer  — rv_radio_ops_t vtable + ESP32 binding
  L2 Adaptive Controller      — fast/medium/slow loops (200ms/1s/30s)
  L3 Mesh Sensing Plane       — anchor/observer/relay/coordinator (spec)
  L4 On-device Feature Extr.  — rv_feature_state_t (magic 0xC5110006)
  L5 Rust handoff             — feature_state default; debug raw gated

Files:
  docs/adr/ADR-081-adaptive-csi-mesh-firmware-kernel.md  (new)
  firmware/esp32-csi-node/main/rv_radio_ops.h            (new)
  firmware/esp32-csi-node/main/rv_radio_ops_esp32.c      (new)
  firmware/esp32-csi-node/main/rv_feature_state.{h,c}    (new)
  firmware/esp32-csi-node/main/adaptive_controller.{h,c} (new)
  firmware/esp32-csi-node/main/main.c                    (wire L1+L2)
  firmware/esp32-csi-node/main/CMakeLists.txt            (add 4 sources)
  firmware/esp32-csi-node/main/Kconfig.projbuild         (controller knobs)
  CHANGELOG.md                                           (Unreleased)

Default policy is conservative: enable_channel_switch and
enable_role_change are off, so behavior matches today's firmware
unless an operator opts in via menuconfig. The pure
adaptive_controller_decide() is exposed for offline unit tests.

Reuses (does not rewrite): csi_collector, edge_processing (ADR-039),
swarm_bridge (ADR-066), secure_tdm (ADR-032), wasm_runtime (ADR-040).

* ADR-081: implement Layers 1/2/4 end-to-end + host tests + QEMU hooks

Turns the ADR-081 scaffolding into a working adaptive CSI mesh kernel:
Layer 1 radio abstraction has an ESP32 binding and a mock binding; Layer 2
adaptive controller runs on FreeRTOS timers; Layer 4 feature-state packet
is emitted at 5 Hz by default, replacing raw ADR-018 CSI as the default
upstream.

New files:
  firmware/esp32-csi-node/main/adaptive_controller_decide.c  (pure policy)
  firmware/esp32-csi-node/main/rv_radio_ops_mock.c           (QEMU binding)
  firmware/esp32-csi-node/tests/host/Makefile                (host tests)
  firmware/esp32-csi-node/tests/host/test_adaptive_controller.c
  firmware/esp32-csi-node/tests/host/test_rv_feature_state.c
  firmware/esp32-csi-node/tests/host/esp_err.h               (shim)
  firmware/esp32-csi-node/tests/host/.gitignore

Modified:
  adaptive_controller.c         — includes pure decide.c; emit_feature_state()
                                  wired into fast loop (200 ms = 5 Hz)
  rv_radio_ops_esp32.c          — get_health() fills pkt_yield + send_fail
  csi_collector.{c,h}           — pkt_yield/send_fail accessors (ADR-081 L1)
  rv_feature_state.h            — packed size corrected to 60 bytes
                                  (was incorrectly 80 in initial commit)
  main.c                        — mock binding registered under mock CSI
  CMakeLists.txt                — rv_radio_ops_mock.c under CSI_MOCK_ENABLED
  scripts/validate_qemu_output.py — 3 new ADR-081 checks (17/18/19)
  docs/adr/ADR-081-*.md         — status → Accepted (partial);
                                  implementation-status matrix; measured
                                  benchmarks (decide 3.2 ns, CRC32 614 ns);
                                  bandwidth 300 B/s @ 5 Hz (99.7% vs raw);
                                  verification section
  CHANGELOG.md                  — artifact-level entries

Tests (host, gcc -O2 -std=c11):
  test_adaptive_controller:  18/18 pass, decide() = 3.2 ns/call
  test_rv_feature_state:     15/15 pass, CRC32(56 B) = 614 ns/pkt, 87 MB/s
                             sizeof(rv_feature_state_t) == 60 asserted
                             IEEE CRC32 known vectors verified

Deferred (tracked in ADR-081 roadmap Phase 3/4):
  Layer 3 mesh-plane message types, role-assignment FSM, Rust-side mirror
  trait in crates/wifi-densepose-hardware/src/radio_ops.rs.

* ADR-081: Layer 3 mesh plane + Rust mirror trait — all 5 layers landed

Fully implements the remaining deferred pieces of the adaptive CSI mesh
firmware kernel. All 5 layers (Radio Abstraction, Adaptive Controller,
Mesh Sensing Plane, On-device Feature Extraction, Rust handoff) are
now implemented and host-tested end-to-end.

Layer 3 — Mesh Sensing Plane (firmware/esp32-csi-node/main/rv_mesh.{h,c}):
  * 4 node roles: Unassigned / Anchor / Observer / FusionRelay / Coordinator
  * 7 message types: TIME_SYNC, ROLE_ASSIGN, CHANNEL_PLAN,
    CALIBRATION_START, FEATURE_DELTA, HEALTH, ANOMALY_ALERT
  * 3 auth classes: None / HMAC-SHA256-session / Ed25519-batch
  * Payload types: rv_node_status_t (28 B), rv_anomaly_alert_t (28 B),
    rv_time_sync_t (16 B), rv_role_assign_t (16 B),
    rv_channel_plan_t (24 B), rv_calibration_start_t (20 B)
  * 16-byte envelope + payload + IEEE CRC32 trailer
  * Pure rv_mesh_encode()/rv_mesh_decode() plus typed convenience encoders
  * rv_mesh_send_health() + rv_mesh_send_anomaly() helpers

Controller wiring (adaptive_controller.c):
  * Slow loop (30 s default) now emits HEALTH
  * apply_decision() emits ANOMALY_ALERT on transitions to ALERT /
    DEGRADED
  * Role + mesh epoch tracked in module state; epoch bumps on role
    change

Layer 5 — Rust mirror (crates/wifi-densepose-hardware/src/radio_ops.rs):
  * RadioOps trait mirrors rv_radio_ops_t vtable
  * MockRadio backend for offline tests
  * MeshHeader / NodeStatus / AnomalyAlert types mirror rv_mesh.h
  * Byte-identical IEEE CRC32 (poly 0xEDB88320) verified against
    firmware test vectors (0xCBF43926 for "123456789")
  * decode_mesh / decode_node_status / decode_anomaly_alert / encode_health
  * 8 unit tests, including mesh_constants_match_firmware which asserts
    MESH_MAGIC/VERSION/HEADER_SIZE/MAX_PAYLOAD match rv_mesh.h
    byte-for-byte
  * Exported from lib.rs
  * signal/ruvector/train/mat crates untouched — satisfies ADR-081
    portability acceptance test

Tests (all passing):
  test_adaptive_controller:   18/18   (C, decide() 3.2 ns/call)
  test_rv_feature_state:      15/15   (C, CRC32 87 MB/s)
  test_rv_mesh:               27/27   (C, roundtrip 1.0 µs)
  radio_ops::tests (Rust):     8/8
  --- total:                 68/68 assertions green ---

Docs:
  * ADR-081 status flipped to Accepted
  * Implementation-status matrix updated; L3 + Rust mirror both
    marked Implemented
  * Benchmarks table extended with rv_mesh encode+decode roundtrip
  * Verification section updated with cargo test invocation
  * CHANGELOG: two new entries for L3 mesh plane + Rust mirror

Remaining follow-ups (Phase 3.5 polish, not blocking):
  * Mesh RX path (UDP listener + dispatch) on the firmware
  * Ed25519 signing for CHANNEL_PLAN / CALIBRATION_START
  * Hardware validation on COM7

* Add test_rv_mesh to host-test .gitignore

Fixes an untracked-file warning from the repo stop-hook: the compiled
binary was built by make but the .gitignore update was missed in
8dfb031. No source changes.

* Fix implicit decl of emit_feature_state in adaptive_controller

fast_loop_cb calls emit_feature_state() at line 224, but the static
definition is at line 256. GCC treats the implicit declaration as
non-static, then the real static definition conflicts, and
-Werror=all promotes both to hard build errors.

Add a forward declaration above the first use. Unblocks ESP32-S3
firmware build and all QEMU matrix jobs.

Co-Authored-By: claude-flow <ruv@ruv.net>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-04-20 10:38:23 -04:00

216 lines
7.3 KiB
C

/*
* Host unit test for adaptive_controller_decide().
*
* The ADR-081 controller decision function is deliberately pure: it takes
* (cfg, current_state, observation) and produces a decision. No FreeRTOS,
* no ESP-IDF, no side effects. This test exercises every documented branch
* of the policy.
*
* Build + run (from this directory):
* make -f Makefile
* ./test_adaptive_controller
*/
#include <assert.h>
#include <stdio.h>
#include <string.h>
#include <time.h>
#include "adaptive_controller.h"
#include "rv_radio_ops.h"
static int g_pass = 0, g_fail = 0;
#define CHECK(cond, msg) do { \
if (cond) { g_pass++; } \
else { g_fail++; printf(" FAIL: %s (line %d)\n", msg, __LINE__); } \
} while (0)
static adapt_config_t default_cfg(void) {
adapt_config_t c = {
.fast_loop_ms = 200,
.medium_loop_ms = 1000,
.slow_loop_ms = 30000,
.aggressive = false,
.enable_channel_switch = false,
.enable_role_change = false,
.motion_threshold = 0.20f,
.anomaly_threshold = 0.60f,
.min_pkt_yield = 5,
};
return c;
}
static adapt_observation_t quiet_obs(void) {
adapt_observation_t o = {
.pkt_yield_per_sec = 50,
.send_fail_count = 0,
.rssi_median_dbm = -60,
.noise_floor_dbm = -95,
.motion_score = 0.01f,
.presence_score = 0.0f,
.anomaly_score = 0.0f,
.node_coherence = 1.0f,
};
return o;
}
static void test_degraded_gate_on_pkt_yield_collapse(void) {
printf("test: degraded gate on pkt yield collapse\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.pkt_yield_per_sec = 2; /* below min_pkt_yield=5 */
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.change_state, "should change state");
CHECK(dec.new_state == ADAPT_STATE_DEGRADED, "new state == DEGRADED");
CHECK(dec.new_profile == RV_PROFILE_PASSIVE_LOW_RATE,
"profile pinned to PASSIVE_LOW_RATE in degraded");
CHECK(dec.suggested_vital_interval_ms == 2000,
"cadence relaxed to 2s in degraded");
}
static void test_degraded_gate_on_coherence_loss(void) {
printf("test: degraded gate on coherence loss\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.node_coherence = 0.15f; /* below 0.20 threshold */
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.new_state == ADAPT_STATE_DEGRADED, "coherence loss → DEGRADED");
}
static void test_anomaly_trumps_motion(void) {
printf("test: anomaly trumps motion\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.motion_score = 0.9f; /* high motion */
obs.anomaly_score = 0.8f; /* but anomaly is above threshold */
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.new_state == ADAPT_STATE_ALERT, "anomaly → ALERT");
CHECK(dec.new_profile == RV_PROFILE_FAST_MOTION,
"alert uses FAST_MOTION profile");
CHECK(dec.suggested_vital_interval_ms == 100, "alert cadence 100ms");
}
static void test_motion_triggers_sense_active(void) {
printf("test: motion → SENSE_ACTIVE\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.motion_score = 0.50f;
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.new_state == ADAPT_STATE_SENSE_ACTIVE, "motion → SENSE_ACTIVE");
CHECK(dec.new_profile == RV_PROFILE_FAST_MOTION, "profile FAST_MOTION");
CHECK(dec.suggested_vital_interval_ms == 200,
"non-aggressive cadence 200ms");
}
static void test_aggressive_cadence(void) {
printf("test: aggressive cadence is tighter\n");
adapt_config_t cfg = default_cfg();
cfg.aggressive = true;
adapt_observation_t obs = quiet_obs();
obs.motion_score = 0.50f;
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.suggested_vital_interval_ms == 100,
"aggressive motion cadence 100ms");
}
static void test_stable_presence_uses_resp_high_sens(void) {
printf("test: stable presence → RESP_HIGH_SENS\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.presence_score = 0.8f;
obs.motion_score = 0.01f;
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.new_profile == RV_PROFILE_RESP_HIGH_SENS,
"stable presence uses respiration profile");
CHECK(dec.suggested_vital_interval_ms == 1000,
"respiration cadence 1s");
}
static void test_empty_room_default_is_passive(void) {
printf("test: empty room → PASSIVE_LOW_RATE\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
CHECK(dec.new_profile == RV_PROFILE_PASSIVE_LOW_RATE,
"empty → passive low rate");
}
static void test_hysteresis_no_flap(void) {
printf("test: no change_state when already in target state\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
obs.motion_score = 0.50f;
adapt_decision_t dec;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_ACTIVE, &obs, &dec);
CHECK(!dec.change_state,
"already in SENSE_ACTIVE — no redundant change_state");
}
static void test_null_safety(void) {
printf("test: NULL args are no-ops (no crash)\n");
adapt_decision_t dec = {0};
adaptive_controller_decide(NULL, ADAPT_STATE_SENSE_IDLE, NULL, &dec);
/* if we got here, no segfault — pass */
g_pass++;
printf(" OK\n");
}
static void benchmark_decide(void) {
printf("bench: adaptive_controller_decide() throughput\n");
adapt_config_t cfg = default_cfg();
adapt_observation_t obs = quiet_obs();
adapt_decision_t dec;
const int N = 10000000;
struct timespec a, b;
clock_gettime(CLOCK_MONOTONIC, &a);
for (int i = 0; i < N; i++) {
/* Vary input slightly so the compiler can't fold the call. */
obs.motion_score = (i & 0xff) / 255.0f;
adaptive_controller_decide(&cfg, ADAPT_STATE_SENSE_IDLE, &obs, &dec);
}
clock_gettime(CLOCK_MONOTONIC, &b);
double ns_per_call = ((b.tv_sec - a.tv_sec) * 1e9 +
(b.tv_nsec - a.tv_nsec)) / (double)N;
printf(" %d calls, %.1f ns/call\n", N, ns_per_call);
/* Sanity: decide() is O(constant) — must be under 10us even on a
* slow emulator. Real ESP32 will be ~100-300ns. */
CHECK(ns_per_call < 10000.0, "decide() must be under 10us/call");
}
int main(void) {
printf("=== adaptive_controller_decide() host tests ===\n\n");
test_degraded_gate_on_pkt_yield_collapse();
test_degraded_gate_on_coherence_loss();
test_anomaly_trumps_motion();
test_motion_triggers_sense_active();
test_aggressive_cadence();
test_stable_presence_uses_resp_high_sens();
test_empty_room_default_is_passive();
test_hysteresis_no_flap();
test_null_safety();
benchmark_decide();
printf("\n=== result: %d pass, %d fail ===\n", g_pass, g_fail);
return g_fail > 0 ? 1 : 0;
}