mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-03 12:47:49 +00:00
A RETURN trap is not scoped to the function that installs it. perform_update left its trap referencing function-local installer_tmp/signature_tmp (and service_name/service_was_active) installed, so it re-ran when a later function returned. With those locals gone and 'set -u' active, the updater aborted with 'installer_tmp: unbound variable' immediately after logging 'Auto-update check completed' — pulse-update.service entered failed state even though the update had succeeded (reported #2128, affects v6.3.2/v6.4.1). Disarm the trap with 'trap - RETURN' on its first invocation, and use ${installer_tmp:-}/${signature_tmp:-} so a stray invocation cannot abort the script. Add a regression test asserting no RETURN trap remains after both the successful and the prerelease-refusal paths. Change-source: pulse-maintainer |
||
|---|---|---|
| .. | ||
| integration | ||
| run.sh | ||
| test-ci-benchmarks.sh | ||
| test-cloud-public-signup-smoke.sh | ||
| test-common-lib.sh | ||
| test-hot-dev-auth.sh | ||
| test-hot-dev-bg.sh | ||
| test-hot-dev-runtime.sh | ||
| test-install-ps1-parser.sh | ||
| test-install-update-resilience.sh | ||
| test-npm-audit-retry.sh | ||
| test-pulse-auto-update.sh | ||
| test-reclaim-closed-pr-capacity.sh | ||
| test-retired-trial-acquisition-docs.sh | ||
| test-script-reference-integrity.sh | ||
| test-toggle-mock.sh | ||
| test_benchmark_workflow_contract.py | ||
| test_dependabot_config.py | ||
| test_docs_mirror.py | ||
| test_e2e_workflow_contract.py | ||
| test_gitleaks_ignore.py | ||
| test_localized_public_docs.py | ||
| test_npm_audit_retry.py | ||
| test_public_docs_claims.py | ||
| test_release_train_ci_contract.py | ||
| test_repo_docs_link_drift.py | ||
| test_require_safe_gh_attestation.py | ||
| test_root_pair_diagnostic.py | ||
| test_sync_chart_release_metadata.py | ||
| test_telemetry_adoption_report.py | ||
| test_telemetry_schema_parity.py | ||
| test_uuid_layout_diagnostic.py | ||
| test_validate_published_release.py | ||
| test_workflow_trust.py | ||
| test_write_github_output.py | ||