Pulse/internal
rcourtman 49311b1e39 fix: resolve multiple issues from #485
This commit addresses all issues reported in GitHub issue #485:

1. **SMART Status Recognition**
   - Fix disk health check to accept both "PASSED" and "OK" status
   - Previously only "PASSED" was recognized as healthy
   - Location: internal/monitoring/monitor.go:1255

2. **ZFS Spare Device False Alerts**
   - Skip ZFS SPARE devices unless they have actual errors
   - SPARE devices are intentional and should not trigger alerts
   - Updated in two locations:
     - pkg/proxmox/zfs.go:154 (device filtering)
     - internal/alerts/alerts.go:1077 (alert generation)

3. **Memory Display Granularity**
   - Increase byte formatting precision from 0 to 1 decimal place
   - Improves accuracy (e.g., "1.7 GB" instead of "1 GB" for 86% of 2GB)
   - Location: frontend-modern/src/utils/format.ts:3

4. **Custom Alert Rules Evaluation**
   - Add ReevaluateGuestAlert() method for proper threshold reevaluation
   - Add comments explaining custom rules evaluation limitations
   - Next poll cycle will properly clear stale alerts with new thresholds

Additional improvements:
- Fix ZFS pool alert locking to prevent deadlocks
- Prevent discovery service from running in mock mode
- Restore discovery service when exiting mock mode

Fixes #485
2025-10-01 15:53:42 +00:00
..
adapters chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00
alerts fix: resolve multiple issues from #485 2025-10-01 15:53:42 +00:00
api perf: optimize mock mode state retrieval and JSON encoding 2025-10-01 13:35:49 +00:00
auth chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00
config fix: load mock.env files during config initialization 2025-10-01 14:45:52 +00:00
crypto fix: prevent silent encryption key regeneration that orphans data 2025-09-30 18:23:24 +00:00
discovery feat: add real-time streaming discovery and improve dev/mock mode switching 2025-09-30 13:13:32 +00:00
errors chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00
interfaces chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00
mock fix: correct mock node ID format to match real system 2025-10-01 13:47:59 +00:00
models perf: optimize mock mode state retrieval and JSON encoding 2025-10-01 13:35:49 +00:00
monitoring fix: resolve multiple issues from #485 2025-10-01 15:53:42 +00:00
notifications fix CI errors: remove unused imports and format Go code 2025-09-30 19:59:55 +00:00
types chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00
updates chore: bump version to v4.17.0 2025-10-01 11:14:47 +00:00
utils perf: optimize mock mode state retrieval and JSON encoding 2025-10-01 13:35:49 +00:00
websocket chore: tidy repo formatting and linting 2025-09-29 20:19:18 +00:00