mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-07-10 00:14:38 +00:00
5e78825f54
Two GA-blocking bugs in the auto-update install path:
The pulse-update.service unit was rendered through an unquoted heredoc
containing $${PULSE_SERVICE_NAME}, which bash expands to the installer's
PID, so the unit shipped with ExecCondition checking a service like
"24757{PULSE_SERVICE_NAME}". The condition always failed and systemd
silently skipped every scheduled run, for fresh installs and upgrades
alike. The heredoc now renders the detected service name directly:
ExecCondition=/bin/sh -c 'systemctl is-active --quiet pulse'.
Upgrades also never refreshed the updater assets: a v5 box with
auto-updates enabled keeps pulse-update.timer and autoUpdateEnabled=true,
so the update/reinstall flows never re-ran setup_auto_updates and the
v5.1-pinned /usr/local/bin/pulse-auto-update.sh stayed in place, logging
"Already running latest version" forever instead of selecting v6
releases. The asset-install half of setup_auto_updates is now a shared
install_auto_update_assets(), and a new refresh_auto_updates() rewrites
the helper script and units unconditionally whenever the timer already
exists, without touching system.json or the timer's enabled state. All
five install flows (update, reinstall, --version, --source, fresh) are
wired.
Tests now render the real unit and execute the rendered ExecCondition
against a recording systemctl stub instead of asserting source-text
fragments, pin refresh_auto_updates behavior (stale helper replaced,
system.json and enablement untouched), and pin the call-site wiring.
The deployment-installability contract records both invariants.
Note: rewritten message only — the original local commit carried a
parallel agent's licensing commit message due to a shared-index race;
the tree is byte-identical to the hook-verified original.
|
||
|---|---|---|
| .. | ||
| dev | ||
| eval | ||
| installtests | ||
| lib | ||
| lint-fixer | ||
| release_control | ||
| systemd | ||
| tests | ||
| .go-version | ||
| audit-private-boundary.sh | ||
| backfill-release-assets.sh | ||
| build-release.sh | ||
| bundle.manifest | ||
| bundle.sh | ||
| check-bench-regression.sh | ||
| check-workflow-dispatch-inputs.py | ||
| clean-mock-alerts.sh | ||
| cleanup.sh | ||
| cloud-backup.sh | ||
| com.pulse.hot-dev.plist.template | ||
| conformance-smoke.sh | ||
| demo_public_browser_smoke.cjs | ||
| dev-check.sh | ||
| dev-deploy-agent.sh | ||
| dev-launchd-setup.sh | ||
| dev-launchd-wrapper.sh | ||
| docker-build.sh | ||
| ensure_test_assets.sh | ||
| exclusive-lock.mjs | ||
| generate-release-notes.sh | ||
| generate-self-hosted-feature-catalog.go | ||
| generate-types.go | ||
| hot-dev-bg.sh | ||
| hot-dev.sh | ||
| install-container-agent.sh | ||
| install-docker.sh | ||
| install-go-toolchain.sh | ||
| install-mcp.ps1 | ||
| install-mcp.sh | ||
| install.ps1 | ||
| install.sh | ||
| package-helm-chart.sh | ||
| patrol_e2e_matrix.sh | ||
| pulse-auto-update.sh | ||
| release_asset_common.sh | ||
| release_ldflags.sh | ||
| release_update_key.go | ||
| remerge-parallel.sh | ||
| render_installers.go | ||
| repo-boundary-paid-surface.allowlist | ||
| run_cloud_public_signup_smoke.sh | ||
| run_demo_public_browser_smoke.sh | ||
| run_hosted_staging_smoke.sh | ||
| session-handoff.sh | ||
| standalone.manifest | ||
| sync-production-config.sh | ||
| sync_chart_release_metadata.py | ||
| telemetry_adoption_report.py | ||
| test-vm-disk.sh | ||
| toggle-mock.sh | ||
| trigger-release-dry-run.sh | ||
| trigger-release.sh | ||
| uninstall-sensor-proxy.sh | ||
| validate-published-release.sh | ||
| validate-release.sh | ||