Pulse/internal
rcourtman 6340cd36f2 Dedupe internal/api handler families behind shared flows and generics
Clears the sixteen dupl pair groups in internal/api plus the pkg/pulsecli
pair:

- router.go: privileged settings endpoints share the
  serveSetupTokenOrSettingsWrite gate; patrol findings convert via one
  unifiedFindingFromAI; the five infrastructure-summary chart loops share
  collectGuestChartData / fillChartSeriesFromBatch; the VM/LXC workloads
  summary loops share appendGuestWorkloadSummaries.
- deploy_handlers.go: preflight and job status/SSE handlers share
  handleDeployJobStatus / handleDeployJobEvents.
- recovery_handlers.go: points series/facets share
  parseRecoveryListPointsOptions.
- truenas_handlers.go / vmware_handlers.go / router_routes_registration.go:
  the connection update flow (locate, decode-with-fallback, normalize,
  preserve masked secrets, validate, save, redact) moves to the new
  platform_connection_shared.go (updatePlatformConnection +
  decodeOptionalInstanceRequest + the admin-gated item-route builder);
  per-platform wrappers carry nolint'd declarative wiring only.
- docker_metadata.go / guest_metadata.go: GET/PUT payload semantics move
  to metadata_handlers_shared.go; the zero-record-instead-of-404 contract
  is pinned by TestContract_MetadataGetPayloadsUseZeroRecordsInsteadOf404.
- kubernetes_agents.go / docker_agents.go: lifecycle PUTs share
  per-handler action helpers.
- config_node_handlers.go: PBS/PMG probes share
  testProxmoxPlatformConnection.
- cloud_handoff_handlers.go / purchase_return_redemptions.go: secrets
  sqlite stores open through openHardenedSecretsDB so permission
  hardening stays single-sourced.
- ai_handlers.go / chat_service_adapter.go: the GetMessages adapters are
  deliberate contract mirrors — suppressed with nolint and enforced by
  TestOrchestratorAndChatAdaptersMapTheSameMessageFields.
- pkg/pulsecli/actions.go: action subcommands seed env defaults via
  actionAPIDefaults (tested); the audit/events cobra registration pair is
  nolint'd parallel wiring.
- .golangci.yml: exclude gitignored tmp/ from ./... typechecking.
- subsystem_lookup_test.py: refresh the pinned api-contracts.md line
  numbers shifted by the contract additions.

golangci-lint run ./... is now fully green. Full internal/api and
pkg/pulsecli test suites pass.
2026-06-10 10:52:05 +01:00
..
actionplanner Fail closed dry-run action execution 2026-05-05 09:22:04 +01:00
agentcontext Add discovery readiness to Assistant context 2026-06-04 21:56:36 +01:00
agentexec Make agent command-exec token rejection actionable, not a silent 'Invalid token' 2026-06-09 17:55:09 +01:00
agenttls Add fingerprint-pinned TLS mode for unified agent 2026-04-22 01:36:46 +01:00
agentupdate Fall back to argv0 for agent self-update path on FreeBSD (#1457) 2026-06-04 10:19:45 +01:00
ai Dedupe AI runtime guest-family, tool-pipeline, and provider clones 2026-06-10 09:38:52 +01:00
alerts Dedupe alerts PMG queue checks, vmware clones, licensing and proxmox client clones 2026-06-10 09:49:03 +01:00
api Dedupe internal/api handler families behind shared flows and generics 2026-06-10 10:52:05 +01:00
bootstrap
cloudcp Prepare v6.0.0 release candidate 2026-06-04 14:07:14 +01:00
config Extract saveHistoryData helper to dedupe AI usage / patrol run history saves 2026-06-09 21:57:03 +01:00
crypto Harden secure local key file handling 2026-04-22 05:13:01 +01:00
deploy Remove monitored-system volume caps 2026-05-05 12:59:59 +01:00
discovery
dockeragent Use node-local task counts for node-scoped swarm services 2026-06-04 10:16:09 +01:00
hostagent Prepare v6.0.0 release candidate 2026-06-04 14:07:14 +01:00
hosted Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
hostmetrics Prefer the root-mounted dataset for ZFS pool summaries 2026-06-04 09:43:07 +01:00
kubernetesagent Clear all errcheck and gofmt violations so make lint gates on real findings 2026-06-09 21:42:21 +01:00
license Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
logging Stabilize backend race tests for v6 RC publish 2026-04-11 22:46:34 +01:00
maintenancesentinel Record maintenance evidence in resource timelines 2026-05-13 14:19:59 +01:00
metrics Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
mock Clear all errcheck and gofmt violations so make lint gates on real findings 2026-06-09 21:42:21 +01:00
mockmode Gate release mock fixtures behind demo entitlement 2026-04-10 12:33:57 +01:00
mockmodel Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
mockruntime Gate release mock fixtures behind demo entitlement 2026-04-10 12:33:57 +01:00
models Prepare v6.0.0 release candidate 2026-06-04 14:07:14 +01:00
monitoring Stamp tenant identity into alert webhook payloads 2026-06-10 10:03:39 +01:00
notifications Stamp tenant identity into alert webhook payloads 2026-06-10 10:03:39 +01:00
platformsupport Expand Docker Swarm metadata inventory 2026-05-24 12:07:10 +01:00
proxmoxidentity Fix PBS backup identity matching 2026-06-03 11:43:20 +01:00
recovery Fix PBS backup identity matching 2026-06-03 11:43:20 +01:00
relay Aggregate simplify-review cleanups (no behavior change) 2026-05-12 17:32:11 +01:00
remoteconfig Fix default agent rollout status noise 2026-05-14 14:37:24 +01:00
repoctl Fix pre-commit sibling roots in worktrees 2026-05-13 15:56:19 +01:00
securityutil Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
sensors Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
servicediscovery Make the discovery abstention message name the real cause, not a wrong fix 2026-06-09 16:35:00 +01:00
ssh/knownhosts
storagehealth Fix Unraid storage health explanations 2026-05-08 12:18:09 +01:00
system Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
telemetry Clear all errcheck and gofmt violations so make lint gates on real findings 2026-06-09 21:42:21 +01:00
testutil Stabilize rc1 mock mode and metrics history 2026-04-11 16:47:37 +01:00
truenas Fix TrueNAS unavailable SMART disk health 2026-05-28 12:53:46 +01:00
unifiedresources Share one Resource scaffold across namespaced Kubernetes adapters 2026-06-10 09:16:14 +01:00
updates Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
updatesignature Fix v6 demo release signing key deployment 2026-05-05 21:40:14 +01:00
utils Clear all errcheck and gofmt violations so make lint gates on real findings 2026-06-09 21:42:21 +01:00
vmware Dedupe alerts PMG queue checks, vmware clones, licensing and proxmox client clones 2026-06-10 09:49:03 +01:00
websocket Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00