mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-04-28 11:30:15 +00:00
Linux VM page cache (#1270): QEMU VM memory now falls back to Proxmox RRD's memavailable metric (which excludes reclaimable page cache) when the qemu-guest-agent doesn't provide MemInfo.Available. Previously the fallback was detailedStatus.Mem (total - MemFree), inflating usage to 80%+ on VMs with normal Linux page cache. Mirrors the existing LXC rrd-memavailable path. FreeBSD ZFS ARC (#1264, #1051): The host agent now reads kstat.zfs.misc.arcstats.size via SysctlRaw on FreeBSD and subtracts the ARC size from reported memory usage. ZFS ARC is reclaimable under memory pressure (like Linux SReclaimable) but gopsutil counts it as wired/non-reclaimable, causing false 90%+ memory alerts on TrueNAS and FreeBSD hosts. Build-tagged so it compiles cleanly on all platforms. Fixes #1270 Fixes #1264 Fixes #1051 (cherry picked from commit 94502f83ff9ffc6da28aaadc946a2f7d8b4e9bac)
118 lines
3.3 KiB
Go
118 lines
3.3 KiB
Go
package proxmox
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestClientNodeStatusAndRRD(t *testing.T) {
|
|
client := newTestClient(t, func(w http.ResponseWriter, r *http.Request) {
|
|
switch r.URL.Path {
|
|
case "/api2/json/nodes/node1/status":
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": NodeStatus{CPU: 0.5, KernelVersion: "6.1"},
|
|
})
|
|
case "/api2/json/nodes/node1/rrddata":
|
|
if !strings.Contains(r.URL.RawQuery, "timeframe=hour") || !strings.Contains(r.URL.RawQuery, "cf=AVERAGE") {
|
|
http.Error(w, "bad query", http.StatusBadRequest)
|
|
return
|
|
}
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": []NodeRRDPoint{{Time: 123}},
|
|
})
|
|
case "/api2/json/nodes/node1/lxc/101/rrddata":
|
|
if !strings.Contains(r.URL.RawQuery, "ds=memused") {
|
|
http.Error(w, "bad query", http.StatusBadRequest)
|
|
return
|
|
}
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": []GuestRRDPoint{{Time: 456}},
|
|
})
|
|
case "/api2/json/nodes/node1/qemu/101/rrddata":
|
|
if !strings.Contains(r.URL.RawQuery, "ds=memavailable") {
|
|
http.Error(w, "bad query", http.StatusBadRequest)
|
|
return
|
|
}
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": []GuestRRDPoint{{Time: 789}},
|
|
})
|
|
case "/api2/json/nodes/node1/disks/list":
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": []Disk{{DevPath: "/dev/sda", Model: "Disk"}},
|
|
})
|
|
default:
|
|
http.NotFound(w, r)
|
|
}
|
|
})
|
|
|
|
ctx := context.Background()
|
|
status, err := client.GetNodeStatus(ctx, "node1")
|
|
if err != nil {
|
|
t.Fatalf("GetNodeStatus error: %v", err)
|
|
}
|
|
if status.KernelVersion != "6.1" {
|
|
t.Fatalf("unexpected node status: %+v", status)
|
|
}
|
|
|
|
rrd, err := client.GetNodeRRDData(ctx, "node1", "", "", []string{"cpu"})
|
|
if err != nil {
|
|
t.Fatalf("GetNodeRRDData error: %v", err)
|
|
}
|
|
if len(rrd) != 1 || rrd[0].Time != 123 {
|
|
t.Fatalf("unexpected node rrd: %+v", rrd)
|
|
}
|
|
|
|
guestRRD, err := client.GetLXCRRDData(ctx, "node1", 101, "", "", []string{"memused"})
|
|
if err != nil {
|
|
t.Fatalf("GetLXCRRDData error: %v", err)
|
|
}
|
|
if len(guestRRD) != 1 || guestRRD[0].Time != 456 {
|
|
t.Fatalf("unexpected guest rrd: %+v", guestRRD)
|
|
}
|
|
|
|
vmRRD, err := client.GetVMRRDData(ctx, "node1", 101, "", "", []string{"memavailable"})
|
|
if err != nil {
|
|
t.Fatalf("GetVMRRDData error: %v", err)
|
|
}
|
|
if len(vmRRD) != 1 || vmRRD[0].Time != 789 {
|
|
t.Fatalf("unexpected vm rrd: %+v", vmRRD)
|
|
}
|
|
|
|
disks, err := client.GetDisks(ctx, "node1")
|
|
if err != nil {
|
|
t.Fatalf("GetDisks error: %v", err)
|
|
}
|
|
if len(disks) != 1 || disks[0].DevPath != "/dev/sda" {
|
|
t.Fatalf("unexpected disks: %+v", disks)
|
|
}
|
|
}
|
|
|
|
func TestClientNodeNetworkInterfaces(t *testing.T) {
|
|
client := newTestClient(t, func(w http.ResponseWriter, r *http.Request) {
|
|
switch r.URL.Path {
|
|
case "/api2/json/nodes/node1/network":
|
|
writeJSON(t, w, map[string]interface{}{
|
|
"data": []NodeNetworkInterface{{Iface: "eth0", Active: 1}},
|
|
})
|
|
case "/api2/json/nodes/bad/network":
|
|
http.Error(w, "boom", http.StatusInternalServerError)
|
|
default:
|
|
http.NotFound(w, r)
|
|
}
|
|
})
|
|
|
|
ctx := context.Background()
|
|
ifaces, err := client.GetNodeNetworkInterfaces(ctx, "node1")
|
|
if err != nil {
|
|
t.Fatalf("GetNodeNetworkInterfaces error: %v", err)
|
|
}
|
|
if len(ifaces) != 1 || ifaces[0].Iface != "eth0" {
|
|
t.Fatalf("unexpected interfaces: %+v", ifaces)
|
|
}
|
|
|
|
if _, err := client.GetNodeNetworkInterfaces(ctx, "bad"); err == nil {
|
|
t.Fatal("expected error for non-200 response")
|
|
}
|
|
}
|