mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-05-19 07:54:10 +00:00
- Fix alternating zero I/O metrics by implementing rate caching for stale data from Proxmox - Hardcode polling interval to 10 seconds (matching Proxmox cluster/resources update cycle) - Remove polling interval settings from UI (no longer user-configurable) - Implement efficient VM/container polling using single cluster/resources API call - Remove 'Remove Password' feature (auth is now mandatory) - Fix CSRF validation for Basic Auth (exempt from CSRF checks) - Fix Generate API Token modal and authentication - Remove redundant 'Active' status from Authentication section - Remove Connection Timeout setting from frontend (backend-only) - Clean up frontend console logging (reduce verbosity) - Remove PBS polling interval setting (fixed at 10s) - Add frontend rebuild detection to backend-watch script - Improve first-run setup flow and error handling
218 lines
No EOL
5.2 KiB
Go
218 lines
No EOL
5.2 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/fsnotify/fsnotify"
|
|
"github.com/joho/godotenv"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// ConfigWatcher monitors the .env file for changes and updates runtime config
|
|
type ConfigWatcher struct {
|
|
config *Config
|
|
envPath string
|
|
watcher *fsnotify.Watcher
|
|
stopChan chan struct{}
|
|
lastModTime time.Time
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// NewConfigWatcher creates a new config watcher
|
|
func NewConfigWatcher(config *Config) (*ConfigWatcher, error) {
|
|
// Determine env file path
|
|
envPath := filepath.Join(config.ConfigPath, ".env")
|
|
if config.ConfigPath == "" {
|
|
envPath = "/etc/pulse/.env"
|
|
}
|
|
|
|
// Check for Docker environment
|
|
if _, err := os.Stat("/data/.env"); err == nil {
|
|
envPath = "/data/.env"
|
|
}
|
|
|
|
watcher, err := fsnotify.NewWatcher()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
cw := &ConfigWatcher{
|
|
config: config,
|
|
envPath: envPath,
|
|
watcher: watcher,
|
|
stopChan: make(chan struct{}),
|
|
}
|
|
|
|
// Get initial mod time
|
|
if stat, err := os.Stat(envPath); err == nil {
|
|
cw.lastModTime = stat.ModTime()
|
|
}
|
|
|
|
return cw, nil
|
|
}
|
|
|
|
// Start begins watching the config file
|
|
func (cw *ConfigWatcher) Start() error {
|
|
// Watch the directory instead of the file directly
|
|
// This handles atomic writes better (editor save patterns)
|
|
dir := filepath.Dir(cw.envPath)
|
|
err := cw.watcher.Add(dir)
|
|
if err != nil {
|
|
log.Warn().Err(err).Str("path", dir).Msg("Failed to watch config directory, falling back to polling")
|
|
// Fall back to polling if watch fails
|
|
go cw.pollForChanges()
|
|
return nil
|
|
}
|
|
|
|
go cw.watchForChanges()
|
|
log.Info().Str("path", cw.envPath).Msg("Started watching .env file for changes")
|
|
return nil
|
|
}
|
|
|
|
// Stop stops the config watcher
|
|
func (cw *ConfigWatcher) Stop() {
|
|
close(cw.stopChan)
|
|
cw.watcher.Close()
|
|
}
|
|
|
|
// ReloadConfig manually triggers a config reload (e.g., from SIGHUP)
|
|
func (cw *ConfigWatcher) ReloadConfig() {
|
|
cw.reloadConfig()
|
|
}
|
|
|
|
// watchForChanges handles fsnotify events
|
|
func (cw *ConfigWatcher) watchForChanges() {
|
|
for {
|
|
select {
|
|
case event, ok := <-cw.watcher.Events:
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
// Check if the event is for our .env file
|
|
if filepath.Base(event.Name) == ".env" || event.Name == cw.envPath {
|
|
// Debounce - wait a bit for write to complete
|
|
time.Sleep(100 * time.Millisecond)
|
|
|
|
if event.Op&(fsnotify.Write|fsnotify.Create) != 0 {
|
|
log.Info().Str("event", event.Op.String()).Msg("Detected .env file change")
|
|
cw.reloadConfig()
|
|
}
|
|
}
|
|
|
|
case err, ok := <-cw.watcher.Errors:
|
|
if !ok {
|
|
return
|
|
}
|
|
log.Error().Err(err).Msg("Config watcher error")
|
|
|
|
case <-cw.stopChan:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// pollForChanges is a fallback that polls for changes
|
|
func (cw *ConfigWatcher) pollForChanges() {
|
|
ticker := time.NewTicker(5 * time.Second)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-ticker.C:
|
|
if stat, err := os.Stat(cw.envPath); err == nil {
|
|
if stat.ModTime().After(cw.lastModTime) {
|
|
log.Info().Msg("Detected .env file change via polling")
|
|
cw.lastModTime = stat.ModTime()
|
|
cw.reloadConfig()
|
|
}
|
|
}
|
|
|
|
case <-cw.stopChan:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// reloadConfig reloads the config from the .env file
|
|
func (cw *ConfigWatcher) reloadConfig() {
|
|
cw.mu.Lock()
|
|
defer cw.mu.Unlock()
|
|
|
|
// Load the .env file
|
|
envMap, err := godotenv.Read(cw.envPath)
|
|
if err != nil {
|
|
// File might not exist, which is fine (no auth)
|
|
if !os.IsNotExist(err) {
|
|
log.Error().Err(err).Msg("Failed to read .env file")
|
|
return
|
|
}
|
|
envMap = make(map[string]string)
|
|
}
|
|
|
|
// Track what changed
|
|
var changes []string
|
|
|
|
// Update auth settings
|
|
oldAuthUser := cw.config.AuthUser
|
|
oldAuthPass := cw.config.AuthPass
|
|
oldAPIToken := cw.config.APIToken
|
|
|
|
// Apply auth user
|
|
newUser := strings.Trim(envMap["PULSE_AUTH_USER"], "'\"")
|
|
if newUser != oldAuthUser {
|
|
cw.config.AuthUser = newUser
|
|
if newUser == "" {
|
|
changes = append(changes, "auth user removed")
|
|
} else if oldAuthUser == "" {
|
|
changes = append(changes, "auth user added")
|
|
} else {
|
|
changes = append(changes, "auth user updated")
|
|
}
|
|
}
|
|
|
|
// Apply auth password
|
|
newPass := strings.Trim(envMap["PULSE_AUTH_PASS"], "'\"")
|
|
if newPass != oldAuthPass {
|
|
cw.config.AuthPass = newPass
|
|
if newPass == "" {
|
|
changes = append(changes, "auth password removed")
|
|
} else if oldAuthPass == "" {
|
|
changes = append(changes, "auth password added")
|
|
} else {
|
|
changes = append(changes, "auth password updated")
|
|
}
|
|
}
|
|
|
|
// Apply API token
|
|
newToken := strings.Trim(envMap["API_TOKEN"], "'\"")
|
|
if newToken != oldAPIToken {
|
|
cw.config.APIToken = newToken
|
|
cw.config.APITokenEnabled = (newToken != "")
|
|
if newToken == "" {
|
|
changes = append(changes, "API token removed")
|
|
} else if oldAPIToken == "" {
|
|
changes = append(changes, "API token added")
|
|
} else {
|
|
changes = append(changes, "API token updated")
|
|
}
|
|
}
|
|
|
|
// REMOVED: POLLING_INTERVAL from .env - now ONLY in system.json
|
|
// This prevents confusion and ensures single source of truth
|
|
|
|
// Log changes
|
|
if len(changes) > 0 {
|
|
log.Info().
|
|
Strs("changes", changes).
|
|
Bool("has_auth", cw.config.AuthUser != "" && cw.config.AuthPass != "").
|
|
Bool("has_token", cw.config.APIToken != "").
|
|
Msg("Applied .env file changes to runtime config")
|
|
} else {
|
|
log.Debug().Msg("No relevant changes detected in .env file")
|
|
}
|
|
} |