mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-08-26 17:31:55 +00:00
a3f8b18bfb
A fresh install's natural first question ("how is my machine doing?",
observed live with Ollama qwen3:8b) made the model call pulse_summarize
action=fleet without resource_ids; the tool errored and the agentic loop
surfaced a structured question asking a first-run user for "the
comma-separated list of resource IDs" — pure jargon, funnel-killing
(GitHub discussion #1042). Two root fixes:
pulse_summarize self-targets. action=fleet with resource_ids omitted now
enumerates the known fleet from the executor's unified resource provider
(infrastructure parents first, then guests, then storage; deduped;
bounded at the existing 50-resource cap with a truncation note). Both
modes resolve what models actually pass — canonical unified IDs and
unambiguous names — onto the reporting request shape the way the API
path's resolveReportSubject does: the canonical ID stays ResourceID
(findings/recovery keying) and the resolved metrics target rides
MetricsResourceID, so store queries find data instead of silently
returning zero points. Reporting types are classified from the unified
resource (agent-backed hosts "agent", pure Proxmox nodes "node" — the
documented target-type exception — Docker hosts "docker-host");
resource_type becomes an optional filter/default. Remaining error paths
instruct the model to enumerate or retry and forbid asking the operator
for resource IDs.
Ask-user policy covers tool-argument recovery. The system prompt's
resolve-before-asking section (945e2198's target policy) now extends to
failed tool calls: missing/invalid arguments are self-recovered
(enumerate, retry), and internal identifiers are never valid questions.
The pulse_question description carries the same prohibition so the
structured clarification surface cannot become an identifier elicitation
channel on small local models.
ai-runtime and api-contracts contracts updated in-commit (the
subsystem_lookup line pin follows the api-contracts insertion); full
./internal/ai/... and ./internal/agentcapabilities/... suites green.
|
||
|---|---|---|
| .. | ||
| internal | ||
| agent_preflight.py | ||
| agent_preflight_test.py | ||
| ai_runtime_docs_policy_test.py | ||
| canonical_completion_guard.py | ||
| canonical_completion_guard_test.py | ||
| commercial_cancellation_reactivation_proof.py | ||
| commercial_cancellation_reactivation_rehearsal.py | ||
| contract_audit.py | ||
| contract_audit_test.py | ||
| control_plane.py | ||
| control_plane_audit.py | ||
| control_plane_audit_test.py | ||
| dev_runtime_governance_test.py | ||
| documentation_currentness_test.py | ||
| format_staged_go.py | ||
| format_staged_go_test.py | ||
| generate_platform_support_backend_module.py | ||
| generate_platform_support_frontend_module.py | ||
| governance_stage_guard.py | ||
| governance_stage_guard_test.py | ||
| mobile_relay_auth_approvals_proof.py | ||
| mobile_release_gate.py | ||
| mobile_release_gate_test.py | ||
| paid_feature_claims_proof.py | ||
| proof_entrypoints_test.py | ||
| pulse_intelligence_gate.py | ||
| pulse_intelligence_gate_test.py | ||
| readiness_assertion_guard.py | ||
| readiness_assertion_guard_test.py | ||
| record_rc_to_ga_blocked.py | ||
| record_rc_to_ga_rehearsal.py | ||
| registry_audit.py | ||
| registry_audit_test.py | ||
| relay_registration_reconnect_drain_proof.py | ||
| release_candidate_manifest_test.py | ||
| release_promotion_policy_support.py | ||
| release_promotion_policy_support_test.py | ||
| release_promotion_policy_test.py | ||
| render_release_body.py | ||
| render_release_body_test.py | ||
| repo_file_io.py | ||
| repo_file_io_test.py | ||
| resolve_release_promotion.py | ||
| resolve_release_promotion_test.py | ||
| ssh_host_key_policy_test.py | ||
| staged_commit_shape_guard.py | ||
| staged_commit_shape_guard_test.py | ||
| status_audit.py | ||
| status_audit_test.py | ||
| status_lookup.py | ||
| status_lookup_test.py | ||
| subsystem_contracts.py | ||
| subsystem_contracts_test.py | ||
| subsystem_lookup.py | ||
| subsystem_lookup_test.py | ||
| validate_artifact_release_line.py | ||
| validate_artifact_release_line_test.py | ||
| work_claim.py | ||
| work_claim_test.py | ||