mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-05-22 03:02:35 +00:00
0fcfad3dc5
Implements a comprehensive script improvement infrastructure to reduce code duplication, improve maintainability, and enable easier testing of installer scripts. ## New Infrastructure ### Shared Library System (scripts/lib/) - common.sh: Core utilities (logging, sudo, dry-run, cleanup management) - systemd.sh: Service management helpers with container-safe systemctl - http.sh: HTTP/download helpers with curl/wget fallback and retry logic - README.md: Complete API documentation for all library functions ### Bundler System - scripts/bundle.sh: Concatenates library modules into single-file installers - scripts/bundle.manifest: Defines bundling configuration for distributables - Enables both modular development and curl|bash distribution ### Test Infrastructure - scripts/tests/run.sh: Test harness for running all smoke tests - scripts/tests/test-common-lib.sh: Common library validation (5 tests) - scripts/tests/test-docker-agent-v2.sh: Installer smoke tests (4 tests) - scripts/tests/integration/: Container-based integration tests (5 scenarios) - All tests passing ✓ ## Refactored Installer ### install-docker-agent-v2.sh - Reduced from 1098 to 563 lines (48% code reduction) - Uses shared libraries for all common operations - NEW: --dry-run flag support - Maintains 100% backward compatibility with original - Fully tested with smoke and integration tests ### Key Improvements - Sudo escalation: 100+ lines → 1 function call - Download logic: 51 lines → 1 function call - Service creation: 33 lines → 2 function calls - Logging: Standardized across all operations - Error handling: Improved with common library ## Documentation ### Rollout Strategy (docs/installer-v2-rollout.md) - 3-phase rollout plan (Alpha → Beta → GA) - Feature flag mechanism for gradual deployment - Testing checklist and success metrics - Rollback procedures and communication plan ### Developer Guides - docs/script-library-guide.md: Complete library usage guide - docs/CONTRIBUTING-SCRIPTS.md: Contribution workflow - docs/installer-v2-quickref.md: Quick reference for operators ## Metrics - Code reduction: 48% (1098 → 563 lines) - Reusable functions: 0 → 30+ - Test coverage: 0 → 8 test scenarios - Documentation: 0 → 5 comprehensive guides ## Testing All tests passing: - Smoke tests: 2/2 passed (8 test cases) - Integration tests: 5/5 scenarios passed - Bundled output: Syntax validated, dry-run tested ## Next Steps This lays the foundation for migrating other installers (install.sh, install-sensor-proxy.sh) to use the same pattern, reducing overall maintenance burden and improving code quality across the project. |
||
|---|---|---|
| .. | ||
| development | ||
| images | ||
| monitoring | ||
| operations | ||
| security | ||
| API.md | ||
| CONFIGURATION.md | ||
| CONTRIBUTING-SCRIPTS.md | ||
| DOCKER.md | ||
| DOCKER_HUB_README.md | ||
| DOCKER_MONITORING.md | ||
| FAQ.md | ||
| frontend-style-guide.md | ||
| INSTALL.md | ||
| installer-v2-quickref.md | ||
| installer-v2-rollout.md | ||
| KUBERNETES.md | ||
| MIGRATION.md | ||
| OIDC.md | ||
| PORT_CONFIGURATION.md | ||
| PROXY_AUTH.md | ||
| PULSE_SENSOR_PROXY_HARDENING.md | ||
| RELEASE.md | ||
| REVERSE_PROXY.md | ||
| SCREENSHOTS.md | ||
| script-library-guide.md | ||
| SECURITY.md | ||
| TEMPERATURE_MONITORING.md | ||
| TEMPERATURE_MONITORING_SECURITY.md | ||
| TROUBLESHOOTING.md | ||
| VM_DISK_MONITORING.md | ||
| WEBHOOKS.md | ||
| zfs-monitoring.md | ||