Pulse/pkg/pulsecli
rcourtman 6340cd36f2 Dedupe internal/api handler families behind shared flows and generics
Clears the sixteen dupl pair groups in internal/api plus the pkg/pulsecli
pair:

- router.go: privileged settings endpoints share the
  serveSetupTokenOrSettingsWrite gate; patrol findings convert via one
  unifiedFindingFromAI; the five infrastructure-summary chart loops share
  collectGuestChartData / fillChartSeriesFromBatch; the VM/LXC workloads
  summary loops share appendGuestWorkloadSummaries.
- deploy_handlers.go: preflight and job status/SSE handlers share
  handleDeployJobStatus / handleDeployJobEvents.
- recovery_handlers.go: points series/facets share
  parseRecoveryListPointsOptions.
- truenas_handlers.go / vmware_handlers.go / router_routes_registration.go:
  the connection update flow (locate, decode-with-fallback, normalize,
  preserve masked secrets, validate, save, redact) moves to the new
  platform_connection_shared.go (updatePlatformConnection +
  decodeOptionalInstanceRequest + the admin-gated item-route builder);
  per-platform wrappers carry nolint'd declarative wiring only.
- docker_metadata.go / guest_metadata.go: GET/PUT payload semantics move
  to metadata_handlers_shared.go; the zero-record-instead-of-404 contract
  is pinned by TestContract_MetadataGetPayloadsUseZeroRecordsInsteadOf404.
- kubernetes_agents.go / docker_agents.go: lifecycle PUTs share
  per-handler action helpers.
- config_node_handlers.go: PBS/PMG probes share
  testProxmoxPlatformConnection.
- cloud_handoff_handlers.go / purchase_return_redemptions.go: secrets
  sqlite stores open through openHardenedSecretsDB so permission
  hardening stays single-sourced.
- ai_handlers.go / chat_service_adapter.go: the GetMessages adapters are
  deliberate contract mirrors — suppressed with nolint and enforced by
  TestOrchestratorAndChatAdaptersMapTheSameMessageFields.
- pkg/pulsecli/actions.go: action subcommands seed env defaults via
  actionAPIDefaults (tested); the audit/events cobra registration pair is
  nolint'd parallel wiring.
- .golangci.yml: exclude gitignored tmp/ from ./... typechecking.
- subsystem_lookup_test.py: refresh the pinned api-contracts.md line
  numbers shifted by the contract additions.

golangci-lint run ./... is now fully green. Full internal/api and
pkg/pulsecli test suites pass.
2026-06-10 10:52:05 +01:00
..
actions.go Dedupe internal/api handler families behind shared flows and generics 2026-06-10 10:52:05 +01:00
actions_test.go Dedupe internal/api handler families behind shared flows and generics 2026-06-10 10:52:05 +01:00
api_client.go Add CLI fleet connection reads 2026-05-04 08:40:34 +01:00
bootstrap.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
bootstrap_test.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
command_behavior_test.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
config.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
config_test.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
deps.go Remove 198 unreachable Go functions 2026-06-03 12:29:37 +01:00
fleet.go Add CLI fleet connection reads 2026-05-04 08:40:34 +01:00
fleet_test.go Add CLI fleet connection reads 2026-05-04 08:40:34 +01:00
mock.go Curate demo-facing mock data across platform views 2026-03-31 18:05:55 +01:00
mock_test.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
program.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
program_test.go feat: Pulse v6 release 2026-03-18 16:06:30 +00:00
root.go Add CLI fleet connection reads 2026-05-04 08:40:34 +01:00
root_test.go Add CLI fleet connection reads 2026-05-04 08:40:34 +01:00