mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-07-09 16:00:59 +00:00
b707512e38
golangci-lint run ./... failed on ~190 pre-existing errcheck violations and 5 unformatted files, burying any new regression in noise. Fix all of them: - Test files that hand-rolled mock-mode set/restore (vmware, truenas, and friends) now use the canonical setMockModeForTest/testutil.SetMockMode helper instead of drift copies that ignored SetEnabled errors. - internal/mock and internal/monitoring tests get package-local mustSetEnabled/mustSetMockEnabled/mustSetMonitorMockMode helpers that fail the test on toggle errors. - pkg/auth/sqlite_manager.go, pkg/metrics/store.go, pkg/server/server.go: rollbacks in defers use the explicit-discard idiom, migration renames and rollup commits log failures, the hosted reaper goroutine logs an error exit, shutdown mock-disable logs failures. - Remaining test sites check errors with t.Fatalf/t.Errorf or explicitly discard best-effort calls (restore-chmods, handler-closure unmarshals) per existing repo style. - gofmt: internal/api/maintenance_verification.go, internal/ai/demo.go and three findings test files. Only dupl findings remain (44 pre-existing production-code duplication pairs) — those need real refactors, not mechanical fixes. Full test suites pass for every touched package.
90 lines
2.8 KiB
Go
90 lines
2.8 KiB
Go
package mock
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestLoadMockConfigRejectsInvalidValues(t *testing.T) {
|
|
t.Setenv("PULSE_MOCK_NODES", "0")
|
|
t.Setenv("PULSE_MOCK_VMS_PER_NODE", "-4")
|
|
t.Setenv("PULSE_MOCK_RANDOM_METRICS", "definitely")
|
|
t.Setenv("PULSE_MOCK_STOPPED_PERCENT", "150")
|
|
t.Setenv("PULSE_MOCK_DOCKER_HOSTS", "0")
|
|
t.Setenv("PULSE_MOCK_UPDATE_INTERVAL", "0s")
|
|
|
|
cfg := LoadMockConfig()
|
|
|
|
if cfg.NodeCount != DefaultConfig.NodeCount {
|
|
t.Fatalf("expected default node count %d, got %d", DefaultConfig.NodeCount, cfg.NodeCount)
|
|
}
|
|
if cfg.VMsPerNode != DefaultConfig.VMsPerNode {
|
|
t.Fatalf("expected default VMsPerNode %d, got %d", DefaultConfig.VMsPerNode, cfg.VMsPerNode)
|
|
}
|
|
if cfg.RandomMetrics != DefaultConfig.RandomMetrics {
|
|
t.Fatalf("expected default RandomMetrics=%t, got %t", DefaultConfig.RandomMetrics, cfg.RandomMetrics)
|
|
}
|
|
// 150% parses successfully as 150/100=1.5, then normalizeStoppedPercent clamps to 1.0.
|
|
if cfg.StoppedPercent != 1.0 {
|
|
t.Fatalf("expected clamped StoppedPercent=1.0, got %f", cfg.StoppedPercent)
|
|
}
|
|
if cfg.DockerHostCount != 0 {
|
|
t.Fatalf("expected DockerHostCount=0 from valid env override, got %d", cfg.DockerHostCount)
|
|
}
|
|
if cfg.UpdateInterval != DefaultConfig.UpdateInterval {
|
|
t.Fatalf("expected default UpdateInterval=%s, got %s", DefaultConfig.UpdateInterval, cfg.UpdateInterval)
|
|
}
|
|
}
|
|
|
|
func TestSetMockConfigNormalizesInvalidValues(t *testing.T) {
|
|
mustSetEnabled(t, false)
|
|
t.Cleanup(func() {
|
|
mustSetEnabled(t, false)
|
|
SetMockConfig(DefaultConfig)
|
|
})
|
|
|
|
SetMockConfig(MockConfig{
|
|
NodeCount: -5,
|
|
VMsPerNode: -1,
|
|
LXCsPerNode: -2,
|
|
DockerHostCount: -3,
|
|
DockerContainersPerHost: -4,
|
|
GenericHostCount: -5,
|
|
K8sClusterCount: -6,
|
|
K8sNodesPerCluster: -7,
|
|
K8sPodsPerCluster: -8,
|
|
K8sDeploymentsPerCluster: -9,
|
|
StoppedPercent: 1.5,
|
|
UpdateInterval: 10 * time.Minute,
|
|
})
|
|
|
|
cfg := GetConfig()
|
|
if cfg.NodeCount != 1 {
|
|
t.Fatalf("expected clamped NodeCount=1, got %d", cfg.NodeCount)
|
|
}
|
|
if cfg.VMsPerNode != 0 {
|
|
t.Fatalf("expected clamped VMsPerNode=0, got %d", cfg.VMsPerNode)
|
|
}
|
|
if cfg.LXCsPerNode != 0 {
|
|
t.Fatalf("expected clamped LXCsPerNode=0, got %d", cfg.LXCsPerNode)
|
|
}
|
|
if cfg.StoppedPercent != 1.0 {
|
|
t.Fatalf("expected clamped StoppedPercent=1.0, got %f", cfg.StoppedPercent)
|
|
}
|
|
if cfg.UpdateInterval != maxMockUpdateInterval {
|
|
t.Fatalf("expected clamped UpdateInterval=%s, got %s", maxMockUpdateInterval, cfg.UpdateInterval)
|
|
}
|
|
}
|
|
|
|
func TestBuildFixtureStateAllowsZeroGuestConfig(t *testing.T) {
|
|
cfg := DefaultConfig
|
|
cfg.NodeCount = 3
|
|
cfg.VMsPerNode = 0
|
|
cfg.LXCsPerNode = 0
|
|
|
|
data := buildFixtureState(cfg)
|
|
|
|
if len(data.Nodes) != cfg.NodeCount {
|
|
t.Fatalf("expected %d nodes, got %d", cfg.NodeCount, len(data.Nodes))
|
|
}
|
|
}
|