rcourtman
6340cd36f2
Dedupe internal/api handler families behind shared flows and generics
...
Clears the sixteen dupl pair groups in internal/api plus the pkg/pulsecli
pair:
- router.go: privileged settings endpoints share the
serveSetupTokenOrSettingsWrite gate; patrol findings convert via one
unifiedFindingFromAI; the five infrastructure-summary chart loops share
collectGuestChartData / fillChartSeriesFromBatch; the VM/LXC workloads
summary loops share appendGuestWorkloadSummaries.
- deploy_handlers.go: preflight and job status/SSE handlers share
handleDeployJobStatus / handleDeployJobEvents.
- recovery_handlers.go: points series/facets share
parseRecoveryListPointsOptions.
- truenas_handlers.go / vmware_handlers.go / router_routes_registration.go:
the connection update flow (locate, decode-with-fallback, normalize,
preserve masked secrets, validate, save, redact) moves to the new
platform_connection_shared.go (updatePlatformConnection +
decodeOptionalInstanceRequest + the admin-gated item-route builder);
per-platform wrappers carry nolint'd declarative wiring only.
- docker_metadata.go / guest_metadata.go: GET/PUT payload semantics move
to metadata_handlers_shared.go; the zero-record-instead-of-404 contract
is pinned by TestContract_MetadataGetPayloadsUseZeroRecordsInsteadOf404.
- kubernetes_agents.go / docker_agents.go: lifecycle PUTs share
per-handler action helpers.
- config_node_handlers.go: PBS/PMG probes share
testProxmoxPlatformConnection.
- cloud_handoff_handlers.go / purchase_return_redemptions.go: secrets
sqlite stores open through openHardenedSecretsDB so permission
hardening stays single-sourced.
- ai_handlers.go / chat_service_adapter.go: the GetMessages adapters are
deliberate contract mirrors — suppressed with nolint and enforced by
TestOrchestratorAndChatAdaptersMapTheSameMessageFields.
- pkg/pulsecli/actions.go: action subcommands seed env defaults via
actionAPIDefaults (tested); the audit/events cobra registration pair is
nolint'd parallel wiring.
- .golangci.yml: exclude gitignored tmp/ from ./... typechecking.
- subsystem_lookup_test.py: refresh the pinned api-contracts.md line
numbers shifted by the contract additions.
golangci-lint run ./... is now fully green. Full internal/api and
pkg/pulsecli test suites pass.
2026-06-10 10:52:05 +01:00
rcourtman
faefe6edc8
Remove 198 unreachable Go functions
...
Dead-code sweep. Functions flagged unreachable by golang.org/x/tools/cmd/deadcode
and confirmed unused across pulse, pulse-enterprise, pulse-pro and pulse-mobile by
adversarial cross-repo verification. Cross-module reachability was checked
explicitly (only pkg/ exported symbols are importable by other modules; internal/
packages and _test.go files are not). go build, go vet and test-compile all pass.
2026-06-03 12:29:37 +01:00
rcourtman
82a2494ffa
Add action execution safety contract
2026-05-04 23:19:58 +01:00
rcourtman
2040285085
Add action decision API
2026-05-04 22:56:55 +01:00
rcourtman
c436e1a2a2
Add CLI fleet connection reads
2026-05-04 08:40:34 +01:00
rcourtman
863f214c10
Add CLI action audit reads
2026-05-04 00:18:19 +01:00
rcourtman
f0bf88a89d
Add CLI action capability discovery
2026-05-04 00:10:15 +01:00
rcourtman
5fbe723ad9
Add CLI action planning adapter
2026-05-04 00:05:21 +01:00
rcourtman
a3f99a271b
Curate demo-facing mock data across platform views
2026-03-31 18:05:55 +01:00
rcourtman
778a2577b6
feat: Pulse v6 release
2026-03-18 16:06:30 +00:00
