vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-05-03 05:50:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Allow insecure dev HTTP agent runtime URLs

Browse source
This commit is contained in:
rcourtman 2026-04-23 13:48:54 +01:00
parent 2ae16e885b
commit eb98c13896
22 changed files with 250 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

30
pkg/securityutil/httpurl.go
View file

@ -114,10 +114,24 @@ func IsLoopbackHost(host string) bool {
return ip != nil && ip.IsLoopback()
}
// PulseURLValidationOptions controls optional relaxations for Pulse runtime
// transports. The default zero value preserves the strict production contract.
type PulseURLValidationOptions struct {
// AllowInsecureHTTP permits plain HTTP/WS to non-loopback hosts. This is
// reserved for explicitly insecure agent/dev-runtime flows.
AllowInsecureHTTP bool
}
// NormalizePulseHTTPBaseURL validates a Pulse control-plane base URL.
// HTTPS is required for non-loopback hosts; loopback localhost may use HTTP.
func NormalizePulseHTTPBaseURL(raw string) (*url.URL, error) {
return normalizePulseBaseURL(raw, false)
return NormalizePulseHTTPBaseURLWithOptions(raw, PulseURLValidationOptions{})
}
// NormalizePulseHTTPBaseURLWithOptions validates a Pulse control-plane base URL
// with explicit runtime validation options.
func NormalizePulseHTTPBaseURLWithOptions(raw string, opts PulseURLValidationOptions) (*url.URL, error) {
return normalizePulseBaseURL(raw, false, opts)
}
// NormalizeSecureHTTPBaseURL validates a general-purpose HTTP(S) base URL.
@ -152,10 +166,16 @@ func NormalizeSecureHTTPBaseURL(raw string) (*url.URL, error) {
// NormalizePulseWebSocketBaseURL validates a Pulse command-channel base URL.
// Non-loopback hosts are normalized to WSS; loopback localhost may use WS.
func NormalizePulseWebSocketBaseURL(raw string) (*url.URL, error) {
return normalizePulseBaseURL(raw, true)
return NormalizePulseWebSocketBaseURLWithOptions(raw, PulseURLValidationOptions{})
}
func normalizePulseBaseURL(raw string, websocket bool) (*url.URL, error) {
// NormalizePulseWebSocketBaseURLWithOptions validates a Pulse command-channel
// base URL with explicit runtime validation options.
func NormalizePulseWebSocketBaseURLWithOptions(raw string, opts PulseURLValidationOptions) (*url.URL, error) {
return normalizePulseBaseURL(raw, true, opts)
}
func normalizePulseBaseURL(raw string, websocket bool, opts PulseURLValidationOptions) (*url.URL, error) {
trimmed := strings.TrimSpace(raw)
if trimmed == "" {
return nil, fmt.Errorf("Pulse URL is required")
@ -196,7 +216,7 @@ func normalizePulseBaseURL(raw string, websocket bool) (*url.URL, error) {
parsed.Scheme = "https"
}
case "http":
if !IsLoopbackHost(parsed.Hostname()) {
if !IsLoopbackHost(parsed.Hostname()) && !opts.AllowInsecureHTTP {
if websocket {
return nil, fmt.Errorf("Pulse URL %q must use https/wss unless host is loopback", raw)
}
@ -216,7 +236,7 @@ func normalizePulseBaseURL(raw string, websocket bool) (*url.URL, error) {
if !websocket {
return nil, fmt.Errorf("Pulse URL %q has unsupported scheme %q", raw, parsed.Scheme)
}
if !IsLoopbackHost(parsed.Hostname()) {
if !IsLoopbackHost(parsed.Hostname()) && !opts.AllowInsecureHTTP {
return nil, fmt.Errorf("Pulse URL %q must use https/wss unless host is loopback", raw)
}
parsed.Scheme = "ws"

8
pkg/securityutil/websocket_origin.go
View file

@ -39,7 +39,13 @@ func SameHostWebSocketOrigin(origin string, requestHost string) bool {
// HTTPOriginForWebSocketBaseURL returns the http(s) Origin header for a Pulse websocket base URL.
func HTTPOriginForWebSocketBaseURL(raw string) (string, error) {
parsed, err := NormalizePulseWebSocketBaseURL(raw)
return HTTPOriginForWebSocketBaseURLWithOptions(raw, PulseURLValidationOptions{})
}
// HTTPOriginForWebSocketBaseURLWithOptions returns the http(s) Origin header
// for a Pulse websocket base URL with explicit runtime validation options.
func HTTPOriginForWebSocketBaseURLWithOptions(raw string, opts PulseURLValidationOptions) (string, error) {
parsed, err := NormalizePulseWebSocketBaseURLWithOptions(raw, opts)
if err != nil {
return "", err
}