From d38c00474ebbb7ca7824ceb5719701012e07c4d2 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Wed, 19 Nov 2025 13:33:28 +0000 Subject: [PATCH] fix(setup): make manual repair instructions actionable Issue: When deployment type cannot be determined, error message referenced $PROXY_INSTALLER but deleted it immediately, making instructions unusable. Fix: Provide complete curl commands that users can copy-paste directly: curl -fsSL $PULSE_URL/api/install/install-sensor-proxy.sh | bash -s -- ... This ensures users have a working repair path even when auto-detection fails. Identified by Codex final review. --- internal/api/config_handlers.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/internal/api/config_handlers.go b/internal/api/config_handlers.go index 43be2f31e..0e2c7afc1 100644 --- a/internal/api/config_handlers.go +++ b/internal/api/config_handlers.go @@ -4340,8 +4340,12 @@ if [ "$SKIP_TEMPERATURE_PROMPT" = true ]; then echo "" echo "⚠️ Cannot determine proxy deployment type (no CTID, not standalone)" echo " Manual repair required. Run one of:" - echo " • For container: $PROXY_INSTALLER --ctid --pulse-server %s" - echo " • For standalone: $PROXY_INSTALLER --standalone --http-mode --pulse-server %s" + echo "" + echo " • For container:" + echo " curl -fsSL %s/api/install/install-sensor-proxy.sh | bash -s -- --ctid --pulse-server %s" + echo "" + echo " • For standalone:" + echo " curl -fsSL %s/api/install/install-sensor-proxy.sh | bash -s -- --standalone --http-mode --pulse-server %s" echo "" echo " Keeping existing proxy configuration" rm -f "$PROXY_INSTALLER" @@ -5050,7 +5054,7 @@ fi tokenName, tokenName, tokenName, tokenName, tokenName, tokenName, authToken, pulseURL, serverHost, tokenName, tokenName, storagePerms, sshKeys.ProxyPublicKey, sshKeys.SensorsPublicKey, minProxyReadyVersion, - pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, authToken, pulseURL, authToken, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, tokenName) + pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, authToken, pulseURL, authToken, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, pulseURL, tokenName) } else { // PBS script = fmt.Sprintf(`#!/bin/bash