vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-19 10:33:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Keep published release validation non-destructive

Browse source
This commit is contained in:
pulse-triage[bot] 2026-08-29 10:27:08 +01:00
parent 505dcd571f
commit ba73a5474e
5 changed files with 57 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

17
scripts/installtests/build_release_assets_test.go
View file

@ -202,6 +202,7 @@ func TestReleaseContainerTargetsConsumeImmutableCandidate(t *testing.T) {
"FROM prebuilt-runtime-base AS runtime_prebuilt",
"COPY --from=release_payload /amd64/bin/pulse /opt/pulse/bin/pulse-linux-amd64",
"COPY --from=release_payload /arm64/bin/pulse /opt/pulse/bin/pulse-linux-arm64",
"! -name '*.sig' ! -name '*.sshsig' -exec chmod 755 {} +",
"FROM alpine:3.20@sha256:",
"AS agent_runtime_prebuilt",
} {
@ -716,13 +717,27 @@ func TestCreateReleaseUploadsPowerShellInstaller(t *testing.T) {
`--validate-body-file "$RELEASE_BODY_FILE"`,
`--expected-body-file "$CLEAN_BODY_FILE"`,
`Quarantine malformed release body`,
`The release was quarantined as a draft without deleting its assets.`,
`Draft releases are quarantined; published releases remain immutable for explicit remediation.`,
`name: Update release body - Success
if: steps.context.outputs.should_run == 'true' && steps.context.outputs.draft == 'true'`,
`name: Delete all release assets on failure
if: steps.context.outputs.should_run == 'true' && steps.context.outputs.draft == 'true'`,
`name: Update release body - Failure
if: steps.context.outputs.should_run == 'true' && steps.context.outputs.draft == 'true'`,
}
for _, needle := range validationRequired {
if !strings.Contains(validationWorkflow, needle) {
t.Fatalf("validate-release-assets.yml missing required status publication contract: %s", needle)
}
}
for _, forbidden := range []string{
"Release was published; reverting to draft before deleting assets",
"A published release edit introduced invalid assets",
} {
if strings.Contains(validationWorkflow, forbidden) {
t.Fatalf("published release validation must not retain mutation path %q", forbidden)
}
}
}
func TestCurrentStablePatchReleasePacketTracksInstallMetadata(t *testing.T) {

22
scripts/release_control/release_promotion_policy_test.py
View file

@ -1484,7 +1484,27 @@ class ReleasePromotionPolicyTest(unittest.TestCase):
self.assertIn("--expected-body-file \"$CLEAN_BODY_FILE\"", validation_workflow)
self.assertIn("Quarantine malformed release body", validation_workflow)
self.assertIn(
"The release was quarantined as a draft without deleting its assets.",
"Draft releases are quarantined; published releases remain immutable for explicit remediation.",
validation_workflow,
)
for step in (
"Quarantine malformed release body",
"Update release body - Success",
"Delete all release assets on failure",
"Update release body - Failure",
):
self.assertIn(
f"- name: {step}\n"
" if: steps.context.outputs.should_run == 'true' && "
"steps.context.outputs.draft == 'true'",
validation_workflow,
)
self.assertNotIn(
"Release was published; reverting to draft before deleting assets",
validation_workflow,
)
self.assertNotIn(
"A published release edit introduced invalid assets",
validation_workflow,
)
self.assertIn(