mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-19 10:33:29 +00:00
Stop posting retest boilerplate on maintainer issue reopens
The retest-comment workflow fired on 'reopened' as well as 'opened', and canPostRetestComment gated on the issue author's association, not the reopen actor's. Since non-collaborator reporters cannot reopen maintainer-closed issues, a reopened event is in practice always a deliberate maintainer decision, and the bot would post version-retest boilerplate that contradicts the maintainer's own comment while planting the needs-retest auto-close marker on an issue they chose to keep open (seen on #1471). Restrict the trigger and the guard to 'opened' and pin the reopened skip with a test.
This commit is contained in:
parent
304d4fa90f
commit
b0f22f1130
3 changed files with 24 additions and 3 deletions
19
.github/scripts/issue-version-triage.test.cjs
vendored
19
.github/scripts/issue-version-triage.test.cjs
vendored
|
|
@ -145,6 +145,25 @@ test("postRetestComment comments once for older non-maintainer bug reports", asy
|
|||
);
|
||||
});
|
||||
|
||||
test("postRetestComment skips reopened issues", async () => {
|
||||
const { github, calls } = createGithub({ latestVersion: "6.0.1" });
|
||||
const issue = {
|
||||
number: 1471,
|
||||
title: "Disk temperature at 0°C",
|
||||
body: "## Feedback type\nBug / regression\n\n## Pulse version\n5.1.31\n",
|
||||
labels: [],
|
||||
author_association: "NONE",
|
||||
};
|
||||
|
||||
await triage.postRetestComment({
|
||||
github,
|
||||
context: createContext({ action: "reopened", issue }),
|
||||
core: createCore(),
|
||||
});
|
||||
|
||||
assert.equal(calls.createComment.length, 0);
|
||||
});
|
||||
|
||||
test("postRetestComment skips maintainer-authored issues", async () => {
|
||||
const { github, calls } = createGithub({ latestVersion: "6.0.1" });
|
||||
const issue = {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue