vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-19 02:28:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Gate every release cut on a render-level smoke suite

Browse source 
v6.2.0-rc.5 shipped with an empty Proxmox workloads table and a crashing
Thresholds page (#1663) while the assertions that catch exactly that were
failing in CI: spec 64 red in the non-gating probation tier two hours
before the tag, and the gating Core E2E verdict red on the release commit
itself — which the release pipeline never consults. integration_tests is
also skipped entirely for prereleases, so the builds users test shipped
with no integration coverage at all.

Close the hole with a release_smoke job that runs for every cut,
prereleases included, and blocks create_release and the release verdict:
four interaction-free render assertions (Proxmox nodes+workloads, Docker
hosts+containers, Kubernetes clusters+pods, Alert thresholds) against the
mock-mode image built from the verified frontend bundle. The mock fixture
graph now always contains one freshly provisioned zero-used guest
filesystem, so the omitted-zero-numerics wire shape that crashed rc.5
stays exercised on every mock-backed surface. Verified locally: the suite
passes on main and fails on the rc.5 frontend for exactly the two shipped
regressions.
This commit is contained in:
rcourtman 2026-08-01 13:29:40 +01:00
parent 630d151460
commit 9ab38b940e
3 changed files with 223 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

87
tests/integration/tests/95-release-smoke.spec.ts Normal file
View file

@ -0,0 +1,87 @@
import { expect, test, type Page } from "@playwright/test";
import { ensureAuthenticated } from "./helpers";
const DESKTOP_VIEWPORT = { width: 1440, height: 900 };
// Release smoke: the minimum bar every cut ships against, prereleases
// included. Each check asserts only that a primary surface renders real
// inventory from the mock dataset — no interaction sequences, no timing
// races — so a failure here always means the surface is broken, never that
// the test is flaky. v6.2.0-rc.5 shipped with an empty Proxmox workloads
// table and a crashing Thresholds page (#1663) while exactly these
// assertions were failing in non-gating tiers; this spec exists so that
// class of regression blocks the release instead.
//
// Keep this file interaction-free and assertion-light. Anything richer
// belongs in the numbered feature specs, not here.
async function expectNoErrorBoundary(page: Page) {
await expect(
page.getByText("This page couldn't load"),
"an error boundary fired on a release-gating surface",
).toHaveCount(0);
}
test.describe("Release smoke", () => {
test.setTimeout(180_000);
test.beforeEach(async ({ page }, testInfo) => {
test.skip(
testInfo.project.name.startsWith("mobile-"),
"Release smoke gates on the desktop shell",
);
await page.setViewportSize(DESKTOP_VIEWPORT);
await ensureAuthenticated(page);
});
test("Proxmox overview renders nodes and workloads", async ({ page }) => {
await page.goto("/proxmox", { waitUntil: "domcontentloaded" });
// Nodes and workloads travel different data paths (websocket state vs
// /api/resources); rc.5 broke exactly one of them, so assert both.
const nodeRows = page.locator("[data-proxmox-host-row]");
await expect(nodeRows.first()).toBeVisible({ timeout: 60_000 });
const workloadRows = page.locator("tr[data-guest-id]");
await expect(workloadRows.first()).toBeVisible({ timeout: 60_000 });
await expect(page.getByText("No Proxmox workloads")).toHaveCount(0);
await expectNoErrorBoundary(page);
});
test("Docker page renders hosts and containers", async ({ page }) => {
await page.goto("/docker", { waitUntil: "domcontentloaded" });
await expect(
page.locator("tr[data-docker-host-row]").first(),
).toBeVisible({ timeout: 60_000 });
await expect(
page.locator("tr[data-docker-container-row]").first(),
).toBeVisible({ timeout: 60_000 });
await expectNoErrorBoundary(page);
});
test("Kubernetes page renders clusters and pods", async ({ page }) => {
await page.goto("/kubernetes", { waitUntil: "domcontentloaded" });
await expect(
page.locator("tr[data-kubernetes-cluster-row]").first(),
).toBeVisible({ timeout: 60_000 });
await expect(
page.locator("tr[data-kubernetes-pod-row]").first(),
).toBeVisible({ timeout: 60_000 });
await expectNoErrorBoundary(page);
});
test("Alert thresholds page renders guest sections", async ({ page }) => {
await page.goto("/alerts/thresholds", { waitUntil: "domcontentloaded" });
// The mock dataset always contains a freshly provisioned zero-used
// guest filesystem (ensureFreshFilesystemFixture), so this render
// covers the omitted-zero-numerics wire shape that crashed rc.5.
await expect(
page.getByText("Virtualization Hosts", { exact: false }).first(),
).toBeVisible({ timeout: 60_000 });
await expectNoErrorBoundary(page);
});
});