vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-19 02:28:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

fix: prefer status-mem over status-freemem for VM memory calculation

Browse source 
Proxmox's FreeMem field reports free memory relative to the balloon's
guest-visible total (total_mem), not relative to MaxMem. When ballooning
is active and the VM's memory has been reduced, subtracting FreeMem from
MaxMem produces wildly inflated usage (e.g. 97% when actual usage is 20%).

Proxmox's Mem field is already calculated as (total_mem - free_mem),
giving the correct used bytes regardless of balloon state. Swap the
priority so Mem is checked before FreeMem.

Related to #1185
This commit is contained in:
rcourtman 2026-02-04 12:08:33 +00:00
parent 8313d66e64
commit 902bdd92c2
2 changed files with 20 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
internal/monitoring/monitor.go
View file

@ -6647,12 +6647,19 @@ func (m *Monitor) pollVMsAndContainersEfficient(ctx context.Context, instanceNam
memAvailable = memTotal memAvailable = memTotal
} }
memUsed = memTotal - memAvailable memUsed = memTotal - memAvailable
case detailedStatus.Mem > 0:
// Prefer Mem over FreeMem: Proxmox calculates Mem as
// (total_mem - free_mem) using the balloon's guest-visible
// total, which is correct even when ballooning is active.
// FreeMem is relative to the balloon allocation (not MaxMem),
// so subtracting it from MaxMem produces wildly inflated
// usage when the balloon has reduced the VM's memory.
// Refs: #1185
memUsed = detailedStatus.Mem
memorySource = "status-mem"
case detailedStatus.FreeMem > 0 && memTotal >= detailedStatus.FreeMem: case detailedStatus.FreeMem > 0 && memTotal >= detailedStatus.FreeMem:
memUsed = memTotal - detailedStatus.FreeMem memUsed = memTotal - detailedStatus.FreeMem
memorySource = "status-freemem" memorySource = "status-freemem"
case detailedStatus.Mem > 0:
memUsed = detailedStatus.Mem
memorySource = "status-mem"
} }
if memUsed > memTotal { if memUsed > memTotal {
memUsed = memTotal memUsed = memTotal

13
internal/monitoring/monitor_polling.go
View file

@ -364,12 +364,19 @@ func (m *Monitor) pollVMsWithNodes(ctx context.Context, instanceName string, clu
memAvailable = memTotal memAvailable = memTotal
} }
memUsed = memTotal - memAvailable memUsed = memTotal - memAvailable
case vmStatus.Mem > 0:
// Prefer Mem over FreeMem: Proxmox calculates Mem as
// (total_mem - free_mem) using the balloon's guest-visible
// total, which is correct even when ballooning is active.
// FreeMem is relative to the balloon allocation (not MaxMem),
// so subtracting it from MaxMem produces wildly inflated
// usage when the balloon has reduced the VM's memory.
// Refs: #1185
memUsed = vmStatus.Mem
memorySource = "status-mem"
case vmStatus.FreeMem > 0: case vmStatus.FreeMem > 0:
memUsed = memTotal - vmStatus.FreeMem memUsed = memTotal - vmStatus.FreeMem
memorySource = "status-freemem" memorySource = "status-freemem"
case vmStatus.Mem > 0:
memUsed = vmStatus.Mem
memorySource = "status-mem"
default: default:
memUsed = 0 memUsed = 0
memorySource = "status-unavailable" memorySource = "status-unavailable"