vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-19 02:28:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Remove blanket Community-visible upgrade marketing surfaces

Browse source 
Cut three surfaces that nagged Community users without explicit feature
engagement: the Dashboard RelayOnboardingCard paywall, the app-wide
ActiveUseTrialNudge (already dead code with no render sites), and the
SetupCompletionPanel "Monitor from Anywhere" Relay trial block.

Feature-gated discovery that fires only when a user clicks a locked
feature (alert investigate, history ranges, Patrol AI modes, Settings
panels) is intentionally left alone — those are user-initiated, not
blanket funnels.

Governance cascade: cloud-paid.md extends the Settings no-funnel rule
to Dashboard and setup completion; registry.json, status.json readiness
assertions RA5/RA18, frontend-primitives/storage-recovery/
performance-and-scalability contracts, the high-risk verification
matrix, the relay registration proof script, the subsystem lookup
tests, and the obsolete integration spec are all scrubbed of
references to the removed files. Blocked-record regenerated against
current VERSION=6.0.0-rc.2 so the promotion-policy test no longer
diffs on a stale rc.1 artifact.
This commit is contained in:
rcourtman 2026-04-17 14:49:28 +01:00
parent d35762b029
commit 85191a9051
28 changed files with 107 additions and 1726 deletions
Download patch file Download diff file Expand all files Collapse all files

91
tests/integration/tests/59-dashboard-relay-onboarding-trial-rate-limit.spec.ts
View file

@ -1,91 +0,0 @@
import { expect, test, type Page } from '@playwright/test';
import { ensureAuthenticated, getMockMode, setMockMode } from './helpers';
const FREE_RUNTIME_CAPABILITIES = {
capabilities: ['update_alerts', 'sso', 'ai_patrol'],
limits: [],
hosted_mode: false,
max_history_days: 7,
};
async function waitForDashboardReady(page: Page) {
await expect(page).toHaveURL(/\/dashboard(?:\?.*)?$/);
await expect(page.getByTestId('dashboard-page')).toBeVisible();
await page.waitForFunction(
() => !document.querySelector('[data-testid="dashboard-loading"]'),
undefined,
{ timeout: 30_000 },
);
}
test.describe.serial('Dashboard relay onboarding trial rate limit', () => {
test('shows Retry-After guidance on the live dashboard relay onboarding CTA', async ({
page,
}, testInfo) => {
test.skip(
testInfo.project.name.startsWith('mobile-'),
'Desktop-only dashboard relay onboarding coverage',
);
await page.route('**/api/license/runtime-capabilities', async (route) => {
await route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify(FREE_RUNTIME_CAPABILITIES),
});
});
await page.route('**/api/license/trial/start', async (route) => {
await route.fulfill({
status: 429,
headers: {
'Content-Type': 'application/json',
'Retry-After': '120',
},
body: JSON.stringify({
code: 'trial_rate_limited',
error: 'Trial start rate limit exceeded',
details: {
retry_after_seconds: '45',
},
}),
});
});
await ensureAuthenticated(page);
let initialMockMode: { enabled: boolean } | null = null;
try {
initialMockMode = await getMockMode(page);
if (!initialMockMode.enabled) {
await setMockMode(page, true);
}
} catch (error) {
console.warn(`[relay-onboarding] unable to read/set mock mode: ${String(error)}`);
}
try {
await page.goto('/dashboard');
await waitForDashboardReady(page);
await expect(page.getByRole('heading', { name: 'Pair Your Mobile Device' })).toBeVisible();
const startTrialButton = page.getByRole('button', { name: /or start a pro trial/i });
await expect(startTrialButton).toBeVisible();
await startTrialButton.click();
await expect(page.getByText('Try again in about 2 minutes')).toBeVisible();
await expect(page.getByText('Try again in about a minute')).toHaveCount(0);
} finally {
if (initialMockMode && !initialMockMode.enabled) {
try {
await setMockMode(page, false);
} catch (error) {
console.warn(
`[relay-onboarding] unable to restore mock mode, continuing: ${String(error)}`,
);
}
}
}
});
});