vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-05-20 01:01:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: wait for async save in guest metadata test

Browse source 
The TestGuestMetadataStore_GetWithLegacyMigration_ClusteredMatchesNodeFormat
test was flaky because it triggered an async save in GetWithLegacyMigration
but didn't wait for it to complete. When the test ended, t.TempDir() tried
to clean up while the goroutine was still writing, causing 'directory not
empty' errors on CI.

Added time.Sleep(100ms) to wait for the async save, matching the pattern
used in other similar tests in the same file.
This commit is contained in:
rcourtman 2025-12-18 22:48:15 +00:00
parent 0d11da74e2
commit 8400976e80
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
internal/config/guest_metadata_test.go
View file

@ -647,6 +647,9 @@ func TestGuestMetadataStore_GetWithLegacyMigration_ClusteredMatchesNodeFormat(t
if result.ID != "pve1:node1:100" {
t.Errorf("ID = %q, want %q", result.ID, "pve1:node1:100")
}
// Wait for async save to complete before test cleanup
time.Sleep(100 * time.Millisecond)
}
func TestGuestMetadataStore_GetWithLegacyMigration_ConcurrentMigration(t *testing.T) {