vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-13 00:34:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

Format generated self-hosted feature catalog with prettier in the generator

Browse source 
The generator emitted JSON-marshaled TypeScript (quoted keys, no trailing
commas) while the committed file is prettier-formatted, so every run dirtied
frontend-modern/src/utils/selfHostedFeatureCatalog.generated.ts with a
324-line formatting-only diff. The generator now runs the frontend's own
prettier on the file after writing it, so runs at a clean checkout leave the
tree clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
courtmanr@gmail.com 2026-07-27 11:58:05 +01:00
parent c2c51019d7
commit 7f3106b6bd
1 changed files with 27 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

30
scripts/generate-self-hosted-feature-catalog.go
View file

@ -8,6 +8,7 @@ import (
"fmt"
"go/format"
"os"
"os/exec"
"path/filepath"
"sort"
"strings"
@ -50,7 +51,7 @@ func main() {
"pro": append([]string(nil), licensing.TierFeatures[licensing.TierPro]...),
}
if err := writeFrontendModule(filepath.Join(repoRoot, "frontend-modern/src/utils/selfHostedFeatureCatalog.generated.ts"), entries); err != nil {
if err := writeFrontendModule(filepath.Join(repoRoot, "frontend-modern"), entries); err != nil {
fail(err)
}
@ -89,7 +90,8 @@ func buildGeneratedEntries() []generatedFeatureEntry {
return entries
}
func writeFrontendModule(path string, entries []generatedFeatureEntry) error {
func writeFrontendModule(frontendDir string, entries []generatedFeatureEntry) error {
path := filepath.Join(frontendDir, "src/utils/selfHostedFeatureCatalog.generated.ts")
payload, err := json.MarshalIndent(entries, "", " ")
if err != nil {
return err
@ -150,7 +152,29 @@ func writeFrontendModule(path string, entries []generatedFeatureEntry) error {
buf.WriteString(" return SELF_HOSTED_FEATURE_CATALOG.filter((entry) => entry.roles[tier] === role);\n")
buf.WriteString("}\n")
return os.WriteFile(path, buf.Bytes(), 0o644)
if err := os.WriteFile(path, buf.Bytes(), 0o644); err != nil {
return err
}
return formatWithPrettier(frontendDir, path)
}
// formatWithPrettier rewrites the generated module with the frontend's own
// prettier setup so generator runs stay byte-identical to the committed,
// prettier-formatted file.
func formatWithPrettier(frontendDir, path string) error {
prettier := filepath.Join(frontendDir, "node_modules", ".bin", "prettier")
var cmd *exec.Cmd
if _, err := os.Stat(prettier); err == nil {
cmd = exec.Command(prettier, "--write", path)
} else {
cmd = exec.Command("npx", "--yes", "prettier", "--write", path)
}
cmd.Dir = frontendDir
cmd.Stderr = os.Stderr
if err := cmd.Run(); err != nil {
return fmt.Errorf("prettier %s: %w", path, err)
}
return nil
}
func writePulseProModule(path string, entries []generatedFeatureEntry, tierFeatures map[string][]string) error {