Refine Proxmox node memory fallback (#582)

internal/monitoring/monitor_memory_test.go

@@ -0,0 +1,178 @@
+package monitoring
+
+import (
+	"context"
+	"math"
+	"testing"
+	"time"
+
+	"github.com/rcourtman/pulse-go-rewrite/internal/alerts"
+	"github.com/rcourtman/pulse-go-rewrite/internal/config"
+	"github.com/rcourtman/pulse-go-rewrite/internal/models"
+	"github.com/rcourtman/pulse-go-rewrite/internal/notifications"
+	"github.com/rcourtman/pulse-go-rewrite/pkg/proxmox"
+)
+
+type stubPVEClient struct {
+	nodes      []proxmox.Node
+	nodeStatus *proxmox.NodeStatus
+	rrdPoints  []proxmox.NodeRRDPoint
+}
+
+var _ PVEClientInterface = (*stubPVEClient)(nil)
+
+func (s *stubPVEClient) GetNodes(ctx context.Context) ([]proxmox.Node, error) {
+	return s.nodes, nil
+}
+
+func (s *stubPVEClient) GetNodeStatus(ctx context.Context, node string) (*proxmox.NodeStatus, error) {
+	return s.nodeStatus, nil
+}
+
+func (s *stubPVEClient) GetNodeRRDData(ctx context.Context, node string, timeframe string, cf string, ds []string) ([]proxmox.NodeRRDPoint, error) {
+	return s.rrdPoints, nil
+}
+
+func (s *stubPVEClient) GetVMs(ctx context.Context, node string) ([]proxmox.VM, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetContainers(ctx context.Context, node string) ([]proxmox.Container, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetStorage(ctx context.Context, node string) ([]proxmox.Storage, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetAllStorage(ctx context.Context) ([]proxmox.Storage, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetBackupTasks(ctx context.Context) ([]proxmox.Task, error) { return nil, nil }
+func (s *stubPVEClient) GetStorageContent(ctx context.Context, node, storage string) ([]proxmox.StorageContent, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetVMSnapshots(ctx context.Context, node string, vmid int) ([]proxmox.Snapshot, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetContainerSnapshots(ctx context.Context, node string, vmid int) ([]proxmox.Snapshot, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetVMStatus(ctx context.Context, node string, vmid int) (*proxmox.VMStatus, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetContainerStatus(ctx context.Context, node string, vmid int) (*proxmox.Container, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetClusterResources(ctx context.Context, resourceType string) ([]proxmox.ClusterResource, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) IsClusterMember(ctx context.Context) (bool, error) { return false, nil }
+func (s *stubPVEClient) GetVMFSInfo(ctx context.Context, node string, vmid int) ([]proxmox.VMFileSystem, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetVMNetworkInterfaces(ctx context.Context, node string, vmid int) ([]proxmox.VMNetworkInterface, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetVMAgentInfo(ctx context.Context, node string, vmid int) (map[string]interface{}, error) {
+	return map[string]interface{}{}, nil
+}
+func (s *stubPVEClient) GetZFSPoolStatus(ctx context.Context, node string) ([]proxmox.ZFSPoolStatus, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetZFSPoolsWithDetails(ctx context.Context, node string) ([]proxmox.ZFSPoolInfo, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetDisks(ctx context.Context, node string) ([]proxmox.Disk, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetCephStatus(ctx context.Context) (*proxmox.CephStatus, error) {
+	return nil, nil
+}
+func (s *stubPVEClient) GetCephDF(ctx context.Context) (*proxmox.CephDF, error) { return nil, nil }
+
+func floatPtr(v float64) *float64 { return &v }
+
+func TestPollPVEInstanceUsesRRDMemUsedFallback(t *testing.T) {
+	t.Setenv("PULSE_DATA_DIR", t.TempDir())
+
+	total := uint64(16 * 1024 * 1024 * 1024)
+	actualUsed := total / 3
+
+	client := &stubPVEClient{
+		nodes: []proxmox.Node{
+			{
+				Node:    "node1",
+				Status:  "online",
+				CPU:     0.15,
+				MaxCPU:  8,
+				Mem:     total,
+				MaxMem:  total,
+				Disk:    0,
+				MaxDisk: 0,
+				Uptime:  3600,
+			},
+		},
+		nodeStatus: &proxmox.NodeStatus{
+			Memory: &proxmox.MemoryStatus{
+				Total: total,
+				Used:  total,
+				Free:  0,
+			},
+		},
+		rrdPoints: []proxmox.NodeRRDPoint{
+			{
+				MemTotal: floatPtr(float64(total)),
+				MemUsed:  floatPtr(float64(actualUsed)),
+			},
+		},
+	}
+
+	mon := &Monitor{
+		config: &config.Config{
+			PVEInstances: []config.PVEInstance{
+				{
+					Name: "test",
+					Host: "https://pve",
+				},
+			},
+		},
+		state:                models.NewState(),
+		alertManager:         alerts.NewManager(),
+		notificationMgr:      notifications.NewNotificationManager(""),
+		metricsHistory:       NewMetricsHistory(32, time.Hour),
+		nodeSnapshots:        make(map[string]NodeMemorySnapshot),
+		guestSnapshots:       make(map[string]GuestMemorySnapshot),
+		nodeRRDMemCache:      make(map[string]rrdMemCacheEntry),
+		lastClusterCheck:     make(map[string]time.Time),
+		lastPhysicalDiskPoll: make(map[string]time.Time),
+	}
+	defer mon.alertManager.Stop()
+
+	mon.pollPVEInstance(context.Background(), "test", client)
+
+	snapshot := mon.state.GetSnapshot()
+	if len(snapshot.Nodes) != 1 {
+		t.Fatalf("expected one node in state, got %d", len(snapshot.Nodes))
+	}
+
+	node := snapshot.Nodes[0]
+	expectedUsage := (float64(actualUsed) / float64(total)) * 100
+	if diff := math.Abs(node.Memory.Usage - expectedUsage); diff > 0.5 {
+		t.Fatalf("memory usage mismatch: got %.2f want %.2f (diff %.2f)", node.Memory.Usage, expectedUsage, diff)
+	}
+	if node.Memory.Used != int64(actualUsed) {
+		t.Fatalf("memory used mismatch: got %d want %d", node.Memory.Used, actualUsed)
+	}
+
+	snapKey := makeNodeSnapshotKey("test", "node1")
+	mon.diagMu.RLock()
+	snap, ok := mon.nodeSnapshots[snapKey]
+	mon.diagMu.RUnlock()
+	if !ok {
+		t.Fatal("expected node snapshot entry to be recorded")
+	}
+	if snap.MemorySource != "rrd-memused" {
+		t.Fatalf("expected memory source rrd-memused, got %q", snap.MemorySource)
+	}
+	if snap.Raw.RRDUsed != actualUsed {
+		t.Fatalf("expected snapshot RRD used %d, got %d", actualUsed, snap.Raw.RRDUsed)
+	}
+}