From 768d60739b99ff5a7c7585bf02f5e20ee13ec2b7 Mon Sep 17 00:00:00 2001 From: Pulse Monitor Date: Tue, 12 Aug 2025 07:40:07 +0000 Subject: [PATCH] fix: complete fix for #296 - PBS edit now shows PBS form, not PVE form Ensures each modal (PVE/PBS) only receives editingNode if the node type matches. This prevents PBS edit from showing PVE form and vice versa. Both issues from #296 are now addressed: 1. PBS forms no longer get contaminated with PVE data (previous commit) 2. PBS edit now correctly shows PBS form instead of PVE form (this commit) --- frontend-modern/src/components/Settings/Settings.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend-modern/src/components/Settings/Settings.tsx b/frontend-modern/src/components/Settings/Settings.tsx index dfedebf39..4ed15aff2 100644 --- a/frontend-modern/src/components/Settings/Settings.tsx +++ b/frontend-modern/src/components/Settings/Settings.tsx @@ -1842,7 +1842,7 @@ docker run -d \ setModalResetKey(prev => prev + 1); }} nodeType="pve" - editingNode={editingNode() ?? undefined} + editingNode={editingNode()?.type === 'pve' ? editingNode() ?? undefined : undefined} onSave={async (nodeData) => { try { if (editingNode() && editingNode()!.id) { @@ -1900,7 +1900,7 @@ docker run -d \ setModalResetKey(prev => prev + 1); }} nodeType="pbs" - editingNode={editingNode() ?? undefined} + editingNode={editingNode()?.type === 'pbs' ? editingNode() ?? undefined : undefined} onSave={async (nodeData) => { try { if (editingNode() && editingNode()!.id) {