vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-13 16:54:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Polish mobile settings experience

Browse source
This commit is contained in:
Pulse Test 2026-08-28 11:47:57 +01:00
parent 3916854c18
commit 747f79f75e
23 changed files with 441 additions and 238 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/integration/tests/15-settings-shell-consistency.spec.ts
View file

@ -109,8 +109,9 @@ test.describe('Settings shell consistency', () => {
await page.waitForURL(/\/settings/, { timeout: 15_000 });
if (isMobile) {
// Mobile keeps the settings navigation behind the Settings drawer
// trigger instead of a persistent sidebar.
// Mobile is a two-level workspace: the compact section header opens
// the full settings index, and selecting the active section returns
// to its content without leaving the route.
await page
.getByRole('main')
.getByRole('button', { name: 'Settings', exact: true })
@ -124,6 +125,24 @@ test.describe('Settings shell consistency', () => {
const searchInput = page.getByPlaceholder('Search settings...');
await expect(searchInput, `${panel.route} should keep the shared settings search`).toBeVisible();
if (isMobile) {
await expect(
navigation.getByRole('heading', { level: 1, name: 'Settings' }),
`${panel.route} should label the mobile settings index`,
).toBeVisible();
const activeSection = navigation.locator('button[aria-current="page"]');
if ((await activeSection.count()) === 1) {
await activeSection.click();
} else {
// A valid direct route can be omitted from the index by capability
// or feature visibility. The index must still be dismissible.
await navigation
.getByRole('button', { name: 'Close settings navigation', exact: true })
.click();
}
await expect(navigation).toBeHidden();
}
const pageHeading = page.getByRole('heading', { level: 1, name: panel.title });
await expect(pageHeading, `${panel.route} should render the canonical page-shell heading`).toBeVisible();