vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-05-05 23:36:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(recovery): centralize item type derivation

Browse source
This commit is contained in:
rcourtman 2026-03-26 12:10:28 +00:00
parent e64f1c5811
commit 702336baf9
11 changed files with 93 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

15
frontend-modern/src/components/Recovery/RecoveryProtectedInventorySection.tsx
View file

@ -25,6 +25,7 @@ import {
} from '@/utils/recoveryEmptyStatePresentation';
import {
getRecoveryItemTypePresentation,
getRecoveryRollupItemTypeKey,
normalizeRecoveryItemTypeQueryValue,
} from '@/utils/recoveryItemTypePresentation';
import {
@ -124,12 +125,8 @@ export const RecoveryProtectedInventorySection: Component<
return multiplier * leftLabel.localeCompare(rightLabel);
}
case 'type': {
const leftType = getRecoveryItemTypePresentation(
left.display?.itemType || left.display?.subjectType || left.subjectRef?.type,
)?.label.toLowerCase();
const rightType = getRecoveryItemTypePresentation(
right.display?.itemType || right.display?.subjectType || right.subjectRef?.type,
)?.label.toLowerCase();
const leftType = getRecoveryItemTypePresentation(getRecoveryRollupItemTypeKey(left))?.label.toLowerCase();
const rightType = getRecoveryItemTypePresentation(getRecoveryRollupItemTypeKey(right))?.label.toLowerCase();
return multiplier * (leftType || '').localeCompare(rightType || '');
}
case 'platform': {
@ -376,11 +373,7 @@ export const RecoveryProtectedInventorySection: Component<
getSourcePlatformLabel(left).localeCompare(getSourcePlatformLabel(right)),
);
const itemTypePresentation =
getRecoveryItemTypePresentation(
rollup.display?.itemType ||
rollup.display?.subjectType ||
rollup.subjectRef?.type,
) || null;
getRecoveryItemTypePresentation(getRecoveryRollupItemTypeKey(rollup)) || null;
const nowMs = Date.now();
const issueTone: RecoveryIssueTone = getRecoveryRollupIssueTone(rollup, nowMs);
const issueRailClass =