mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-04-29 12:00:13 +00:00
fix(ai): improve AI settings UX with validation and smart fallbacks
Backend:
- Add smart provider fallback when selected model's provider isn't configured
- Automatically switch to a model from a configured provider instead of failing
- Log warning when fallback occurs for visibility
Frontend (AISettings.tsx):
- Add helper functions to check if model's provider is configured
- Group model dropdown: configured providers first, unconfigured marked with ⚠️
- Add inline warning when selecting model from unconfigured provider
- Validate on save that model's provider is configured (or being added)
- Warn before clearing last configured provider (would disable AI)
- Warn before clearing provider that current model uses
- Add patrol interval validation (must be 0 or >= 10 minutes)
- Show red border + inline error for invalid patrol intervals 1-9
- Update patrol interval hint: '(0=off, 10+ to enable)'
These changes prevent confusing '500 Internal Server Error' and
'AI is not enabled or configured' errors when model/provider mismatch.
This commit is contained in:
parent
c4b893e257
commit
54fc259221
15 changed files with 766 additions and 138 deletions
78
.github/workflows/test-e2e.yml
vendored
Normal file
78
.github/workflows/test-e2e.yml
vendored
Normal file
|
|
@ -0,0 +1,78 @@
|
|||
name: Core E2E Tests
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
branches:
|
||||
- main
|
||||
paths:
|
||||
- 'frontend-modern/**'
|
||||
- 'internal/**'
|
||||
- 'tests/integration/**'
|
||||
- 'Dockerfile'
|
||||
- '.github/workflows/test-e2e.yml'
|
||||
push:
|
||||
branches:
|
||||
- main
|
||||
- master
|
||||
paths:
|
||||
- 'frontend-modern/**'
|
||||
- 'internal/**'
|
||||
- 'tests/integration/**'
|
||||
- 'Dockerfile'
|
||||
- '.github/workflows/test-e2e.yml'
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
e2e:
|
||||
name: Playwright Core E2E
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v4
|
||||
|
||||
- name: Set up Node.js
|
||||
uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: '20'
|
||||
cache: 'npm'
|
||||
cache-dependency-path: tests/integration/package-lock.json
|
||||
|
||||
- name: Install Playwright dependencies
|
||||
working-directory: tests/integration
|
||||
run: |
|
||||
npm ci
|
||||
npx playwright install --with-deps chromium
|
||||
|
||||
- name: Build Docker images for test environment
|
||||
run: |
|
||||
docker build -t pulse-mock-github:test ./tests/integration/mock-github-server
|
||||
docker build -t pulse:test -f Dockerfile .
|
||||
|
||||
- name: Run E2E suite
|
||||
working-directory: tests/integration
|
||||
env:
|
||||
PULSE_E2E_BOOTSTRAP_TOKEN: 0123456789abcdef0123456789abcdef0123456789abcdef
|
||||
run: npm test
|
||||
|
||||
- name: Upload Playwright report
|
||||
if: always()
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: playwright-report
|
||||
path: tests/integration/playwright-report/
|
||||
retention-days: 30
|
||||
|
||||
- name: Upload test videos and screenshots
|
||||
if: failure()
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: test-failures
|
||||
path: tests/integration/test-results/
|
||||
retention-days: 7
|
||||
|
||||
Loading…
Add table
Add a link
Reference in a new issue