mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-05-20 01:01:20 +00:00
fix: improve OIDC redirect URL validation and help text
addresses #327 Fixed issues when PUBLIC_URL is not set: - Better error message explaining how to fix missing redirect URL - Help text now shows actionable guidance instead of incomplete message - Hide IdP redirect URL hint when no default is available
This commit is contained in:
parent
6a2b053c7a
commit
386bee1aa6
2 changed files with 12 additions and 6 deletions
|
|
@ -324,7 +324,11 @@ export const OIDCPanel: Component<Props> = (props) => {
|
|||
class={controlClass()}
|
||||
disabled={isEnvLocked() || saving()}
|
||||
/>
|
||||
<p class={formHelpText}>If left blank, Pulse will use {config()?.defaultRedirect}.</p>
|
||||
<p class={formHelpText}>
|
||||
{config()?.defaultRedirect
|
||||
? `If left blank, Pulse will use ${config()?.defaultRedirect}`
|
||||
: 'Set PUBLIC_URL environment variable or enter redirect URL manually'}
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
|
|
@ -432,10 +436,12 @@ export const OIDCPanel: Component<Props> = (props) => {
|
|||
</div>
|
||||
|
||||
<div class="flex flex-wrap items-center justify-between gap-3 pt-4">
|
||||
<div class="text-xs text-gray-500 dark:text-gray-400">
|
||||
Redirect URL registered with your IdP must match Pulse:{' '}
|
||||
{config()?.defaultRedirect || ''}
|
||||
</div>
|
||||
<Show when={config()?.defaultRedirect}>
|
||||
<div class="text-xs text-gray-500 dark:text-gray-400">
|
||||
Redirect URL registered with your IdP must match Pulse:{' '}
|
||||
{config()?.defaultRedirect}
|
||||
</div>
|
||||
</Show>
|
||||
<div class="flex gap-3">
|
||||
<button
|
||||
type="button"
|
||||
|
|
|
|||
|
|
@ -120,7 +120,7 @@ func (c *OIDCConfig) Validate() error {
|
|||
}
|
||||
|
||||
if strings.TrimSpace(c.RedirectURL) == "" {
|
||||
return fmt.Errorf("oidc redirect url is required when OIDC is enabled")
|
||||
return fmt.Errorf("oidc redirect url is required when OIDC is enabled (set PUBLIC_URL environment variable or provide redirect URL manually)")
|
||||
}
|
||||
if _, err := url.ParseRequestURI(c.RedirectURL); err != nil {
|
||||
return fmt.Errorf("invalid oidc redirect url: %w", err)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue