vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-05-19 07:54:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fail closed on stale API action plans

Browse source
This commit is contained in:
rcourtman 2026-05-12 16:55:51 +01:00
parent 3566a4d61d
commit 29a815ef2a
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/create-release.yml vendored
View file

@ -1080,7 +1080,7 @@ jobs:
needs:
- prepare
- validate_release_assets
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' }}
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' && github.event.inputs.draft_only != 'true' }}
permissions:
contents: read
uses: ./.github/workflows/install-sh-smoke.yml
@ -1103,7 +1103,7 @@ jobs:
needs:
- prepare
- validate_release_assets
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' }}
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' && github.event.inputs.draft_only != 'true' }}
permissions:
contents: write
packages: write
@ -1125,7 +1125,7 @@ jobs:
needs:
- prepare
- validate_release_assets
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' }}
if: ${{ always() && needs.prepare.result == 'success' && needs.validate_release_assets.result == 'success' && needs.prepare.outputs.historical_asset_backfill_only != 'true' && github.event.inputs.draft_only != 'true' }}
permissions:
contents: read
packages: write

7
scripts/installtests/build_release_assets_test.go
View file

@ -193,6 +193,13 @@ func TestCreateReleaseUploadsPowerShellInstaller(t *testing.T) {
`promote_floating_tags:`,
`tag: ${{ needs.prepare.outputs.tag }}`,
`prerelease: ${{ needs.prepare.outputs.is_prerelease == 'true' }}`,
// Draft-only mode (draft_only=true input) keeps the release as a
// draft and skips the publish step. The three workflow_call'd
// downstreams must skip in that mode too — install-sh-smoke can't
// reach the /releases/download/<tag>/ URL of a draft (404), and
// helm publish + tag promotion would advance externally-visible
// state to a release that hasn't been promoted out of draft yet.
`needs.prepare.outputs.historical_asset_backfill_only != 'true' && github.event.inputs.draft_only != 'true'`,
}
for _, needle := range required {
if !strings.Contains(workflow, needle) {